From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CF48A034C; Wed, 22 Jun 2022 17:34:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C611C40A84; Wed, 22 Jun 2022 17:34:47 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A24E64069F for ; Wed, 22 Jun 2022 17:34:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655912086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i/vQeaitYToOYw9La+sVYwjlBMfjLAJvBPkT0oiwfJA=; b=TM3NYZqx788dKI+u8JmvWo9BDGhGxaF2mmiSrbfa9DU/sZe6aJJsGs0H3DAvJcAyq3HDXG hskX98KP+dGDDLMQzdiw2y6QVHgFYlRue97z58B5xyx8FPvFz9+Sm8ydaGNEjYhN6A0aSy 3FQk9qlO6GPMkWIt5jZG5056OfzEIrM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-457-sa99JrevMVu0aQZCp394dQ-1; Wed, 22 Jun 2022 11:34:45 -0400 X-MC-Unique: sa99JrevMVu0aQZCp394dQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 987751802CE4; Wed, 22 Jun 2022 15:34:44 +0000 (UTC) Received: from [10.39.208.40] (unknown [10.39.208.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A14B5141510C; Wed, 22 Jun 2022 15:34:43 +0000 (UTC) Message-ID: <88d34cf3-0837-37cb-2bc4-c462bbd786bd@redhat.com> Date: Wed, 22 Jun 2022 17:34:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] vhost/crypto: fix descriptor processing To: David Marchand , dev@dpdk.org Cc: roy.fan.zhang@intel.com, Jakub Poczatek , Chenbo Xia References: <20220622153020.2598037-1-david.marchand@redhat.com> From: Maxime Coquelin In-Reply-To: <20220622153020.2598037-1-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/22/22 17:30, David Marchand wrote: > copy_data was returning a pointer to an increased (off by one) descriptor. > Subsequent calls to copy_data in the library were then failing. > Fix this by incrementing the descriptor only if there is some left data > to copy. > > Fixes: 7287660a21e0 ("vhost/crypto: fix build with GCC 12") > > Reported-by: Jakub Poczatek > Signed-off-by: David Marchand Reviewed-by: Maxime Coquelin And also, from discussions on the faulty commit thread, we can add: Tested-by: Jakub Poczatek Thanks Jakub for the quick testing, Maxime > --- > lib/vhost/vhost_crypto.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/lib/vhost/vhost_crypto.c b/lib/vhost/vhost_crypto.c > index 96ffb82a5d..54946f46d9 100644 > --- a/lib/vhost/vhost_crypto.c > +++ b/lib/vhost/vhost_crypto.c > @@ -610,8 +610,7 @@ copy_data(void *data, struct vhost_crypto_data_req *vc_req, > return -1; > left -= copied; > data = RTE_PTR_ADD(data, copied); > - desc++; > - } while (desc < head + max_n_descs && left != 0); > + } while (left != 0 && ++desc < head + max_n_descs); > > if (unlikely(left != 0)) > return -1;