From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CF8BA0528; Fri, 17 Jul 2020 22:31:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C30AB1BEE7; Fri, 17 Jul 2020 22:31:10 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 1CE2A1BEDE for ; Fri, 17 Jul 2020 22:31:08 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200717203107euoutp0149edef7aca0952cfd9d256e26d25b200~ipEzP7Y9K2252322523euoutp01F for ; Fri, 17 Jul 2020 20:31:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200717203107euoutp0149edef7aca0952cfd9d256e26d25b200~ipEzP7Y9K2252322523euoutp01F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1595017867; bh=56YVVBCEU0v68qlJG8GSU65T2jYAlM75oxpgcnner/I=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=FM8fzyMPCuROxR0u6hKpwZKp13ml0Beeuc3cm7A3OAsu8r+2DKTWl//Vs9MHMwS25 R80qY6id1IUOjAqIUCzqiVnw+CfjZaJUNvPPydqq7bAFDTQ3bfMUMvS31jpEv+wXrR KgZ6hNpnWPnpeX6r1ce9pjRl8jZ6w0qu1GqIxWG8= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200717203107eucas1p263265ab61848592625918b44fb59276c~ipEyyFW_82628726287eucas1p2U; Fri, 17 Jul 2020 20:31:07 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id ED.E1.06456.B8A021F5; Fri, 17 Jul 2020 21:31:07 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200717203106eucas1p2daca5e94cb19afe172444c6b946b471c~ipEx8LtbF2617726177eucas1p2V; Fri, 17 Jul 2020 20:31:06 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200717203106eusmtrp218fedfc1b05ddabf1df744ae11af69b7~ipEx7juI-3179131791eusmtrp23; Fri, 17 Jul 2020 20:31:06 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-f3-5f120a8b9269 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id EC.68.06017.A8A021F5; Fri, 17 Jul 2020 21:31:06 +0100 (BST) Received: from [106.210.88.70] (unknown [106.210.88.70]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200717203105eusmtip11406a0e4bd160e9e8ac35dcc9f1a57ab~ipExGDoVh2514025140eusmtip1O; Fri, 17 Jul 2020 20:31:05 +0000 (GMT) To: David Marchand , Van Haaren Harry Cc: Igor Romanov , Honnappa Nagarahalli , Phil Yang , dev , Aaron Conole , Ferruh Yigit From: Lukasz Wojciechowski Message-ID: <88ee4323-1336-4bc7-414d-3dd7f19d684f@partner.samsung.com> Date: Fri, 17 Jul 2020 22:31:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Transfer-Encoding: 8bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA02SbUhTYRTHe3bv3a6r2d3V8GBSMogoSJMKb2VhIjEJosQKCp0rL1PUqZuu GQauQmQqWkNt5luKZKEZlc7El5jikmGJYEoq9WFSGy7JdKGrmdeb5Lffec7/nP85h4fE6OdE MJmmzmU1amWGTCjGu4ZX3h8qEdOKw7bPUmZ1/ouIsbQahcz3RYuAmemzixhDuQdnzHP3RIzV lM60LZRg0aS8rb4NyVcbWwh5c69TIJ9cdhHyhf4J4QXiqjgqhc1I07Ga8NPJ4lRH9aIoe5TW j/UOCgqRe6cRkSRQR6GqMteIxCRNtSKYm53E+WAJgWX8l4gPfiLonnGsZ/w2KkqbTSKOaeoJ gtL7OTy7EdzpSeA4gDoBdR7nhiaQUoDNU4y4RhjlWNd7SjYSQuoUDJmXCY4l1FkwuB8KOcap ffDuTy3G8S4qCTqcFgGvkcKImR/Cj7oILZ4hxDFG7YW7nY8wnoPgk6NBwJkBZRXB7Pw0wU8d C50fqwQ8B4DL9lrEcwisvdks6EIw4V1BfDCAYLKs9Z/qJAz6vELuYhh1ADp6wvnjnYEP3ts8 +sOUW8rP4A8Puqox/lkCxUU03yMM5kor0abr73YHXoFkNVs2q9myTc2WbWr+2zYi/BkKYvO0 mSpWG6Fmb4ZplZnaPLUq7EZW5ku0/ovsPttiN1oev25FFIlkOyTFbVIFTSh12vxMKwISkwVK YkbtSbQkRZl/i9VkKTR5GazWinaTuCxIcqTJmUhTKmUum86y2axmMysg/YILEbE6lRjKGAvq 9WtPA4RFBrJddSy9tjA+MFJnKsiecGScj1NF52mOT4+57MkeRbvvnNdnTthuXWLS6sobr7QX VoTuj495EeV+W3050uOUKkes+hCi/8ciIY/NcXnle/Iv6R8bXg0X9cjrvzbgA2D6ZhfG6TxN 5r5tluiyazJcm6qMOIhptMq/oVVXZ0EDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrEIsWRmVeSWpSXmKPExsVy+t/xu7pdXELxBl92iFr8evOA3WL7ii42 i3eftjNZ3Nl7mt2isf8bi8XMpy3sFocmZ1used/N7MDhsWbeGkaPXwuWsnos3vOSyeP611es Hu/3XWULYI3SsynKLy1JVcjILy6xVYo2tDDSM7S00DMysdQzNDaPtTIyVdK3s0lJzcksSy3S t0vQy3gy/RN7wVmhigt7DjM1ML7l72Lk5JAQMJHoWTyZvYuRi0NIYCmjxMsXP5i6GDmAEjIS Hy4JQNQIS/y51sUGUfOaUeLPux5WkISwgJXE3G8v2UFsEYF4iSXTtjGCFDELPGGUaFjVyQyS EBJ4yiSx948ciM0mYCtxZOZXsGZeATeJxrcz2EBsFgFViRN/54DViwrESSzfMp8dokZQ4uTM JywgNqdAoMTSb0cYQWxmATOJeZsfMkPY8hLNW2dD2eISt57MZ5rAKDQLSfssJC2zkLTMQtKy gJFlFaNIamlxbnpusZFecWJucWleul5yfu4mRmD8bTv2c8sOxq53wYcYBTgYlXh4DVYJxgux JpYVV+YeYpTgYFYS4XU6ezpOiDclsbIqtSg/vqg0J7X4EKMp0HMTmaVEk/OBqSGvJN7Q1NDc wtLQ3Njc2MxCSZy3Q+BgjJBAemJJanZqakFqEUwfEwenVANj+LlL915ULE29tvvy4iuX/WR+ dma/eCnTtXuV7toC242vX9oGs+VXCS57UDBfS1FG6ILq82kzbpZNdln6nSP1ro6y6EyT/rsZ +m/4vErdd3jb3knwadfx85RcqZD/0s58XrDHmYW/E+e+E12ZazxxuuSUB5cNw/ff+XDQOv3k hjsdOgqMNl0qSizFGYmGWsxFxYkA2h1YC9UCAAA= X-CMS-MailID: 20200717203106eucas1p2daca5e94cb19afe172444c6b946b471c X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200717151927eucas1p200a2d921ccf1fd5ab1d62c0f964b7594 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200717151927eucas1p200a2d921ccf1fd5ab1d62c0f964b7594 References: <6d0bf076-c9bd-564c-20f6-ba8a49bc2389@intel.com> Subject: Re: [dpdk-dev] Random failure in service_autotest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" W dniu 17.07.2020 o 17:19, David Marchand pisze: > On Fri, Jul 17, 2020 at 10:56 AM David Marchand > wrote: >> On Wed, Jul 15, 2020 at 12:41 PM Ferruh Yigit wrote: >>> On 7/15/2020 11:14 AM, David Marchand wrote: >>>> Hello Harry and guys who touched the service code recently :-) >>>> >>>> I spotted a failure for the service UT in Travis: >>>> https://travis-ci.com/github/ovsrobot/dpdk/jobs/361097992#L18697 >>>> >>>> I found only a single instance of this failure and tried to reproduce >>>> it with my usual "brute" active loop with no success so far. >>> +1, I didn't able to reproduce it in my environment but observed it in the >>> Travis CI. >>> >>>> Any chance it could be due to recent changes? >>>> https://protect2.fireeye.com/url?k=70a801b3-2d7b5aa7-70a98afc-0cc47a31ce4e-231dc7b8ee6eb8a9&q=1&u=https%3A%2F%2Fgit.dpdk.org%2Fdpdk%2Fcommit%2F%3Fid%3Df3c256b621262e581d3edcca383df83875ab7ebe >>>> https://protect2.fireeye.com/url?k=21dbcfd3-7c0894c7-21da449c-0cc47a31ce4e-d8c6abfb03bf67f1&q=1&u=https%3A%2F%2Fgit.dpdk.org%2Fdpdk%2Fcommit%2F%3Fid%3D048db4b6dcccaee9277ce5b4fbb2fe684b212e22 >> I can see more occurrences of the issue in the CI. >> I just applied the patch changing the log level for test assert, in >> the hope it will help. > And... we just got one with logs: > https://travis-ci.com/github/ovsrobot/dpdk/jobs/362109882#L18948 > > EAL: Test assert service_lcore_attr_get line 396 failed: > lcore_attr_get() didn't get correct loop count (zero) > > It looks like a race between the service core still running and the > core resetting the loops attr. > Yes, it seems to be just lack of patience of the test. It should wait a bit for lcore to stop before resetting attrs. Something like this should help: @@ -384,6 +384,9 @@ service_lcore_attr_get(void)         rte_service_lcore_stop(slcore_id); +       /* wait for the service lcore to stop */ +       rte_delay_ms(200); +         TEST_ASSERT_EQUAL(0, rte_service_lcore_attr_reset_all(slcore_id),                           "Valid lcore_attr_reset_all() didn't return success"); -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com