From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B507DA034F; Tue, 11 Jan 2022 16:24:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 44B964272E; Tue, 11 Jan 2022 16:24:06 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id CFE6741143 for ; Tue, 11 Jan 2022 16:24:04 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 315AD3200FA9; Tue, 11 Jan 2022 10:24:02 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 11 Jan 2022 10:24:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= CpshH02a1meFrU7O2uKfn87KbxapaFQ4ojcOrWEucOk=; b=d4y4SfJts++9n4bN ndwuVQFSO9yCyqBKFp6/UpwepaHCvQuNHh7tdjTQDGLaudSoXoR3SbWINn0m154o 57sTUNNGGfmtJwtSw0w1oWpsTyjVyLafP4eMTxA/Z6kosqnf5AqeQIOwXsk4Lzv5 DezcY64lxeqq/gKN333KEJr31j9Wp9Rk5f9I6KMhvdZa968yTwu6JnsXgeiX/R56 4Zl5jRMtQFu9ehYsNXVjP9SmR1dWwUO87qj/jurUIzGfJb9NBTylHmFcl+rO9JDU oGa60NPanllhUT7aKUb4fxz5u3hzJF9wDM+cSj5YIksZwCqeUsCMIti5guUDE4N4 CbH56g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=CpshH02a1meFrU7O2uKfn87KbxapaFQ4ojcOrWEuc Ok=; b=b45xhFGICn2l/U2ECeCNkHpmBeD5ajbfVpDLNAnfmxM2/vaXte+YQnkXK huFW/qhjwrn0nkKCG664HxYKoGEyTUSkqBBIbGEVPVpFeVkU2nPRvJHdQNNIlh5g iSrOfpMu46X3jgjJQ5He6Vj8pYnS3K+Ic20NVBstvJ75JEZFPQhiUF8Rvk/APzbO toCw8A1Fg+P43SiPLjNb2eY2vmGosCP9nrG5vIb2j2sqy5c8BvRHDsFpLng7Pbck VfgWR1LRy4DnCXB+4cqJshvML14N5nwOFZcW4Oj5xwOEK21smGPFdDjoqsIitcdo iyO7xg78aGm0UIBlHswmy9gKGoT6w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudehfedgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 11 Jan 2022 10:23:59 -0500 (EST) From: Thomas Monjalon To: Akhil Goyal , Jerin Jacob , Anoob Joseph Cc: Archana Muniganti , Tejasree Kondoj , dev@dpdk.org, david.marchand@redhat.com Subject: Re: [PATCH v3 21/29] crypto/cnxk: add more info on command timeout Date: Tue, 11 Jan 2022 16:23:58 +0100 Message-ID: <8925463.rMLUfLXkoz@thomas> In-Reply-To: <1639732811-1440-22-git-send-email-anoobj@marvell.com> References: <1639676975-1316-1-git-send-email-anoobj@marvell.com> <1639732811-1440-1-git-send-email-anoobj@marvell.com> <1639732811-1440-22-git-send-email-anoobj@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 17/12/2021 10:20, Anoob Joseph: > Print more info when command timeout happens. Print software and > hardware queue information. > > Signed-off-by: Anoob Joseph > Signed-off-by: Tejasree Kondoj > --- > +void > +cnxk_cpt_dump_on_err(struct cnxk_cpt_qp *qp) > +{ > + struct pending_queue *pend_q = &qp->pend_q; > + uint64_t inflight, enq_ptr, deq_ptr, insts; > + union cpt_lf_q_inst_ptr inst_ptr; > + union cpt_lf_inprog lf_inprog; > + > + plt_print("Lcore ID: %d, LF/QP ID: %d", rte_lcore_id(), qp->lf.lf_id); > + plt_print(""); > + plt_print("S/w pending queue:"); > + plt_print("\tHead: %ld", pend_q->head); > + plt_print("\tTail: %ld", pend_q->tail); > + plt_print("\tMask: 0x%lx", pend_q->pq_mask); > + plt_print("\tInflight count: %ld", > + pending_queue_infl_cnt(pend_q->head, pend_q->tail, > + pend_q->pq_mask)); > + > + plt_print(""); > + plt_print("H/w pending queue:"); > + > + lf_inprog.u = plt_read64(qp->lf.rbase + CPT_LF_INPROG); > + inflight = lf_inprog.s.inflight; > + plt_print("\tInflight in engines: %ld", inflight); > + > + inst_ptr.u = plt_read64(qp->lf.rbase + CPT_LF_Q_INST_PTR); > + > + enq_ptr = inst_ptr.s.nq_ptr; > + deq_ptr = inst_ptr.s.dq_ptr; > + > + if (enq_ptr >= deq_ptr) > + insts = enq_ptr - deq_ptr; > + else > + insts = (enq_ptr + pend_q->pq_mask + 1 + 320 + 40) - deq_ptr; > + > + plt_print("\tNQ ptr: 0x%lx", enq_ptr); > + plt_print("\tDQ ptr: 0x%lx", deq_ptr); > + plt_print("Insts waiting in CPT: %ld", insts); > + > + plt_print(""); > + roc_cpt_afs_print(qp->lf.roc_cpt); > +} This functions is wrong. You cannot print 64-bit values with %l. In 32-bit mode, compilation will fail. Please use PRIx64. Note: this mistake is warned by the script devtools/checkpatches.sh Warning in drivers/crypto/cnxk/cnxk_cryptodev_ops.c: Using %l format, prefer %PRI*64 if type is [u]int64_t I will wait for the next-crypto tree to be fixed.