From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E79784286D;
	Thu, 30 Mar 2023 09:16:32 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C23DC40E25;
	Thu, 30 Mar 2023 09:16:32 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id D4A1440685
 for <dev@dpdk.org>; Thu, 30 Mar 2023 09:16:30 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 26B565A;
 Thu, 30 Mar 2023 10:16:30 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 26B565A
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1680160590;
 bh=6sTu50QofUTfE804dEcyMtSvTfWzmgu95s/JBoc29mQ=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=Hm23Ig0h2jgMx33zgouweYQlO9QAyw6nJ+crphegG9cB883JRu41gCx2keHQqgQX/
 8kykKkkkagxYy4cQgJlZZCVLKQh/GXtEXjp6PXIM/8rE3/NFGFXhPE584TUzjEimim
 LjcAqhSTkVEMV/c5KqjLUOI2D2DDmed+/lrtLWD8=
Message-ID: <89267f8e-67fd-2858-44f3-d330933b7350@oktetlabs.ru>
Date: Thu, 30 Mar 2023 10:16:29 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] common/sfc_efx/base: support link status change v2 events
Content-Language: en-US
To: Ivan Malov <ivan.malov@arknetworks.am>, dev@dpdk.org
Cc: Ferruh Yigit <ferruh.yigit@amd.com>, Andy Moreton <amoreton@xilinx.com>
References: <20230328165112.6535-1-ivan.malov@arknetworks.am>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20230328165112.6535-1-ivan.malov@arknetworks.am>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 3/28/23 19:51, Ivan Malov wrote:
> FW should send link status change events in either v1 or
> v2 format depending on the preference which the driver
> can express during CMD_DRV_ATTACH stage. At the moment,
> libefx does not request v2, so v1 events must arrive.
> However, FW does not honour this choice and always
> sends v2 events. So teach libefx to parse such and
> add v2 request to CMD_DRV_ATTACH, correspondingly.
> 
> Signed-off-by: Ivan Malov <ivan.malov@arknetworks.am>
> Reviewed-by: Andy Moreton <amoreton@xilinx.com>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>