From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id F1E1242DE6;
Thu, 6 Jul 2023 11:37:29 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id C3EFE410FA;
Thu, 6 Jul 2023 11:37:29 +0200 (CEST)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
[66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id C28CC40A79
for <dev@dpdk.org>; Thu, 6 Jul 2023 11:37:28 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 07B675C014D;
Thu, 6 Jul 2023 05:37:28 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Thu, 06 Jul 2023 05:37:28 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:cc:content-transfer-encoding:content-type:content-type:date
:date:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:sender:subject:subject:to:to; s=fm2; t=
1688636248; x=1688722648; bh=cthNr0txQLhvShYmZMujeAM0MVQ2YRSEokx
pG+FntTY=; b=lelPAHDQfKn0oZzeSA8dGGCkfqJYRmsaF6G18SBFYqqrKdoRWj/
eVasuAyS+uONh1RjzCnizVhe6PmTapHrbgZ9r6qj5Y7Iw50Z2inAb9UGjR6oxPnt
a+a7ztHsf7ARfmDqvrwbXDN7ktIqZHCagt5TCsAixidks+cAtV5UmV3tuOasc508
Wi7Qmk/pOVZP8CQmRGV8XQ+HJ0AZpCYsaHg5am4djflhpugvEqD15EbHqnzK0RJj
/0yi2AzLF0htHPagb2/VEZP672fUGhghG2i0WQEMmm7G3dJp/0/k1iBWDbWDrt6E
RHLIzdfZrER6MDHqPSOsPsDns2OywB1T57g==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding
:content-type:content-type:date:date:feedback-id:feedback-id
:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:sender:subject:subject:to:to:x-me-proxy
:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=
1688636248; x=1688722648; bh=cthNr0txQLhvShYmZMujeAM0MVQ2YRSEokx
pG+FntTY=; b=SUtpDUtUj3z7kAZQUfs956RuIwuCSXkqNQtaIw9MPUp4kBVa19U
66PZiu/+Mc7JqyDa1x8WvadUIBFY6lqoFaeAYwoROx7OmNiZs0KS/nNbH3CX6Xp2
/gO0/vpMaGg8z+TEiQSq32A4+ZjbYK1Zp1iWsqAeoBAIUWcGjIv3016FqeTyBkRJ
NFQN4PkAKax6Thhh1IHAzOikAtmAD0CoabaBBKf23npLx7c/aMou4hGHIsX7Bhco
NGPzV+1BfXyJlY4wQ3f3qQxK+jO74bv4QGrKuycahssLm+4PYUUXK1/bbPVhYclV
neJE5cb9fgfPZzpr4ej0PbM1uFhcLFT7MRw==
X-ME-Sender: <xms:V4umZMR0IvhpN1Opg_Mmxl_XVtC0_ccx_19M-nfQol3bWqm_AMXQtA>
<xme:V4umZJzrOYC1-cZpz2s4eaHG9ZbWOE4ViKncOIBj4L7vK9TlN3sj3PGcVLunaZ14-
AoNJkBQvCM2TiBsDA>
X-ME-Received: <xmr:V4umZJ3RhxW3eyxKGaKP0Gyzz_a0Z0sb-irtyjb6J3wicA4gf58olS5hQ7IQB2HK9SPFD49EBJdhlQ7f-nSBpzQ-PA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudelgddukecutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek
gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh
homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:V4umZAC6xtgQ8atTKI2q1_cdERr2PldVv49COyawToM3wjL7xTRGRQ>
<xmx:V4umZFj2_IvCfSz_34bSBwNCl71wdnpA5GDOuYPimtABvrhLIoAP5g>
<xmx:V4umZMqPDsqRF9hucD1jl9UPs_FcZrgTq2ULk9UahZXxmuW7IzdIHQ>
<xmx:WIumZGVb8plI7seZcqglbgpmy98G5mb-i_e2RJFKY-1ETGBY2vyvVQ>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
6 Jul 2023 05:37:26 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>,
Bing Zhao <bingz@nvidia.com>
Cc: dev@dpdk.org, Matan Azrad <matan@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>,
"dev@dpdk.org" <dev@dpdk.org>, Michael Baum <michaelba@nvidia.com>
Subject: Re: [PATCH 1/7] net/mlx5: fix the modify field check of tag
Date: Thu, 06 Jul 2023 11:37:24 +0200
Message-ID: <8931222.T7Z3S40VBb@thomas>
In-Reply-To: <DM4PR12MB5184FC30E15F00BEC783A34DD029A@DM4PR12MB5184.namprd12.prod.outlook.com>
References: <20230630054303.432238-1-bingz@nvidia.com>
<20230629230831.10023261@hermes.local>
<DM4PR12MB5184FC30E15F00BEC783A34DD029A@DM4PR12MB5184.namprd12.prod.outlook.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
03/07/2023 15:31, Bing Zhao:
> Hi Stephen,
> If I understand correctly, do you mean that the internal value and rte_flow API value may have some conflict?
> All the MLX5 internal enum values start from INT_MIN. When treating it as a int value, it would not have the same value with rte_flow enums, unless all the 2^^32 are defined.
> But yes, this has some risk since there is no limitation of the values in the rte_flow API.
We can assume it will never happen.
This is good to go.
> > -----Original Message-----
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > Sent: Friday, June 30, 2023 2:09 PM
> > To: Bing Zhao <bingz@nvidia.com>
> > Cc: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> > <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; Suanming Mou
> > <suanmingm@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>;
> > dev@dpdk.org; Michael Baum <michaelba@nvidia.com>
> > Subject: Re: [PATCH 1/7] net/mlx5: fix the modify field check of tag
> >
> > External email: Use caution opening links or attachments
> >
> >
> > On Fri, 30 Jun 2023 08:43:03 +0300
> > Bing Zhao <bingz@nvidia.com> wrote:
> >
> > > @@ -1117,9 +1117,10 @@ flow_dv_fetch_field(const uint8_t *data,
> > > uint32_t size) static inline bool
> > > flow_modify_field_support_tag_array(enum rte_flow_field_id field) {
> > > - switch (field) {
> > > + switch ((int)field) {
> > > case RTE_FLOW_FIELD_TAG:
> > > case RTE_FLOW_FIELD_MPLS:
> > > + case MLX5_RTE_FLOW_FIELD_META_REG:
> >
> > Mixing internal and API fields seems like something that could get easily
> > broken by changes to rte_flow.
>