* [PATCH] examples/l3fwd-power: support CPPC cpufreq
@ 2023-01-31 2:58 Jie Hai
2023-02-22 2:13 ` Jie Hai
2023-03-09 7:23 ` Dongdong Liu
0 siblings, 2 replies; 6+ messages in thread
From: Jie Hai @ 2023-01-31 2:58 UTC (permalink / raw)
To: david.hunt; +Cc: liudongdong3, haijie1, dev
Currently the l3fwd-power only supports ACPI cpufreq and Pstate
cpufreq, This patch adds CPPC cpufreq.
Signed-off-by: Jie Hai <haijie1@huawei.com>
---
examples/l3fwd-power/main.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index fd3ade330f82..5090d5598172 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -2453,9 +2453,10 @@ init_power_library(void)
/* we're not supporting the VM channel mode */
env = rte_power_get_env();
if (env != PM_ENV_ACPI_CPUFREQ &&
- env != PM_ENV_PSTATE_CPUFREQ) {
+ env != PM_ENV_PSTATE_CPUFREQ &&
+ env != PM_ENV_CPPC_CPUFREQ) {
RTE_LOG(ERR, POWER,
- "Only ACPI and PSTATE mode are supported\n");
+ "Only ACPI, PSTATE and CPPC mode are supported\n");
return -1;
}
}
@@ -2639,12 +2640,14 @@ autodetect_mode(void)
/*
* Empty poll and telemetry modes have to be specifically requested to
* be enabled, but we can auto-detect between interrupt mode with or
- * without frequency scaling. Both ACPI and pstate can be used.
+ * without frequency scaling. Any of ACPI, pstate and CPPC can be used.
*/
if (rte_power_check_env_supported(PM_ENV_ACPI_CPUFREQ))
return APP_MODE_LEGACY;
if (rte_power_check_env_supported(PM_ENV_PSTATE_CPUFREQ))
return APP_MODE_LEGACY;
+ if (rte_power_check_env_supported(PM_ENV_CPPC_CPUFREQ))
+ return APP_MODE_LEGACY;
RTE_LOG(NOTICE, L3FWD_POWER, "Frequency scaling not supported, selecting interrupt-only mode\n");
--
2.30.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] examples/l3fwd-power: support CPPC cpufreq
2023-01-31 2:58 [PATCH] examples/l3fwd-power: support CPPC cpufreq Jie Hai
@ 2023-02-22 2:13 ` Jie Hai
2023-02-22 9:46 ` Hunt, David
2023-03-09 7:23 ` Dongdong Liu
1 sibling, 1 reply; 6+ messages in thread
From: Jie Hai @ 2023-02-22 2:13 UTC (permalink / raw)
To: david.hunt; +Cc: liudongdong3, dev
Hi, David Hunt,
Kindly ping. Could you please take a look at this patch?
Thanks,
Jie Hai
On 2023/1/31 10:58, Jie Hai wrote:
> Currently the l3fwd-power only supports ACPI cpufreq and Pstate
> cpufreq, This patch adds CPPC cpufreq.
>
> Signed-off-by: Jie Hai <haijie1@huawei.com>
> ---
> examples/l3fwd-power/main.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
> index fd3ade330f82..5090d5598172 100644
> --- a/examples/l3fwd-power/main.c
> +++ b/examples/l3fwd-power/main.c
> @@ -2453,9 +2453,10 @@ init_power_library(void)
> /* we're not supporting the VM channel mode */
> env = rte_power_get_env();
> if (env != PM_ENV_ACPI_CPUFREQ &&
> - env != PM_ENV_PSTATE_CPUFREQ) {
> + env != PM_ENV_PSTATE_CPUFREQ &&
> + env != PM_ENV_CPPC_CPUFREQ) {
> RTE_LOG(ERR, POWER,
> - "Only ACPI and PSTATE mode are supported\n");
> + "Only ACPI, PSTATE and CPPC mode are supported\n");
> return -1;
> }
> }
> @@ -2639,12 +2640,14 @@ autodetect_mode(void)
> /*
> * Empty poll and telemetry modes have to be specifically requested to
> * be enabled, but we can auto-detect between interrupt mode with or
> - * without frequency scaling. Both ACPI and pstate can be used.
> + * without frequency scaling. Any of ACPI, pstate and CPPC can be used.
> */
> if (rte_power_check_env_supported(PM_ENV_ACPI_CPUFREQ))
> return APP_MODE_LEGACY;
> if (rte_power_check_env_supported(PM_ENV_PSTATE_CPUFREQ))
> return APP_MODE_LEGACY;
> + if (rte_power_check_env_supported(PM_ENV_CPPC_CPUFREQ))
> + return APP_MODE_LEGACY;
>
> RTE_LOG(NOTICE, L3FWD_POWER, "Frequency scaling not supported, selecting interrupt-only mode\n");
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] examples/l3fwd-power: support CPPC cpufreq
2023-02-22 2:13 ` Jie Hai
@ 2023-02-22 9:46 ` Hunt, David
2023-03-06 6:35 ` Jie Hai
2023-03-12 14:39 ` Thomas Monjalon
0 siblings, 2 replies; 6+ messages in thread
From: Hunt, David @ 2023-02-22 9:46 UTC (permalink / raw)
To: Jie Hai; +Cc: liudongdong3, dev
On 22/02/2023 02:13, Jie Hai wrote:
> Hi, David Hunt,
>
> Kindly ping. Could you please take a look at this patch?
>
> Thanks,
> Jie Hai
>
> On 2023/1/31 10:58, Jie Hai wrote:
>> Currently the l3fwd-power only supports ACPI cpufreq and Pstate
>> cpufreq, This patch adds CPPC cpufreq.
>>
>> Signed-off-by: Jie Hai <haijie1@huawei.com>
>>
Hi, Jie Hai,
Apologies, this patch never got to my inbox.
Looks good to me.
Acked-by: David Hunt <david.hunt@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] examples/l3fwd-power: support CPPC cpufreq
2023-02-22 9:46 ` Hunt, David
@ 2023-03-06 6:35 ` Jie Hai
2023-03-12 14:39 ` Thomas Monjalon
1 sibling, 0 replies; 6+ messages in thread
From: Jie Hai @ 2023-03-06 6:35 UTC (permalink / raw)
To: thomas; +Cc: liudongdong3, dev, Hunt, David
Hi, Thomas,
A gentle ping~
Since this patch has been acked by David Hunt,
is there anything more I can do to push the process forward?
Thanks,
Jie Hai
On 2023/2/22 17:46, Hunt, David wrote:
>
> On 22/02/2023 02:13, Jie Hai wrote:
>> Hi, David Hunt,
>>
>> Kindly ping. Could you please take a look at this patch?
>>
>> Thanks,
>> Jie Hai
>>
>> On 2023/1/31 10:58, Jie Hai wrote:
>>> Currently the l3fwd-power only supports ACPI cpufreq and Pstate
>>> cpufreq, This patch adds CPPC cpufreq.
>>>
>>> Signed-off-by: Jie Hai <haijie1@huawei.com>
>>>
>
> Hi, Jie Hai,
>
> Apologies, this patch never got to my inbox.
>
> Looks good to me.
>
> Acked-by: David Hunt <david.hunt@intel.com>
>
>
> .
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] examples/l3fwd-power: support CPPC cpufreq
2023-02-22 9:46 ` Hunt, David
2023-03-06 6:35 ` Jie Hai
@ 2023-03-12 14:39 ` Thomas Monjalon
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2023-03-12 14:39 UTC (permalink / raw)
To: Jie Hai, liudongdong3; +Cc: dev, Hunt, David
22/02/2023 10:46, Hunt, David:
>
> On 22/02/2023 02:13, Jie Hai wrote:
> > Hi, David Hunt,
> >
> > Kindly ping. Could you please take a look at this patch?
> >
> > Thanks,
> > Jie Hai
> >
> > On 2023/1/31 10:58, Jie Hai wrote:
> >> Currently the l3fwd-power only supports ACPI cpufreq and Pstate
> >> cpufreq, This patch adds CPPC cpufreq.
> >>
> >> Signed-off-by: Jie Hai <haijie1@huawei.com>
> >>
>
> Hi, Jie Hai,
>
> Apologies, this patch never got to my inbox.
>
> Looks good to me.
>
> Acked-by: David Hunt <david.hunt@intel.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] examples/l3fwd-power: support CPPC cpufreq
2023-01-31 2:58 [PATCH] examples/l3fwd-power: support CPPC cpufreq Jie Hai
2023-02-22 2:13 ` Jie Hai
@ 2023-03-09 7:23 ` Dongdong Liu
1 sibling, 0 replies; 6+ messages in thread
From: Dongdong Liu @ 2023-03-09 7:23 UTC (permalink / raw)
To: Jie Hai, david.hunt, Thomas Monjalon, Ferruh Yigit; +Cc: dev
Hi Jie
On 2023/1/31 10:58, Jie Hai wrote:
> Currently the l3fwd-power only supports ACPI cpufreq and Pstate
> cpufreq, This patch adds CPPC cpufreq.
>
> Signed-off-by: Jie Hai <haijie1@huawei.com>
Looks good, so
Acked-by: Dongdong Liu <liudongdong3@huawei.com>
Thanks,
Dongdong
> ---
> examples/l3fwd-power/main.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
> index fd3ade330f82..5090d5598172 100644
> --- a/examples/l3fwd-power/main.c
> +++ b/examples/l3fwd-power/main.c
> @@ -2453,9 +2453,10 @@ init_power_library(void)
> /* we're not supporting the VM channel mode */
> env = rte_power_get_env();
> if (env != PM_ENV_ACPI_CPUFREQ &&
> - env != PM_ENV_PSTATE_CPUFREQ) {
> + env != PM_ENV_PSTATE_CPUFREQ &&
> + env != PM_ENV_CPPC_CPUFREQ) {
> RTE_LOG(ERR, POWER,
> - "Only ACPI and PSTATE mode are supported\n");
> + "Only ACPI, PSTATE and CPPC mode are supported\n");
> return -1;
> }
> }
> @@ -2639,12 +2640,14 @@ autodetect_mode(void)
> /*
> * Empty poll and telemetry modes have to be specifically requested to
> * be enabled, but we can auto-detect between interrupt mode with or
> - * without frequency scaling. Both ACPI and pstate can be used.
> + * without frequency scaling. Any of ACPI, pstate and CPPC can be used.
> */
> if (rte_power_check_env_supported(PM_ENV_ACPI_CPUFREQ))
> return APP_MODE_LEGACY;
> if (rte_power_check_env_supported(PM_ENV_PSTATE_CPUFREQ))
> return APP_MODE_LEGACY;
> + if (rte_power_check_env_supported(PM_ENV_CPPC_CPUFREQ))
> + return APP_MODE_LEGACY;
>
> RTE_LOG(NOTICE, L3FWD_POWER, "Frequency scaling not supported, selecting interrupt-only mode\n");
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-03-12 14:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-31 2:58 [PATCH] examples/l3fwd-power: support CPPC cpufreq Jie Hai
2023-02-22 2:13 ` Jie Hai
2023-02-22 9:46 ` Hunt, David
2023-03-06 6:35 ` Jie Hai
2023-03-12 14:39 ` Thomas Monjalon
2023-03-09 7:23 ` Dongdong Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).