Re: [PATCH 05/12] net/enetfec: fix build with GCC 12

["Sachin Saxena (OSS)" <sachin.saxena@oss.nxp.com>]

Hello David,

I understood and agree with your suggestion. We are using GCC 11.3 where 
we were not seeing this warning.
We will fix this on priority and submit the patch asap.

regards,
Sachin Saxena

On 6/10/2022 6:38 PM, David Marchand wrote:
> On Wed, May 18, 2022 at 12:17 PM David Marchand
> <david.marchand@redhat.com> wrote:
>> GCC 12 raises the following warning:
>>
>> ../drivers/net/enetfec/enet_ethdev.c: In function
>>          ‘enetfec_rx_queue_setup’:
>> ../drivers/net/enetfec/enet_ethdev.c:473:9: error: array
>>          subscript 1 is
>>      above array bounds of ‘uint32_t[1]’ {aka ‘unsigned int[1]’}
>>          [-Werror=array-bounds]
>>    473 | rte_write32(rte_cpu_to_le_32(fep->bd_addr_p_r[queue_idx]),
>>        | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>    474 |     (uint8_t *)fep->hw_baseaddr_v + ENETFEC_RD_START(queue_idx));
>>        |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> In file included from ../drivers/net/enetfec/enet_ethdev.c:9:
>> ../drivers/net/enetfec/enet_ethdev.h:113:33: note: while referencing
>>          ‘bd_addr_p_r’
>>    113 | uint32_t                bd_addr_p_r[ENETFEC_MAX_Q];
>>        |                                 ^~~~~~~~~~~
>>
>> This driver properly announces that it only supports 1 rxq.
>> Silence this warning by adding an explicit check on the queue id.
>>
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Any comment from driver maintainers?
> Thanks.
>
>