From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4EBE5A0543; Mon, 13 Jun 2022 07:23:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0D6640150; Mon, 13 Jun 2022 07:23:06 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2066.outbound.protection.outlook.com [40.107.20.66]) by mails.dpdk.org (Postfix) with ESMTP id CC123400EF; Mon, 13 Jun 2022 07:23:05 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gSkqNRWvn+ir08elj3UZDVQUosE+c/swbu+cTR8GARv5h9rMWB0TiPeHvEwv5yJaPgx/c1aM5FcpZkjqgZHUum5zm08ayd6FX0u1NJ+KdqJ8E6goTxMKA6iHJsahnlkz+a15ZP/OgoA5eNr10OSJwdKXApWzmk4+vU3Zg6cfaqXEopsXyGy8nt5RKXLoCSuYWC5/+tBTrWgJY6kGmiHBqScoCWSa+aOGlSKIdSKxcJyCrhf20Kxzh+eqJzyySCI3Rxn0mczlA6rVretTwLM6/4dAfcptAB8/Qp5VDYuK+wU1naHZ41P0v1HhELlDXLvIkdRGUjNgxaYC/xA6VSHW6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SqOM1wxzvqaM/1VlPGtTZEyQ/l1256SpsL11doRsoX8=; b=Q2B4BS5a5Opoce4TW1R9buP8QYWnn6NrnOJdBkz9zjsQ29gKT4Fkc2E8hADOgqNYEOVKbjMFeFO3rm2sVx657THpZsPB5SwTwdP/EMmP7rMMEbD6RVVyPuGv4uPVBEk6w8dImakEC3BB3lWovQBxB18rWNH9vBaILZHS4EUJjYh6dHF8OETP9S7P492F0hxEOvm/zK4lvFPCT4Z44qEpP3eqY0+8r+Xr4mf6UQVb/ytF5LmhNg3kM/KGEZT3ZOgi0myeB5mAuQ52E/GicALGe5Gx1SUW1ISvDbnwlNdLElNLa2rNvWmq4MdPgKs/0CnItijX3WkeTuDrEu2LvjfT2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SqOM1wxzvqaM/1VlPGtTZEyQ/l1256SpsL11doRsoX8=; b=QjyyzeXoljoAwbHzCisFdJpXaJ9FZdVZypQIw6N0zBVMONNHoBZ8sDsdzOg0/Q1s7cBbZn7LsdE+89b6IMaxnRQJcmoc//LEHX7cZUEXZqsxpiAe5V+cNTkJp/QYkniojY6CArURUeYTU11wF9FxrQSQ8Jim9QKc6zXx+chpm0Q= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AS8PR04MB8562.eurprd04.prod.outlook.com (2603:10a6:20b:421::9) by PA4PR04MB9567.eurprd04.prod.outlook.com (2603:10a6:102:26d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.20; Mon, 13 Jun 2022 05:23:04 +0000 Received: from AS8PR04MB8562.eurprd04.prod.outlook.com ([fe80::1027:97db:e59d:6275]) by AS8PR04MB8562.eurprd04.prod.outlook.com ([fe80::1027:97db:e59d:6275%5]) with mapi id 15.20.5332.020; Mon, 13 Jun 2022 05:23:03 +0000 Subject: Re: [PATCH 05/12] net/enetfec: fix build with GCC 12 To: David Marchand References: <20220518101657.1230416-1-david.marchand@redhat.com> <20220518101657.1230416-6-david.marchand@redhat.com> From: "Sachin Saxena (OSS)" Cc: thomas@monjalon.net, Ferruh Yigit , dev , stable@dpdk.org Message-ID: <894b52f3-9888-4184-adeb-156c641e747e@oss.nxp.com> Date: Mon, 13 Jun 2022 10:52:33 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-ClientProxiedBy: SG2PR01CA0142.apcprd01.prod.exchangelabs.com (2603:1096:4:8f::22) To AS8PR04MB8562.eurprd04.prod.outlook.com (2603:10a6:20b:421::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 528f0ebf-f60f-4904-7453-08da4cfcca49 X-MS-TrafficTypeDiagnostic: PA4PR04MB9567:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: exA6XuW5UPo7Up65nsFA83poPqsCc9PwvA2hwkyamqMRYCFRSbLu/X+B1FAEo0qQitpPfLjB2ajTwjfxDx4VNCXEdaq+BEjlB/07hJvAd5Me2GybvFFNUfYaSx7ROSUTCtMmRPk6u8CFv0LU9fqh6eRL/xVwZnWKFlWU19hahBWIwiLprWR+jxuY3B/bC43dtgxQiisPw+QFfF3ULt/g3ohrMOYrCfj17QApf/biElnuLIUGPT8jpXxLIVjMMu/L6yYyCEhgBs2ged27bdkBH9WtSfnE5w/HmKXd1qcO03Q1wgCq3Nt+ZTE5ooJQffF/oare9MjWxBk6oILQYUbyADvKSVCaAd9Ranz6jakQ8SCfpGbSknkHNNys06AOiXpTR3/d4Yt4Gp0liUDoY50BicL+gq50KeMJEOx4KZhAadUA3fyRoeLSNFDBrtx/Dy/oZ90gMgV/jSloTFZxjtoOyFUWbM6HTrmxL2qvH0PXXXUyWEe1riR04OFl6GbHe1LhyadXmbqG23Hx0+0WQJ+u7s/5IAsf1yCaAuAnQ5TkCbC2WwOkNZ9zKneM664W/DFE6xKcqth8bSqFFpB5AY0MaynSYXT31XLoU26gaIDFM2xSoTDy18RxEN6ejAIhmp+sgwemWKOv4KQ8oOMxMwjbxdllvim5GJDtqtOfkvsGYpEv7S8kxwdtSUTHfXQ7QkUWRGsMrfN2lUqg4FLJyrgAz3ps1tkIG2mjaemR8waKJgjdWEiskhTwKYT0ufRHe7XlmYnXicNsO+VTo1BjwdqvYw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8562.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(66476007)(8676002)(186003)(66946007)(66556008)(4326008)(54906003)(6916009)(6506007)(55236004)(31686004)(6512007)(26005)(6666004)(83380400001)(53546011)(2616005)(52116002)(38350700002)(31696002)(38100700002)(86362001)(6486002)(2906002)(316002)(8936002)(508600001)(5660300002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SG8rdjFNbUhkY3RnUytaemZCVUY5VTBES0R5aitMbVcvcDJsZHlvQ21LSjB5?= =?utf-8?B?OWdodFlneXFraUV1M3EwTEErUWlEc0M5K3RNc1hVazg3WWFqcmQ5QVp0S1oy?= =?utf-8?B?M2NCczZQSUNDQnBtRzlENC9QcFZHMWg0VHBmNG5IWTBlb3VTS2ZmQ0dTeitr?= =?utf-8?B?UUhyRTMvTTB2dlEyY0dEZkF0QzRYd0pqRThEWXl6ZDk0Z294UE0rVWlZV0lm?= =?utf-8?B?V3llcW80MzFZNzRzUXlkek40Z1lOandMczVHeTNnUjFoaHR4d2ZjNFZKVkkx?= =?utf-8?B?dTZnK3dWNGJLR0NDc0J1eEZ0Zmxtdyt4WDZBMDlpRDk4YjNUM3lyQ0o2eDFl?= =?utf-8?B?c29lay9xcTM2TVIwTzFsQzZiOGw2dTN3em1ydFlFamZyMEpaU3Jpd1NzQXQ2?= =?utf-8?B?VGFWSmRMaW9jd2tzbG0yTGJqazN0YTFUUlYrWkE0QjhUYVRteDluSmwvZHVR?= =?utf-8?B?OE1XQytMT1UrOXdEaGJDL1F6OTVETkF5Qyt4ODZTb1RKR2tQT1RCT3VTQTBk?= =?utf-8?B?dUFBRHhnUlpLNFV5U2xyYWRoQ0RodERSVFA5elBoakdlbU5TL2M0b3R6ZWo5?= =?utf-8?B?M3Vyd3QzVUI4QkNab2h3amE4WGVVdEhDTjZGVEJhNDlnOFYvYWlzWnZOUE4v?= =?utf-8?B?RWRSb2VvT1FqL3dFblVIdVhSNlRYL3dYbnlEMVBFaFNsaXV5amdhWlR4Mldk?= =?utf-8?B?YTlUbk1WQjMydEN5aUt5TlEwL25ubW5DdWh6Z28vTzI0UG4zcVpXUEtqanJS?= =?utf-8?B?bkI1cnNlVitaRElYWWJBcDFmRGluRXo4VUhUbWswNGtidlpRK0E3VzdMV1No?= =?utf-8?B?eTBCbENvd281QldqZVM3ZXQ2YkpmbzdKalJycGh0Zy9WY3lhaHVjRitCdkpp?= =?utf-8?B?dW9xTXlCeHJHTnRYbWtqWWFQK2s4SndpVlRFTGhkZytjdE9iZkMrSE5RdDNL?= =?utf-8?B?UGZidVk2NW80N29nbkdYMkFtSjIvdU1DWWhzQ2h3bW94UElFQXhwTWx1aWpC?= =?utf-8?B?Unl6dVlzNXZCUGtnd2I5L2xVMUVCYzZYdUNIZDdHUlRqUDNmeWQ1SElPVExI?= =?utf-8?B?dFErQVo5R1JmcUh1ODcydnVWZ3d3b1YvWVhpYUswdGNZUUdDaFlBU0k5d1dN?= =?utf-8?B?bW05aFNUS3JyMEJIQVdzRWlMUHUzN005cUtMME10RlpQM0c0bmRYRlBoQitE?= =?utf-8?B?YzVURnEwa2xkelU0Rm1mcG5SZ08wRllULy81L1N3NUVRdWpIQ3FkbVBydzZI?= =?utf-8?B?OGxBVFN3eHZpbW8wODVmQVNMSUVXbXEvNGkvbGNxUGFydDF0YVhSWG1LRWFV?= =?utf-8?B?UEdHd1NNdk8rQ0RxWmVrOHFWVU9JdGJTS0dlYlAyTk1HZXpKOExYVnNLTHNj?= =?utf-8?B?MFYraTRvdHlRVVJIVGNVZDIrMTBMS1hxUTJNVS9aV2VleVVBODZ5VnhCZjB3?= =?utf-8?B?dy9tN0V0SnNMdXh4ZEw2TGkveDIyUkwyR0UrckhhL3VmUTYyWHBmVXdscHUy?= =?utf-8?B?ZG1keFh2ZHp1RmdMdEdMOXUyVE5CUXdvbkNMZWtKR3ZSdmpLQno3dXdPRjYr?= =?utf-8?B?U2JWNkNaaVRobFNKQXRVOW9QaERPa0NoVGtrbEwzWkp1U1EwUTJMa0VUMXhM?= =?utf-8?B?eERFNTIvM2V0MnlTcVdIRmFsY0hUMWRveTZpQnppTU96YW1xZnFPTzZnUnhZ?= =?utf-8?B?UFQwWmsvbHFhTGdkemhiejFXNjFQbEk5djh3K0tWUCtnZDI4R3M1aG9McWJ6?= =?utf-8?B?cjF5OFlvUGRMMWFWVktBNTdMeElxc09ZQmh4ZlN3T1Zza0o4RVBodS9lVk0x?= =?utf-8?B?bkhOaDFheldvMXM5RG90NE8zK1hucXdzOWovc3lBeDJwUTRrQUFxdFZuVUsw?= =?utf-8?B?MmRuZjJoTXlRbDI0dlRiVncvdXZ2NXRJUXNXMkJaRFlqZmVXeEZ3RS9jUG94?= =?utf-8?B?VE1TanlCZUNLbHlVWk00L3NFWHJJZ1RMK0NBR25ocXNJZVIvOWxocVVIWVFu?= =?utf-8?B?N0ZIQTZ5elcwYmdUYW9YbGZJMnhCZEh5cnpDZVVSRWM5Y3R6TVowUnZ6WEZk?= =?utf-8?B?RGFIS0ZmQnR5czVMK1hnc0xtN090ZlRxQVo3SnIyZEFmUWFtNStaWGwrUndR?= =?utf-8?B?akVCVk9mY2t1Wmszd1FNRTN2L0YwMmN0OHQvakt3YmE4UGRBWlFGNGJNMTlM?= =?utf-8?B?aDVaRGRWQVliRGZLK2pubnR5VU1sWk9ZWDFHZGdHaGVjWWgxWURPQlg1dW5k?= =?utf-8?B?RkNKRDhIVkYzWTRhdUNQVkRxR0l3SXJsNmhoM0xaaDFJUEJnODBFNVFyc3hQ?= =?utf-8?B?a0VpenVFeVV5RS9nQW9aTUdvVFN2YXg5N1R1cFNnRmFPZkdpdklmRC96R0Ny?= =?utf-8?Q?y8IBtybXgjPscgk0=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 528f0ebf-f60f-4904-7453-08da4cfcca49 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8562.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2022 05:23:03.8127 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 02WldSy2W1qLgfcNKy2/w9eYlNOboOqTaBOJBf91Eil8GT4eyh5NJ6eAOF4c4l2FZ9NtJrpANfs47ZCYImoqhA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9567 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello David, I understood and agree with your suggestion. We are using GCC 11.3 where we were not seeing this warning. We will fix this on priority and submit the patch asap. regards, Sachin Saxena On 6/10/2022 6:38 PM, David Marchand wrote: > On Wed, May 18, 2022 at 12:17 PM David Marchand > wrote: >> GCC 12 raises the following warning: >> >> ../drivers/net/enetfec/enet_ethdev.c: In function >> ‘enetfec_rx_queue_setup’: >> ../drivers/net/enetfec/enet_ethdev.c:473:9: error: array >> subscript 1 is >> above array bounds of ‘uint32_t[1]’ {aka ‘unsigned int[1]’} >> [-Werror=array-bounds] >> 473 | rte_write32(rte_cpu_to_le_32(fep->bd_addr_p_r[queue_idx]), >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> 474 | (uint8_t *)fep->hw_baseaddr_v + ENETFEC_RD_START(queue_idx)); >> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> In file included from ../drivers/net/enetfec/enet_ethdev.c:9: >> ../drivers/net/enetfec/enet_ethdev.h:113:33: note: while referencing >> ‘bd_addr_p_r’ >> 113 | uint32_t bd_addr_p_r[ENETFEC_MAX_Q]; >> | ^~~~~~~~~~~ >> >> This driver properly announces that it only supports 1 rxq. >> Silence this warning by adding an explicit check on the queue id. >> >> Cc: stable@dpdk.org >> >> Signed-off-by: David Marchand > Any comment from driver maintainers? > Thanks. > >