From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 02DF1A052A;
Tue, 26 Jan 2021 12:55:46 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 819C7141469;
Tue, 26 Jan 2021 12:55:46 +0100 (CET)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 0A0FF141464
for <dev@dpdk.org>; Tue, 26 Jan 2021 12:55:44 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
by mailout.nyi.internal (Postfix) with ESMTP id 645FD5C00EA;
Tue, 26 Jan 2021 06:55:44 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
by compute2.internal (MEProxy); Tue, 26 Jan 2021 06:55:44 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm3; bh=
orWmOh2sLGntQCJE2ESLUb2FlW2yFX3u5BSEL54Vnb4=; b=o+eO1ru++jvIC5XL
SN7ULBoJeYQ/cCsVmsDCJ2fkccifrqUTVIM9vmx/JRbfFFf3KqLI3LAdDBnNB9oR
CbYsOeLmadoX4eh1tcYYHX5jU+c0Zi17/5qm4BW2Pa+IKVr8HT4Lw9+YaY+PRF0o
0I0aGpjUYIMSJGkPYHNWMqgrfoo3CAMKZahHSJgvyVIXiXFcJqYcWcTHh2tvoAE+
dAV78EXfr4RDHBMoEyQW9kkCLrnJ7WBhUPflJfhNuep+0Uk4ewCT0Y+wsKe8IlOx
d/2sGV9lP7/VUfLu0qL2YWbAA2baxJ6XwMp+OVTGb9u7OkQHtSh5vkdO6qBe6Xad
RlmK6w==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; bh=orWmOh2sLGntQCJE2ESLUb2FlW2yFX3u5BSEL54Vn
b4=; b=gohgrYiAFoOVDL2R6/NV4lLVuHkFJtYA2MDzxUmDzgbGPSumaQam1SJ93
enhQbfBygLZ6Ly+uT3tjOBaJsQMvnNAC6AasaEeDkb0kjPegeQYp13QYrf83bCyO
Nd7PkFL7msTyoxkN7TLINMEoPrxJa8dRndOL54AC2ZOpNJPztDjNJkIyUf/C/tPE
cDX3KKPusPWMhwoQ3Gk7g05mvDfMmHPRposvlp61M5JuedU4UjmAzphF8Ehgeaj0
DxlFqsRULc0t/TvknuMSyvKwH73hccsEc7RHRcnNbYrysUz4uA2O/3T6fBTH5bd/
KywNhmIsUOt+GE01SyOseZm30C3kg==
X-ME-Sender: <xms:PwMQYPKthqr-iJQrFOhjufVmV_bjZcF8j14HBj66Jw9Lh8NKaCTtoQ>
<xme:PwMQYDKYrRoHt31LX06c-uho4lWBKo-GLHfuhrg14COfWxFqdxTYCmkvEeIz1Q-b-
3uAwiEKtwIjgklpsg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdehgdefgecutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf
frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei
iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih
iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho
nhdrnhgvth
X-ME-Proxy: <xmx:PwMQYHsRH_TlEhwACAem9pl0MWll6UMF9PB7-c0FfJopokE2PtJmfA>
<xmx:PwMQYIZfNuduX1EWW5_u8Vfu9ms89NsXBN51d2cUQ0VVukRSOJumQA>
<xmx:PwMQYGbUxMskRsZRy9qylMc_a1Ge14WxGFnSPRGtafJVHU_tnToh2g>
<xmx:QAMQYNW3EItTiaKF90qj195rIpd4xH1KCbXRc6eAp6U3MN0BlNf6Iw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id ED73F240064;
Tue, 26 Jan 2021 06:55:42 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ray Kinsella <mdr@ashroe.eu>
Cc: Neil Horman <nhorman@tuxdriver.com>, Akhil Goyal <akhil.goyal@nxp.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Abhinandan Gujjar <abhinandan.gujjar@intel.com>, dev@dpdk.org,
david.marchand@redhat.com
Date: Tue, 26 Jan 2021 12:55:40 +0100
Message-ID: <89537896.31c7qgZWaZ@thomas>
In-Reply-To: <20210120142558.4120552-1-mdr@ashroe.eu>
References: <20210120142558.4120552-1-mdr@ashroe.eu>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v1] devtools: update abi ignore for cryptodev
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
20/01/2021 15:25, Ray Kinsella:
> Update the ignore entry for crytodev to use named fields instead of
> bit positions.
>
> Fixes: 1c3ffb9559
>
> Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
> ---
> --- a/devtools/libabigail.abignore
> +++ b/devtools/libabigail.abignore
> @@ -15,4 +15,4 @@
> ; Ignore fields inserted in cacheline boundary of rte_cryptodev
> [suppress_type]
> name = rte_cryptodev
> - has_data_member_inserted_between = {0, 1023}
> + has_data_member_inserted_between = {offset_after(attached), end}
Adding a bit more explanations in the commit message:
It is allowing changes between the last field (attached) in ABI 21.0,
and the end of the padded struct in ABI 21.
Fixes: 1c3ffb95595e ("cryptodev: add enqueue and dequeue callbacks")
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Applied, thanks.