From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0086.outbound.protection.outlook.com [104.47.1.86]) by dpdk.org (Postfix) with ESMTP id 4E84C1BA5B for ; Fri, 22 Jun 2018 12:04:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=61/MgZS8uTBxRF0x4+wtK+JmbMhBTiAsQ36ATrUZHjY=; b=SeEeB1ys5nelBMbnIamMpEDM/k+2/9+edcqN9CExZitAOQY3zm569AKcEHwc64hFWgT8mq3Vx4LA6exyjDgijQsLuM+CJq06SNhj43htr2iyPHJXDSg4NuR67HnbxyYGbZ/DW5gjrvvI6eA0BBcSk+V9ysFdspKgioQYQE+6wtY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; Received: from [10.232.134.144] (14.142.187.166) by AM3PR04MB1379.eurprd04.prod.outlook.com (2a01:111:e400:536a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.21; Fri, 22 Jun 2018 10:03:59 +0000 To: "Joseph, Anoob" , Declan Doherty , Pablo de Lara Cc: Ankur Dwivedi , Jerin Jacob , Narayana Prasad , dev@dpdk.org References: <1529389574-6643-1-git-send-email-anoob.joseph@caviumnetworks.com> <1529389574-6643-2-git-send-email-anoob.joseph@caviumnetworks.com> <7fa289f6-49a7-e3fe-39d6-e37aba7aa0e9@nxp.com> <407729fb-469d-e731-329e-868573392a39@caviumnetworks.com> From: Akhil Goyal Message-ID: <8953ce7f-587a-a982-a6e4-3297e7553932@nxp.com> Date: Fri, 22 Jun 2018 15:33:45 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <407729fb-469d-e731-329e-868573392a39@caviumnetworks.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: BMXPR01CA0031.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::17) To AM3PR04MB1379.eurprd04.prod.outlook.com (2a01:111:e400:536a::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1a7a8068-22c4-44c4-00ac-08d5d8277a49 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:AM3PR04MB1379; X-Microsoft-Exchange-Diagnostics: 1; AM3PR04MB1379; 3:skwR5a+5fH+Vp0GolxkKFVhXLDXiEtqE+rYN/PMXjc8uJdb1x57Z5PIVSqv5J5T5p600/HUKpyyg+cjNiixi5bVAzsQ3eWlCKBUsiq0W60EkZQ4CGwm1HHlCLkaLdTxSU8fepmwQxdcTshkqK7vmymbf8dRWt1yeFmHECmxTbz4zyXMcI8j8ZaGf6AgooXG7ZbwJmHQRHqvUF0LFcIdfpvvKxEg8jj6/+YGXE2yWRHo6EK0CzLIkrBZIiv2WtuRI; 25:22wUbPLL04l5Hnl4itDuwI801k/9ygb4DELVXYAi2LULq9bbYqApTGM8yTYG98yiEJjzt/afzc0f6RIIsb240pVXPSZmsYh4x9xMXhrCOTrmPrS5ODCUwK+Jrgp/xO9VhfhT2q9R26A830udk94r4UZu51gkX4iK9utNpeHj1oXOIJosXwXWx2Op3yPVh4EdjI/Q+wfM575CKm629zbIemOcTe5OS6IzMBpyHuLjTXfPQzOkiuUaJUWK4k3tVTPIe84zCPa5RrsRVVqIJlcGIyl9LxrO6FWQSqsPD/dDhM6+KfZ2T5Lvgad0TJyUvgYh50j9orYJAyeC727XqxbjRPeLZYdYm5OuRc+UKqgzLBY=; 31:t1bsb84+C8SR5LHSpifbUr5gnrGq07pBvf7ax832qT+++uN85qotZQPqqeFqh/kz+PBYwGx4jZ7JlT+nF4Jy57Wqzu0+pckM67m9PQbd5jYmek/rDxEzi7uppAtDFtHJsIQvekdOtaBEfqEXh0P7h3koV/Z/Oe+Zdu8WtO+mIYS6PyMF/1Gz7cNCq5u/IMaoUZfrmSlfToM/hhDjORwkiU/z/XGgyqlxFm8Lgc3Awn0= X-MS-TrafficTypeDiagnostic: AM3PR04MB1379: X-Microsoft-Exchange-Diagnostics: 1; AM3PR04MB1379; 20:8u/uQ3xlad3JUVQU7SC8BrG6zdUkRRjCI4Dy4b0ThjU9LhSlFIPH/c52F7iJDaZ2oYllkDSlJfZ5LuXlvnENAavdNExLoOmRrgJEo7/v+AKpv2dOCiC93oBTeo6bDpyNSrcKUKCrVZE6sBViaURcqNejHVnEpcs3S+ucL/ujlyM1fZomo2rK0bB4XLJDwenDxFATx2iyfWP84oMrufZQ0oTqvAaRQTUC4ErVlZyS9sXhiRv24918eAVaslwi2WV6flinet9HxJm8fA1arSpLQPtarwSoU/WI1MuNCHxbTSK7K0DnWNjIDrOoDPeJwg3ULScQJ7bEQo64mkKrvshphZ2rpi/zcdGckal8y43sasaJVWNmu3tJt4bTbSDtzB7HtZiBHoKGsnrJTMGVvPFw9Fx0WLns6kEgOuR7zbswl+ZEYYEQDHnXPkTqcC1+PMftlsff1QpfI/Cy/O8ghL9dKYuex3BYDMYyTcUgvJxPULLlEiW+xKoPn+SGdnJRoHvu; 4:zOYG2QsRTwhe2DpBwogdlisRIhe8/jWvnzo8lXmtDzq9UU14mKpQIIq3Vb0OKNicW5eBsxQBy70TX8c0IcvRAjYcAq+qCsdyZ9o0LQWXIFxHmLmpEXQXqk8DvbRcqXK3YHUmO3Lvz6lGan+awrVcNXtC5QwIg0iTOYWIk3E0gmMDdJIauOyH9Aq2wnZu65xm5ZG93qqJSVtwWOXdo7CSeY4kBcRqetbumDMiUD8KUOr74eYanpKmyj45BIWDVET/nLQsBeMwX6wMUBQsUKfywcah9gPyeb3GJCFZ/0ztnTj0NktLPOzJjzQjpXnGl0qi X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231254)(944501410)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:AM3PR04MB1379; BCL:0; PCL:0; RULEID:; SRVR:AM3PR04MB1379; X-Forefront-PRVS: 071156160B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(366004)(346002)(39380400002)(396003)(39860400002)(376002)(199004)(189003)(52164004)(305945005)(93886005)(316002)(106356001)(81156014)(105586002)(6486002)(6116002)(6246003)(229853002)(8676002)(50466002)(25786009)(53936002)(3260700006)(16576012)(2906002)(54906003)(58126008)(110136005)(3846002)(4326008)(31686004)(81166006)(36756003)(64126003)(7736002)(478600001)(67846002)(2870700001)(11346002)(68736007)(956004)(486006)(476003)(26005)(97736004)(446003)(77096007)(186003)(65806001)(66066001)(65956001)(16526019)(44832011)(2616005)(65826007)(23676004)(47776003)(5660300001)(5009440100003)(59450400001)(386003)(55236004)(53546011)(86362001)(8936002)(31696002)(52116002)(52146003)(2486003)(76176011)(6666003)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR04MB1379; H:[10.232.134.144]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTNQUjA0TUIxMzc5OzIzOjB5NnoyUy9ZMjhSNk43REF4aXN1TVRWUURs?= =?utf-8?B?YmgvZGhRR3BkWDlObGZ0ekhNNU1Md0NodkVDNEsxUzNuSWFsSWxDTmFPWW1C?= =?utf-8?B?MFlQVTVPK04zUXd1M2JwNWhiUERkcklJelNXOWRtd1hTTnZ4VTAyWWxNRVlV?= =?utf-8?B?RStvUW9uTmhPRGJ3Vyt5RFNLZ2xTbmZPd1p0TkpqSTE0UnRYVUVkVUwzbEZS?= =?utf-8?B?UDkzUlFWdzdyaHNBUndNMGkwblE5eDQrT3l6Nk9TWEhmc3hHL29rRUhYb051?= =?utf-8?B?Z0p4WnlwaUQzb2d2UFQzdHduWHpDNS9BZGczb3RBUmpRRTd1MzlyeFpuY1lD?= =?utf-8?B?cDVOSW51Nkt4Mk9tTC9lUWV3K2h5WW1keXVvMEZ2VzlSUFIydk1Zb1c1M2pD?= =?utf-8?B?cGlROHIzQXpNWDE3VHAxczJPTzV1bVRoM3NQeUFrUkVueFlNWnBycEJsRU9n?= =?utf-8?B?ZXR3N2JzNitSeENuOEs0T2pNSXRkR0lidVdEQlNzb2lPV1R4MlhNMDFOMGhx?= =?utf-8?B?MGNqZTZLd1Avc212UnJYYzBXdVhmQUFIb0ErRUpUWkdvVkpFUFkrT0s3ZUtP?= =?utf-8?B?ZmxRVU8vdUpYQ0dPTHN1TEhldmJ4d3dYNHlWelFsbk9MdVhSQmxKcUlqVUlX?= =?utf-8?B?VE9VN1dmc0Z6dVdhbHpoNkJSc1NxYWQrVXJ1UGhMMjFjelo4SldUaTNBV2p3?= =?utf-8?B?TFU3Mi9kQU9EOXc1ZmlDOFJDaS9xSHJHdHFEQmNSK005Rm9RZGpJemxueUdN?= =?utf-8?B?M09xcUR2UDQxcmovWlJXL0tqL2xxc085UDEvUXg2b2puL1RadUV1djJNNFBv?= =?utf-8?B?V2c4UXRVSVZGc3pqZE9leWEya3U4UVlmOFdkVDFkcWNZNHROUkNaRlprLytw?= =?utf-8?B?TURlWFNhdmlPOEdVZ0p4cUswWE82QVo0OU1WZDdGdjFxZSs2bnJJdmo4L1p0?= =?utf-8?B?QzdPdUdMaGtVSDFKT0JtOHdERnFHOGRmSmtnOWhLam1OYSs1anhZOFAvUEdE?= =?utf-8?B?QzZTQmo1MHIrbEd5ZUwzNDJMZmpuM3p4QmU5ZnE1SDBZUUhLMmUybmlhUU9n?= =?utf-8?B?ZlRSK0d6S2dEZ0NSeUpFamtNZEtWM3JoTVorNDFNWTRWb1RlQmova3l3T3Z6?= =?utf-8?B?RlFXNzJrVkwweXRZVk9tNFIyV2RzU1BVY2kvbFNkNGlEZlpnbHMrN2J2YmRq?= =?utf-8?B?bTQxL2FmbHZibXE3cFBYak5SZWlDOWUyMzI5TjBKYVFpWjVRdGYwb0dPVlpS?= =?utf-8?B?bHN4ekN4ZlR5M0oxNUpaeDlMV1BmR3hWejNTWjdZRmpiOHBuUG5yNXdKUzJF?= =?utf-8?B?Y09kNDkrUUJSUTdjRTluN252b1JvWU1zZTFjRzZ2T0dUdVFBWE9rbGdkNVVI?= =?utf-8?B?cmJ5eUV3VVQ4RnIyQ0xVRFRUV0NKaGloTnFzUnhSSzBYTkpyM0phYjFQdmxZ?= =?utf-8?B?cVJiUUdoTUV6M1M0MTBQdldPYVFHZ2JVL3c0YktZZVlETnl6a25sQ3VkRVpj?= =?utf-8?B?cTJiVWNSMGNmajE3MGV0dEN1V1BOb25pbm5ZY2pUYXRERmV6MlplQ3Z2T0kw?= =?utf-8?B?ZlFLQlN0NWJjNGpOTzNCdGNSaHdjZUYzMjA0K05SRCsvUk5INVp5S3hTTk1H?= =?utf-8?B?bnFGbWJPaldDVUw2NGwrVCtNQ0VkejNuWFQvY1JTNjJkUmZnS01yN3dDRUky?= =?utf-8?B?alRRUHdJalRwemQzK1h2V2FNbDJuT1VBaEpGWGg3YWVSR1hYaUcvMGpJUVZH?= =?utf-8?B?TlJ1L1NMSFlBckk5Q0tlSnV6aHUxN1JSRC9nM1czZ1VhRGRKWllHb1NjMWgr?= =?utf-8?B?enN1QmRVYlJ0NlA1R25jR01KZ0FWWStqSnJlSEJPRkMyVFhVNEFrZWp6cERR?= =?utf-8?B?am1yTXdIdTJTZW5TdzNuNkNDM3lCY0xobGU0R1NLVm9iZUhyQVkwUHpCaWVr?= =?utf-8?B?TkxrWU1iLzRWYTZyeXh4dXFza2FsOUpTdUlTTlpZTUpJK2NPams5emQvNHBJ?= =?utf-8?B?OGZwdjhvb29VVkh0NlZYdjZJcW1FNDVFajRPVzZtN01Md0I0N3NyZXVIeld6?= =?utf-8?B?ajg1UDZXQ2QyUEpGWGU2blg3YWluQVRrMGI3bFUzbktZRHhONEJIVDE2TFVy?= =?utf-8?B?NjZJcDBiRXpzU0NRZ0ZWb3FNU0VxNXkzMjQ2RVlFS0NrcGprZzNIQjhGQXJu?= =?utf-8?B?UE45S1RQZ3NkcTZmeVBjOVVBMFFrWnBZTG12N2R2cGJEYzZhdmpaSTlNYVBW?= =?utf-8?Q?BPMDSq7seSeCAWGlN3?= X-Microsoft-Antispam-Message-Info: 1WT+tdO9ITGEiVcr7FFRERE7vWh/Vk9IC7MNlqS9vJz+NtpMaH65gXYQkF4MKD/WQSXDQR0x1GTqUaJyalm5byQDqNDNClNi4Q3q27ulz5fMvbzJC8a+Ql5v2uoBl6fsV4N+70zO5ltbzTbHRp/DH6b1lOQCpRNJBG5ux1CC4bLNAPK7uimZ6PlO7Zh0RkoLwItSucxNqhCkRWp7UQ/6Ux1F4dn0gvbFZWoU2BAjClmnQNI4XrzIS9gq1hNU3sXT70Z/fGhx0p20j6PefigMyQ0f5p3IAUKntauUfYTuAXrtuq0NvZRUa2efPpI2pbUiKPEq2P/s0v2iA466Xih5hA== X-Microsoft-Exchange-Diagnostics: 1; AM3PR04MB1379; 6:4QDQ5bPDHLFSHYLuGMKEaPVgptoNzAVuDGdV1k5w4NwEM50fV60mfaSNXCO+HYsdPv19AXSu8XA8e2IVzWJrwWl2l6wrYiJwpWf9M68AUtD1E79cPBKe6zdYoPYUvV9JnfkfKuZobwZala1HKudYED91c15e3muF90vwmY5ETfle9Wi31E8xXgBTqyFRw8Sv3QZb6nDdFz2gs9TZHNMfCFEvbWPcfEB8p2jm9QTcrUCwDZ4sGB6DQt65Rxf7CMa62+X4iUq2p3cCQYvP/vW0MJIZqNJNOFmOjlagpEFgQ5sExzwmunpPydEKooAp1l8ZfGBfOu2uI3h8OKVE4/2vxXuzUwi2dhE8zgk2HgfS73cZ68MXiJ7VAU3dhy7J2z64YuJLaa6gzGvvZqprb6t0HyuBotGHwQHElwSCeHDSkS2yRBiHiWQplny4W9M8IOZNQod/XMh1ndno8zKRRbwrkg==; 5:4H8a6N5yMpHE+kWROTuTWU2hGKjCYMeK+r1Uvwywzl1SLhosqunTJ577smmmiP9oLVE+27sCI6WgSWhXaWfjVdJPqpfSIOV8YOuM88BQfjqIwlUrGrYHwhZ607WH2ec9p+iWRdo1QpezmDaYC/N0GfiiRq+k65DUXL1q8WEuTDM=; 24:0XhcKdE+NILTy66Ps3+gOgC8lD2IMi9srt6ewhcW++LAykyKZa0Zoz+EDRRVOFT4LIoJRnfFkiVxIw9rFJKTvDgCTyDsBkpXt3whuA/+tWM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM3PR04MB1379; 7:kPNaDQTD3Wfjlc3bH4a70Li0Q61zHdbcK9WX5Li/ALSPwVIqyNnfBL0Hr65ZQqwV0u62iXxPwFdDUQ3LPlLWiyi6CLa/NT9RVcXy7Kn0KjKZRmlMp7ZEJDB/pJKZ0AhTqYvMubi9H3+zoogGSU263VaaP56WPFrUDvG1ncKRt4JKokdxOLHf/EOcLTE4oOQanSWwSwG+cDpDMn5Bj2SSyQjKhQ8jCvh2rD2b2wnl82yWlnW4dGDPrqyjdImWqZZw X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2018 10:03:59.6283 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1a7a8068-22c4-44c4-00ac-08d5d8277a49 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR04MB1379 Subject: Re: [dpdk-dev] [PATCH 1/2] cryptodev: add min headroom and tailroom requirement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jun 2018 10:04:03 -0000 Hi Anoob, On 6/22/2018 12:22 PM, Joseph, Anoob wrote: > Hi Akhil, > > The change adds couple of entries in cryptodev_info structure. I was > under the impression this will be an ABI change and would need one > release cycle. If we can get this through in 18.08, it would be great. > Do you want me to revise the patch stating it that way? If you are adding a deprecation notice for next release, then you cannot add code in that release. To add this in current release, I think Pablo can take a decision on this. > > Thanks, > Anoob > On 21-06-2018 19:54, Akhil Goyal wrote: >> >> On 6/19/2018 11:56 AM, Anoob Joseph wrote: >>> Enabling crypto devs to specify the minimum headroom and tailroom it >>> expects in the mbuf. For net PMDs, standard headroom has to be honoured >>> by applications, which is not strictly followed for crypto devs. This >>> prevents crypto devs from using free space in mbuf (available as >>> head/tailroom) for internal requirements in crypto operations. Addition >>> of head/tailroom requirement will help PMDs to communicate such >>> requirements to the application. >>> >>> The availability and use of head/tailroom is an optimization if the >>> hardware supports use of head/tailroom for crypto-op info. For devices >>> that do not support using the head/tailroom, they can continue to >>> operate >>> without any performance-drop. >>> >>> Signed-off-by: Anoob Joseph >>> --- >>>   doc/guides/rel_notes/deprecation.rst | 4 ++++ >>>   lib/librte_cryptodev/rte_cryptodev.h | 6 ++++++ >>>   2 files changed, 10 insertions(+) >>> >>> diff --git a/doc/guides/rel_notes/deprecation.rst >>> b/doc/guides/rel_notes/deprecation.rst >>> index 1ce692e..a547289 100644 >>> --- a/doc/guides/rel_notes/deprecation.rst >>> +++ b/doc/guides/rel_notes/deprecation.rst >>> @@ -122,3 +122,7 @@ Deprecation Notices >>>     - Function ``rte_cryptodev_get_private_session_size()`` will be >>> deprecated >>>       in 18.05, and it gets replaced with >>> ``rte_cryptodev_sym_get_private_session_size()``. >>>       It will be removed in 18.08. >>> +  - New field, ``min_headroom_req``, added in >>> ``rte_cryptodev_info`` structure. It will be >>> +    added in 18.11. >>> +  - New field, ``min_tailroom_req``, added in >>> ``rte_cryptodev_info`` structure. It will be >>> +    added in 18.11. >> >> Is this targeted for 18.08 or 18.11? >> >>> diff --git a/lib/librte_cryptodev/rte_cryptodev.h >>> b/lib/librte_cryptodev/rte_cryptodev.h >>> index 92ce6d4..fa944b8 100644 >>> --- a/lib/librte_cryptodev/rte_cryptodev.h >>> +++ b/lib/librte_cryptodev/rte_cryptodev.h >>> @@ -382,6 +382,12 @@ struct rte_cryptodev_info { >>>       unsigned max_nb_queue_pairs; >>>       /**< Maximum number of queues pairs supported by device. */ >>> >>> +     uint32_t min_headroom_req; >>> +     /**< Minimum mbuf headroom required by device */ >>> + >>> +     uint32_t min_tailroom_req; >>> +     /**< Minimum mbuf tailroom required by device */ >>> + >>>       struct { >>>               unsigned max_nb_sessions; >>>               /**< Maximum number of sessions supported by device. */ >> >