From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id 7703CB519 for ; Fri, 20 Feb 2015 10:52:42 +0100 (CET) Received: by mail-wi0-f179.google.com with SMTP id hi2so1707205wib.0 for ; Fri, 20 Feb 2015 01:52:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=4Sh4w5UtHS1/MWqO3xcqXBBdI2Rlvkvsn5dnHKcapAg=; b=OuP8YVf6CTFwkquDmbYmO0/9DCwD3uXsYMIkCdivACkux4UTlXsgwsoVpj8IE40PaM PhRBse6Q/fp3aAQBGFwLP0s0NGHqQSvxBEDTNXuWW3OJEjQx1tKr+u+XSz/kDwLNFwBj FQJqoI/v2hdDlG6ctQKMBpNXhZxFk0MMgyE03EZgpb6seKKJQ1RPdkEB9spKfmyJMm/h vxJaqCLJE+qQEhYaRnmW+JlVn8X9ffs4rut3Go+iJS7Xya9Ybf4Wx9QzHvsipMT31Sm9 ssSIA1tL28S+AeN5rd93SE0qUjTJ56fX2g3xPq0w35p/xO+yCO8El6eGl9mXBi+s23Lg p6OQ== X-Gm-Message-State: ALoCoQleZDSSdylc/3kzP/fdsjhcEYrizE7iWXW7P9fe6MazWjNDn1I1UcBhOaI/1MM3xWHO7zE7 X-Received: by 10.180.19.9 with SMTP id a9mr17940014wie.85.1424425962301; Fri, 20 Feb 2015 01:52:42 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id l4sm1604121wiw.9.2015.02.20.01.52.40 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Feb 2015 01:52:41 -0800 (PST) From: Thomas Monjalon To: Olivier Matz Date: Fri, 20 Feb 2015 10:52:11 +0100 Message-ID: <8959296.RnBG6Of9nb@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1423043365-28462-1-git-send-email-olivier.matz@6wind.com> References: <1423043365-28462-1-git-send-email-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] cmdline: fix ressize in parse_portlist X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 09:52:42 -0000 2015-02-04 10:49, Olivier Matz: > The argument ressize contains the size of the result buffer which > should be large enough to store the parsed result of a token. In > this case, it should be larger or equal to sizeof(cmdline_portlist_t) > (4 bytes), not PORTLIST_TOKEN_SIZE which is the max size of the token > string. > > This is not a critical, it fixes cases where the total length of the > parsed instruction is greater than the maximum. > > Signed-off-by: Olivier Matz Applied, thanks