From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2402DA04B5; Mon, 16 Nov 2020 17:23:33 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CC7DA323E; Mon, 16 Nov 2020 17:23:30 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id E333B2C16 for ; Mon, 16 Nov 2020 17:23:28 +0100 (CET) IronPort-SDR: GmnxRUKerXwQQRnZGmH4oLXM4tNBkFDab6M/N20F0VjIqqgAsgNAUznFXOh3xRm9LxY83lKmAG avCqWu6DH0iA== X-IronPort-AV: E=McAfee;i="6000,8403,9807"; a="255483489" X-IronPort-AV: E=Sophos;i="5.77,483,1596524400"; d="scan'208";a="255483489" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2020 08:23:23 -0800 IronPort-SDR: VPlaIJRMc4kIFSnApN5wTYYQ4mSD+MRelhcniJPp7QAb8wKZXe3HCTjl27LoJe8bcyrFzZ92BA iJJDMWAYyHHQ== X-IronPort-AV: E=Sophos;i="5.77,483,1596524400"; d="scan'208";a="475578234" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.227.57]) ([10.213.227.57]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2020 08:23:21 -0800 To: Xiaoyu Min , Jingjing Wu , Beilei Xing Cc: dev@dpdk.org, Xiaoyu Min , Thomas Monjalon , Andrew Rybchenko , Ori Kam , Dekel Peled References: From: Ferruh Yigit Message-ID: <8990f612-b3b1-bdbc-8da3-9a0e45d5c3bc@intel.com> Date: Mon, 16 Nov 2020 16:23:18 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 4/5] net/iavf: fix protocol size for virtchnl copy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/16/2020 7:55 AM, Xiaoyu Min wrote: > From: Xiaoyu Min > > The rte_flow_item_vlan items are refined. > The structs do not exactly represent the packet bits captured on the > wire anymore so should only copy real header instead of the whole struct. > > Replace the rte_flow_item_* with the existing corresponding rte_*_hdr. > > Fixes: 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN items") > > Signed-off-by: Xiaoyu Min > --- > drivers/net/iavf/iavf_fdir.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c > index d683a468c1..7054bde0b9 100644 > --- a/drivers/net/iavf/iavf_fdir.c > +++ b/drivers/net/iavf/iavf_fdir.c > @@ -541,7 +541,7 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad, > VIRTCHNL_ADD_PROTO_HDR_FIELD_BIT(hdr, ETH, ETHERTYPE); > > rte_memcpy(hdr->buffer, > - eth_spec, sizeof(*eth_spec)); > + eth_spec, sizeof(struct rte_ether_hdr)); This requires 'struct rte_flow_item_eth' should have 'struct rte_ether_hdr' as first element, and I suspect this usage exists in a few more locations, but I wonder if this assumption is real and documented in somewhere? I am not just talking about 'struct rte_flow_item_eth', but for all 'rte_flow_item_*'... btw, while checking for the 'struct rte_flow_item_eth', pahole shows it is using 20 bytes, and I suspect this is not the intention with the reserved field: struct rte_flow_item_eth { struct rte_ether_addr dst; /* 0 6 */ struct rte_ether_addr src; /* 6 6 */ uint16_t type; /* 12 2 */ /* Bitfield combined with previous fields */ uint32_t has_vlan:1; /* 12:15 4 */ /* XXX 31 bits hole, try to pack */ uint32_t reserved:31; /* 16: 1 4 */ /* size: 20, cachelines: 1, members: 5 */ /* bit holes: 1, sum bit holes: 31 bits */ /* bit_padding: 1 bits */ /* last cacheline: 20 bytes */ }; 'has_vlan' seems combined with previous field to make together 32 bits. So the 'reserved' field is occupying a new 32 bits all by itself. What about changing the struct as following, while we can change the ABI: struct rte_flow_item_eth { struct rte_ether_addr dst; /* 0 6 */ struct rte_ether_addr src; /* 6 6 */ uint16_t type; /* 12 2 */ uint16_t has_vlan:1; /* 14:15 2 */ uint16_t reserved:15; /* 14: 0 2 */ /* size: 16, cachelines: 1, members: 5 */ /* last cacheline: 16 bytes */ };