Re: [dpdk-dev] [PATCH v3 2/3] lpm: add support for NEON

DPDK patches and discussions
 help / color / mirror / Atom feed

From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
	konstantin.ananyev@intel.com
Cc: dev@dpdk.org, viktorin@rehivetech.com
Subject: Re: [dpdk-dev] [PATCH v3 2/3] lpm: add support for NEON
Date: Thu, 11 Feb 2016 12:46:33 +0100	[thread overview]
Message-ID: <8996069.HySAWEmhf4@xps13> (raw)
In-Reply-To: <1454040645-23864-3-git-send-email-jerin.jacob@caviumnetworks.com>

2016-01-29 09:40, Jerin Jacob:
> --- a/app/test/test_xmmt_ops.h
> +++ b/app/test/test_xmmt_ops.h
> +#if defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64)
[...]
> +#else
[...]
> --- a/lib/librte_lpm/Makefile
> +++ b/lib/librte_lpm/Makefile
> +ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),)
> +SYMLINK-$(CONFIG_RTE_LIBRTE_LPM)-include += rte_lpm_neon.h
> +else
>  SYMLINK-$(CONFIG_RTE_LIBRTE_LPM)-include += rte_lpm_sse.h
> +endif
[...]
> --- a/lib/librte_lpm/rte_lpm.h
> +++ b/lib/librte_lpm/rte_lpm.h
> +#if defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64)
> +#include "rte_lpm_neon.h"
> +#else
>  #include "rte_lpm_sse.h"
> +#endif

Instead of defaulting to x86 SSE, it would be better to replace
"else" by "elif X86/SSE".
I suggest using RTE_ARCH_X86 or RTE_CPUFLAG_SSEx.
By the way, what is the minimum SSE version required?

next prev parent reply	other threads:[~2016-02-11 11:48 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-30 17:24 [dpdk-dev] [PATCH 0/3] add lpm " Jerin Jacob
2015-11-30 17:24 ` [dpdk-dev] [PATCH 1/3] eal: introduce rte_vect_* abstractions Jerin Jacob
2015-12-02 13:43   ` Jan Viktorin
2015-12-02 14:51     ` Jerin Jacob
2015-11-30 17:24 ` [dpdk-dev] [PATCH 2/3] lpm: add support for NEON Jerin Jacob
2015-12-02 13:43   ` Jan Viktorin
2015-12-02 14:56     ` Jerin Jacob
2015-12-02 15:00       ` Jan Viktorin
2015-11-30 17:24 ` [dpdk-dev] [PATCH 3/3] maintainers: claim responsibility for arm64 specific files of hash and lpm Jerin Jacob
2015-12-02 13:43   ` Jan Viktorin
2015-12-02 14:57     ` Jerin Jacob
2015-12-02 13:43 ` [dpdk-dev] [PATCH 0/3] add lpm support for NEON Jan Viktorin
2015-12-02 14:41   ` Jerin Jacob
2015-12-04 15:14 ` [dpdk-dev] [PATCH v2 " Jerin Jacob
2015-12-04 15:14   ` [dpdk-dev] [PATCH v2 1/3] lpm: make rte_lpm_lookupx4 API definition architecture agnostic Jerin Jacob
2015-12-07  6:15     ` Jianbo Liu
2015-12-07  6:57       ` Jerin Jacob
2015-12-07 14:06     ` Ananyev, Konstantin
2015-12-04 15:14   ` [dpdk-dev] [PATCH v2 2/3] lpm: add support for NEON Jerin Jacob
2015-12-04 15:14   ` [dpdk-dev] [PATCH v2 3/3] maintainers: claim responsibility for arm64 specific files of hash and lpm Jerin Jacob
2016-01-29  4:10   ` [dpdk-dev] [PATCH v3 0/3] add lpm support for NEON Jerin Jacob
2016-01-29  4:10     ` [dpdk-dev] [PATCH v3 1/3] lpm: make rte_lpm_lookupx4 API definition architecture agnostic Jerin Jacob
2016-01-29  4:10     ` [dpdk-dev] [PATCH v3 2/3] lpm: add support for NEON Jerin Jacob
2016-02-11 11:46       ` Thomas Monjalon [this message]
2016-02-12  6:47         ` Jerin Jacob
2016-02-12  8:42           ` Thomas Monjalon
2016-01-29  4:10     ` [dpdk-dev] [PATCH v3 3/3] maintainers: claim responsibility for arm64 specific files of hash and lpm Jerin Jacob
2016-02-08  9:29     ` [dpdk-dev] [PATCH v3 0/3] add lpm support for NEON Jerin Jacob
2016-02-12 12:28     ` [dpdk-dev] [PATCH v4 " Jerin Jacob
2016-02-12 12:28       ` [dpdk-dev] [PATCH v4 1/3] lpm: make rte_lpm_lookupx4 API definition architecture agnostic Jerin Jacob
2016-03-01 17:42         ` Thomas Monjalon
2016-03-02  6:28           ` Jerin Jacob
2016-02-12 12:28       ` [dpdk-dev] [PATCH v4 2/3] lpm: add support for NEON Jerin Jacob
2016-03-01 17:46         ` Thomas Monjalon
2016-03-02  6:45           ` Jerin Jacob
2016-02-12 12:28       ` [dpdk-dev] [PATCH v4 3/3] maintainers: claim responsibility for arm64 specific files of hash and lpm Jerin Jacob
2016-03-01 17:47         ` Thomas Monjalon
2016-03-02  6:46           ` Jerin Jacob
2016-02-16 13:27       ` [dpdk-dev] [PATCH v4 0/3] add lpm support for NEON Kobylinski, MichalX
2016-02-16 16:44         ` Jerin Jacob
2016-02-18 10:26           ` Kobylinski, MichalX
2016-02-19  0:34             ` Jerin Jacob
2016-03-11  3:52       ` [dpdk-dev] [PATCH v5 " Jerin Jacob
2016-03-11  3:52         ` [dpdk-dev] [PATCH v5 1/3] lpm: make rte_lpm_lookupx4 API definition architecture agnostic Jerin Jacob
2016-03-11  3:52         ` [dpdk-dev] [PATCH v5 2/3] lpm: add support for NEON Jerin Jacob
2016-03-11  3:52         ` [dpdk-dev] [PATCH v5 3/3] Maintainers: claim responsibility for arm64 specific files of hash Jerin Jacob
2016-03-11 14:24         ` [dpdk-dev] [PATCH v5 0/3] add lpm support for NEON Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8996069.HySAWEmhf4@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=viktorin@rehivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).