From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 65C711396 for ; Thu, 14 Sep 2017 11:33:57 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Sep 2017 02:33:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,392,1500966000"; d="scan'208";a="135255766" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by orsmga002.jf.intel.com with ESMTP; 14 Sep 2017 02:33:55 -0700 To: Yong Wang , shepard.siegel@atomicrules.com Cc: dev@dpdk.org References: <1505373770-24737-1-git-send-email-wang.yong19@zte.com.cn> From: Ferruh Yigit Message-ID: <89a345e1-43ba-2a2a-4cd2-55e2bad1817d@intel.com> Date: Thu, 14 Sep 2017 10:33:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1505373770-24737-1-git-send-email-wang.yong19@zte.com.cn> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/ark:add null point check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Sep 2017 09:33:57 -0000 On 9/14/2017 8:22 AM, Yong Wang wrote: > In function ark_config_device(), there are several malloc without null > point check. Fix it by adding null point check. > > Signed-off-by: Yong Wang Hi Yong, Thank you for the patch. I think you have sent new version of the patch because previous one was giving checkpatch warning, but having two patches with same title is being confusing. Next time would you mind sending next version as version 2 (v2) and as a reply to previous version of the patch? So this makes clear which one is the one to take into account. Also adding a changelog to the commit log makes life easy. Thanks. DPDK Contributor's Guide has more details: http://dpdk.org/doc/guides/contributing/patches.html Thanks, ferruh