From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4CC91A0583; Fri, 20 Mar 2020 20:25:17 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0A78C2BB9; Fri, 20 Mar 2020 20:25:16 +0100 (CET) Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [63.128.21.74]) by dpdk.org (Postfix) with ESMTP id 02963F94 for ; Fri, 20 Mar 2020 20:25:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584732314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=dj+m7z3vbpQkn/jkKzE6jjG1+ZAzTwIlE7Cb9stN/Mk=; b=VEF0UYHgi51BqpM7mNThEus5QERngVhMyFbVcO5uQzpvycjgJa00EHqFU44WJiQ4wqf2Qa v+7yj9eVutjnRStlhdApUfNLn+iFoRHodV0FIGV4gx6Z/TAVBSuE7YX3o99eo8h0mfcV/d c3CxZZbd5bA+zdnJN/INaJBPXzTaob0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-330-K4aOpA_ENtq4PUkOvWuTYQ-1; Fri, 20 Mar 2020 15:25:12 -0400 X-MC-Unique: K4aOpA_ENtq4PUkOvWuTYQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3224D8017CC; Fri, 20 Mar 2020 19:25:11 +0000 (UTC) Received: from [10.33.36.202] (unknown [10.33.36.202]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8C23294964; Fri, 20 Mar 2020 19:25:04 +0000 (UTC) To: Maxime Coquelin , Itsuro Oda , tiwei.bie@intel.com, zhihong.wang@intel.com, anatoly.burakov@intel.com, dev@dpdk.org, stable@dpdk.org Cc: Xiaolong Ye References: <20200303000329.823-1-oda@valinux.co.jp> <20200305025450.5498-1-oda@valinux.co.jp> <8a0f27cd-fe00-fe0f-b864-798cca98dbd6@redhat.com> <0a169c6f-7f63-7df0-852a-fff4ddadcfc6@redhat.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Message-ID: <89a6e278-1fda-0b6d-2df4-4b56ae022f40@redhat.com> Date: Fri, 20 Mar 2020 19:25:04 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <0a169c6f-7f63-7df0-852a-fff4ddadcfc6@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3] net/vhost: fix potential memory leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 20/03/2020 16:23, Maxime Coquelin wrote: >=20 >=20 > On 3/19/20 6:15 PM, Kevin Traynor wrote: >> Hi Itsuro, >> >> On 05/03/2020 02:54, Itsuro Oda wrote: >>> If a vhost device is closed before eth_dev_configure is done >>> to the device, internal resources allocated to the device >>> would not be freed. This patch fixes it. >>> >>> Fixes: 3d01b759d267 ("net/vhost: delay driver setup") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Itsuro Oda >>> Reviewed-by: Xiaolong Ye >> >> This fixes an issue with the patch you backported for 18.11. Is the >> issue also present in the backported version? >> >> If so, this patch is not in upstream dpdk or gone through validation. So >> the choices are, >> >> 1. revert your patches from 18.11 >> 2. go ahead on stable without this patch >> 3. delay until this patch is in master (but not until validated) and >> then backport to stable >> >> Itsuro/Maxime, what do you think? >=20 > I think you should drop Itsuro patches for now, as long as this patch is > not in master. Secondary process was broken for several revisions in > Vhost, so it is better to keep it broken for now than risking > regressions on primary process support. >=20 I agree, vhost primary is too well used to take risks on regression while there are still some outstanding issues being resolved with these patches for secondary process. Patches reverted. > If this patch is in master before the next 18.11 is done, then we can > pick all the patches. >=20 Yes, we can do that. thanks, Kevin. > Thanks, > Maxime >> thanks, >> Kevin. >> >>> --- >>> v2: >>> - fix commit message >>> >>> v3: >>> - fix spell error of Reviewed-by >>> >>> drivers/net/vhost/rte_eth_vhost.c | 16 +++++++--------- >>> 1 file changed, 7 insertions(+), 9 deletions(-) >>> >>> diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_= eth_vhost.c >>> index 458ed58f5..1ed977e9b 100644 >>> --- a/drivers/net/vhost/rte_eth_vhost.c >>> +++ b/drivers/net/vhost/rte_eth_vhost.c >>> @@ -1065,16 +1065,14 @@ eth_dev_close(struct rte_eth_dev *dev) >>> =20 >>> =09eth_dev_stop(dev); >>> =20 >>> -=09rte_vhost_driver_unregister(internal->iface_name); >>> - >>> =09list =3D find_internal_resource(internal->iface_name); >>> -=09if (!list) >>> -=09=09return; >>> - >>> -=09pthread_mutex_lock(&internal_list_lock); >>> -=09TAILQ_REMOVE(&internal_list, list, next); >>> -=09pthread_mutex_unlock(&internal_list_lock); >>> -=09rte_free(list); >>> +=09if (list) { >>> +=09=09rte_vhost_driver_unregister(internal->iface_name); >>> +=09=09pthread_mutex_lock(&internal_list_lock); >>> +=09=09TAILQ_REMOVE(&internal_list, list, next); >>> +=09=09pthread_mutex_unlock(&internal_list_lock); >>> +=09=09rte_free(list); >>> +=09} >>> =20 >>> =09if (dev->data->rx_queues) >>> =09=09for (i =3D 0; i < dev->data->nb_rx_queues; i++) >>> >>