From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 40C882C2A for ; Fri, 16 Sep 2016 09:36:21 +0200 (CEST) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B5DFA19D05F; Fri, 16 Sep 2016 07:36:20 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-5-186.ams2.redhat.com [10.36.5.186]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8G7aJGL015941; Fri, 16 Sep 2016 03:36:20 -0400 To: Keith Wiles , dev@dpdk.org References: <1473948649-14169-1-git-send-email-keith.wiles@intel.com> <1473948649-14169-3-git-send-email-keith.wiles@intel.com> From: Panu Matilainen Message-ID: <89bb7bfa-aab3-1de5-a622-c2cfebe028af@redhat.com> Date: Fri, 16 Sep 2016 10:36:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1473948649-14169-3-git-send-email-keith.wiles@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 16 Sep 2016 07:36:20 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 3/3] drivers/net:build support for new tap device driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2016 07:36:21 -0000 On 09/15/2016 05:10 PM, Keith Wiles wrote: > Signed-off-by: Keith Wiles > --- > config/common_linuxapp | 3 +++ > drivers/net/Makefile | 1 + > mk/rte.app.mk | 1 + > 3 files changed, 5 insertions(+) > > diff --git a/config/common_linuxapp b/config/common_linuxapp > index 2483dfa..704c01c 100644 > --- a/config/common_linuxapp > +++ b/config/common_linuxapp > @@ -44,3 +44,6 @@ CONFIG_RTE_LIBRTE_PMD_VHOST=y > CONFIG_RTE_LIBRTE_PMD_AF_PACKET=y > CONFIG_RTE_LIBRTE_POWER=y > CONFIG_RTE_VIRTIO_USER=y > +CONFIG_RTE_LIBRTE_PMD_TAP=y > +CONFIG_RTE_PMD_TAP_MAX_QUEUES=32 > + > diff --git a/drivers/net/Makefile b/drivers/net/Makefile > index bc93230..b4afa98 100644 > --- a/drivers/net/Makefile > +++ b/drivers/net/Makefile > @@ -55,6 +55,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD) += thunderx > DIRS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio > DIRS-$(CONFIG_RTE_LIBRTE_VMXNET3_PMD) += vmxnet3 > DIRS-$(CONFIG_RTE_LIBRTE_PMD_XENVIRT) += xenvirt > +DIRS-$(CONFIG_RTE_LIBRTE_PMD_TAP) += tap > > ifeq ($(CONFIG_RTE_LIBRTE_VHOST),y) > DIRS-$(CONFIG_RTE_LIBRTE_PMD_VHOST) += vhost > diff --git a/mk/rte.app.mk b/mk/rte.app.mk > index 1a0095b..bd1d10f 100644 > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -129,6 +129,7 @@ ifeq ($(CONFIG_RTE_LIBRTE_VHOST),y) > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_VHOST) += -lrte_pmd_vhost > endif # $(CONFIG_RTE_LIBRTE_VHOST) > _LDLIBS-$(CONFIG_RTE_LIBRTE_VMXNET3_PMD) += -lrte_pmd_vmxnet3_uio > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_TAP) += -lrte_pmd_tap > > ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y) > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_MB) += -lrte_pmd_aesni_mb > Splitting the Makefile and config changes into a separate patch makes no sense at all in this case. Just do it in the patch introducing the driver. And actually, ditto for documentation. - Panu -