From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 333ED1C01; Tue, 17 Jul 2018 11:57:32 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2018 02:57:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,365,1526367600"; d="scan'208";a="67647906" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.255.138.184]) ([10.255.138.184]) by fmsmga002.fm.intel.com with ESMTP; 17 Jul 2018 02:57:27 -0700 To: Ori Kam , "Xu, Rosen" , "dev@dpdk.org" Cc: "stable@dpdk.org" , "Gilmore, Walter E" , Qi Zhang References: <1531361387-116027-1-git-send-email-rosen.xu@intel.com> <0E78D399C70DA940A335608C6ED296D73A13DA82@SHSMSX104.ccr.corp.intel.com> <0E78D399C70DA940A335608C6ED296D73A13FDB8@SHSMSX104.ccr.corp.intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= xsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsF+BBMBAgAoAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAUCWZR3VQUJB33WBQAKCRD5M+tD3xNhH6DWEACVhEb8q1epPwZrUDoxzu7E TS1b8tmabOmnjXZRs6+EXgUVHkp2xxkCfDmL3pa5bC0G/74aJnWjNsdvE05V1cb4YK4kRQ62 FwDQ+hlrFrwFB3PtDZk1tpkzCRHvJgnIil+0MuEh32Y57ig6hy8yO8ql7Lohyrnpfk/nNpm4 jQGEF5qEeHcEFe1AZQlPHN/STno8NZSz2nl0b2cw+cujN1krmvB52Ah/2KugQ6pprVyrGrzB c34ZQO9OsmSjJlETCZk6EZzuhfe16iqBFbOSadi9sPcJRwaUQBid+xdFWl7GQ8qC3zNPibSF HmU43yBZUqJDZlhIcl6/cFpOSjv2sDWdtjEXTDn5y/0FsuY0mFE78ItC4kCTIVk17VZoywcd fmbbnwOSWzDq7hiUYuQGkIudJw5k/A1CMsyLkoUEGN3sLfsw6KASgS4XrrmPO4UVr3mH5bP1 yC7i1OVNpzvOxtahmzm481ID8sk72GC2RktTOHb0cX+qdoiMMfYgo3wRRDYCBt6YoGYUxF1p msjocXyqToKhhnFbXLaZlVfnQ9i2i8jsj9SKig+ewC2p3lkPj6ncye9q95bzhmUeJO6sFhJg Hiz6syOMg8yCcq60j07airybAuHIDNFWk0gaWAmtHZxLObZx2PVn2nv9kLYGohFekw0AOsIW ta++5m48dnCoAc7BTQRX1ky+ARAApzQNvXvE2q1LAS+Z+ni2R13Bb1cDS1ZYq1jgpR13+OKN ipzd8MPngRJilXxBaPTErhgzR0vGcNTYhjGMSyFIHVOoBq1VbP1a0Fi/NqWzJOowo/fDfgVy K4vuitc/gCJs+2se4hdZA4EQJxVlNM51lgYDNpjPGIA43MX15OLAip73+ho6NPBMuc5qse3X pAClNhBKfENRCWN428pi3WVkT+ABRTE0taxjJNP7bb+9TQYNRqGwnGzX5/XISv44asWIQCaq vOkXSUJLd//cdVNTqtL1wreCVVR5pMXj7VIrlk07fmmJVALCmGbFr53BMb8O+8dgK2A5mitM n44d+8KdJWOwziRxcaMk/LclmZS3Iv1TERtiWt98Y9AjeAtcgYPkA3ld0BcUKONogP8pHVz1 Ed3s5rDQ91yr1S0wuAzW91fxGUO4wY+uPmxCtFVuBgd9VT9NAKTUL0qHM7CDgCnZPe0TW6Zj 8OqtdCCyAfvU9cW5xWM7Icxhde6AtPxhDSBwE8fL2ZmrDmaA4jmUKXp3i4JxRPSX84S08b+s DWXHPxy10UFU5A7EK/BEbZAKBwn9ROfm+WK+6X5xOGLoRE++OqNuUudxC1GDyLOPaqCbBCS9 +P6HsTHzxsjyJa27n4jcrcuY3P9TEcFJYSZSeSDh8mVGvugi0exnSJrrBZDyVCcAEQEAAcLB ZQQYAQIADwIbDAUCWZR1ZwUJA59cIQAKCRD5M+tD3xNhH5b+D/9XG44Ci6STdcA5RO/ur05J EE3Ux1DCHZ5V7vNAtX/8Wg4l4GZfweauXwuJ1w7Sp7fklwcNC6wsceI+EmNjGMqfIaukGetG +jBGqsQ7moOZodfXUoCK98gblKgt/BPYMVidzlGC8Q/+lZg1+o29sPnwImW+MXt/Z5az/Z17 Qc265g+p5cqJHzq6bpQdnF7Fu6btKU/kv6wJghENvgMXBuyThqsyFReJWFh2wfaKyuix3Zyj ccq7/blkhzIKmtFWgDcgaSc2UAuJU+x9nuYjihW6WobpKP/nlUDu3BIsbIq09UEke+uE/QK+ FJ8PTJkAsXOf1Bc2C0XbW4Y2hf103+YY6L8weUCBsWC5VH5VtVmeuh26ENURclwfeXhWQ9Og 77yzpTXWr5g1Z0oLpYpWPv745J4bE7pv+dzxOrFdM1xNkzY2pvXph/A8OjxZNQklDkHQ7PIB Lki5L2F4XkEOddUUQchJwzMqTPsggPDmGjgLZrqgO+s4ECZK5+nLD3HEpAbPa3JLDaScy+90 Nu1lAqPUHSnP3vYZVw85ZYm6UCxHE4VLMnnJsN09ZhsOSVR+GyP5Nyw9rT1V3lcsuH7M5Naa 2Xobn9m7l9bRCD/Ji8kG15eV1WTxx1HXVQGjdUYDI7UwegBNbwMLh17XDy+3sn/6SgcqtECA Q6pZKA2mTQxEKMLBZQQYAQIADwIbDAUCWZR3hQUJA59eRwAKCRD5M+tD3xNhH4a/D/4jLAZu UhvU1swWcNEVVCELZ0D3LOV14XcY2MXa3QOpeZ9Bgq7YYJ4S5YXK+SBQS0FkRZdjGNvlGZoG ZdpU+NsQmQFhqHGwX0IT9MeTFM8uvKgxNKGwMVcV9g0IOqwBhGHne+BFboRA9362fgGW5AYQ zT0mzzRKEoOh4r3AQvbM6kLISxo0k1ujdYiI5nj/5WoKDqxTwwfuN1uDUHsWo3tzenRmpMyU NyW3Dc+1ajvXLyo09sRRq7BnM99Rix1EGL8Qhwy+j0YAv+FuspWxUX9FxXYho5PvGLHLsHfK FYQ7x/RRbpMjkJWVfIe/xVnfvn4kz+MTA5yhvsuNi678fLwY9hBP0y4lO8Ob2IhEPdfnTuIs tFVxXuelJ9xAe5TyqP0f+fQjf1ixsBZkqOohsBXDfje0iaUpYa/OQ/BBeej0dUdg2JEu4jAC x41HpVCnP9ipLpD0fYz1d/dX0F/VY2ovW6Eba/y/ngOSAR6C+u881m7oH2l0G47MTwkaQCBA bLGXPj4TCdX3lftqt4bcBPBJ+rFAnJmRHtUuyyaewBnZ81ZU2YAptqFM1kTh+aSvMvGhfVsQ qZL2rk2OPN1hg+KXhErlbTZ6oPtLCFhSHQmuxQ4oc4U147wBTUuOdwNjtnNatUhRCp8POc+3 XphVR5G70mnca1E2vzC77z+XSlTyRA== Message-ID: <89cbeb7f-ad18-a0cf-3e7c-a15b26a1b86f@intel.com> Date: Tue, 17 Jul 2018 10:57:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] examples/flow_filtering: add rte_fdir_conf initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jul 2018 09:57:33 -0000 On 7/17/2018 6:15 AM, Ori Kam wrote: > Sorry for the late response, > >> -----Original Message----- >> From: Xu, Rosen [mailto:rosen.xu@intel.com] >> Sent: Thursday, July 12, 2018 9:23 AM >> To: Ori Kam ; dev@dpdk.org >> Cc: Yigit, Ferruh ; stable@dpdk.org; Gilmore, Walter >> E >> Subject: RE: [dpdk-dev] [PATCH] examples/flow_filtering: add rte_fdir_conf >> initialization >> >> Hi Ori, >> >> Pls see my reply. >> >> Hi Walter and Ferruh, >> >> I need your voice :) >> >>> -----Original Message----- >>> From: Ori Kam [mailto:orika@mellanox.com] >>> Sent: Thursday, July 12, 2018 13:58 >>> To: Xu, Rosen ; dev@dpdk.org >>> Cc: Yigit, Ferruh ; stable@dpdk.org >>> Subject: RE: [dpdk-dev] [PATCH] examples/flow_filtering: add >> rte_fdir_conf >>> initialization >>> >>> Hi, >>> >>> PSB >>> >>>> -----Original Message----- >>>> From: Xu, Rosen [mailto:rosen.xu@intel.com] >>>> Sent: Thursday, July 12, 2018 8:27 AM >>>> To: Ori Kam ; dev@dpdk.org >>>> Cc: Yigit, Ferruh ; stable@dpdk.org >>>> Subject: RE: [dpdk-dev] [PATCH] examples/flow_filtering: add >>>> rte_fdir_conf initialization >>>> >>>> Hi Ori, >>>> >>>> examples/flow_filtering sample app fails on i40e [1] because i40e >>>> requires explicit FDIR configuration. >>>> >>>> But rte_flow in and hardware independent ways of describing >>>> flow-action, it shouldn't require specific config options for specific >>> hardware. >>>> >>> >>> I don't understand why using rte flow require the use of fdir. >>> it doesn't make sense to me, that new API will need old one. >> >> It's a good question, I also have this question about Mellanox NIC Driver >> mlx5_flow.c. >> In this file many flow functions call fdir. :) > > The only functions that are calling fdir are fdir function, > and you can see that inside of the create function we convert the fdir > Into rte flow. > >> >>>> Is there any chance driver select the FDIR config automatically based >>>> on rte_flow rule, unless explicitly a FDIR config set by user? >>> >>> I don't know how the i40e driver is implemented but I know that Mellanox >>> convert the other way around, if fdir is given it is converted to rte_flow. >> >> Firstly, rte_fdir_conf is part of rte_eth_conf definition. >> struct rte_eth_conf { >> ...... >> struct rte_fdir_conf fdir_conf; /**< FDIR configuration. */ >> ...... >> }; >> Secondly, default value of rte_eth_conf.fdir_conf.mode is >> RTE_FDIR_MODE_NONE, which means Disable FDIR support. >> Thirdly, flow_filtering should align with test-pmd, in test-pmd all fdir_conf is >> initialized. >> > > This sounds to me correct we don't want to enable fdir. > Why should the example app for rte flow use fdir? And align to > testpmd which support everything in in all modes? In i40e fdir is used to implement filters, that is why rte_flow rules requires/depends some fdir configurations. In long term I agree it is better if driver doesn't require any fdir configuration for rte_flow programing, although not sure if this is completely possible, cc'ed Qi for more comment. For short term I am for getting this patch so that sample app can run on i40e too, and fdir configuration shouldn't effect others. Perhaps it can be good to add a comment to say why that config option is added and it is a temporary workaround. > > >>> >>>> >>>> [1] >>>> Flow can't be created 1 message: Check the mode in fdir_conf. >>>> EAL: Error - exiting with code: 1 >>>> >>>>> -----Original Message----- >>>>> From: Ori Kam [mailto:orika@mellanox.com] >>>>> Sent: Thursday, July 12, 2018 13:17 >>>>> To: Xu, Rosen ; dev@dpdk.org >>>>> Cc: Yigit, Ferruh ; stable@dpdk.org; Ori Kam >>>>> >>>>> Subject: RE: [dpdk-dev] [PATCH] examples/flow_filtering: add >>>> rte_fdir_conf >>>>> initialization >>>>> >>>>> Hi Rosen, >>>>> >>>>> Why do the fdir_conf must be initialized? >>>>> >>>>> What is the issue you are seeing? >>>>> >>>>> Best, >>>>> Ori >>>>> >>>>>> -----Original Message----- >>>>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rosen Xu >>>>>> Sent: Thursday, July 12, 2018 5:10 AM >>>>>> To: dev@dpdk.org >>>>>> Cc: rosen.xu@intel.com; ferruh.yigit@intel.com; Ori Kam >>>>>> ; stable@dpdk.org >>>>>> Subject: [dpdk-dev] [PATCH] examples/flow_filtering: add >> rte_fdir_conf >>>>>> initialization >>>>>> >>>>>> Rte_fdir_conf of rte_eth_conf should be initialized before port >>>>>> initialization. >>>>>> >>>>>> Fixes: 4a3ef59a10c8 ("examples/flow_filtering: add simple demo of >>> flow >>>>>> API") >>>>>> Cc: stable@dpdk.org >>>>>> >>>>>> Signed-off-by: Rosen Xu >>>>>> --- >>>>>> examples/flow_filtering/main.c | 6 ++++++ >>>>>> 1 file changed, 6 insertions(+) >>>>>> >>>>>> diff --git a/examples/flow_filtering/main.c >>>>>> b/examples/flow_filtering/main.c index f595034..aa03e23 100644 >>>>>> --- a/examples/flow_filtering/main.c >>>>>> +++ b/examples/flow_filtering/main.c >>>>>> @@ -132,6 +132,12 @@ >>>>>> DEV_TX_OFFLOAD_SCTP_CKSUM | >>>>>> DEV_TX_OFFLOAD_TCP_TSO, >>>>>> }, >>>>>> + .fdir_conf = { >>>>>> + .mode = RTE_FDIR_MODE_PERFECT, >>>>>> + .pballoc = RTE_FDIR_PBALLOC_64K, >>>>>> + .status = RTE_FDIR_REPORT_STATUS, >>>>>> + .drop_queue = 127, >>>>>> + }, >>>>>> }; >>>>>> struct rte_eth_txconf txq_conf; >>>>>> struct rte_eth_rxconf rxq_conf; >>>>>> -- >>>>>> 1.8.3.1 > > > Best, > Ori >