DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Min Hu (Connor)" <humin29@huawei.com>, dev@dpdk.org
Cc: kirill.rybalchenko@intel.com
Subject: Re: [dpdk-dev] [PATCH] examples/ptpclient: delete wrong comments
Date: Mon, 12 Apr 2021 09:04:35 +0100
Message-ID: <89cedfc0-9a44-43ea-2390-7eeb65c1b4ab@intel.com> (raw)
In-Reply-To: <da3e250d-8ea7-69fc-4acf-f256375c86cf@huawei.com>

On 4/10/2021 10:11 AM, Min Hu (Connor) wrote:
> Hi, Ferruh, kirill and all,
>      Any comments about this patch?
> 
> 在 2021/3/27 15:36, Min Hu (Connor) 写道:
>> This patch deletes the comments which are wrong and unnecessary.
>>
>> Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> ---
>>   examples/ptpclient/ptpclient.c | 4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c
>> index 33b297e..878d1a0 100644
>> --- a/examples/ptpclient/ptpclient.c
>> +++ b/examples/ptpclient/ptpclient.c
>> @@ -606,10 +606,6 @@ lcore_main(void)
>>       unsigned nb_rx;
>>       struct rte_mbuf *m;
>> -    /*
>> -     * Check that the port is on the same NUMA node as the polling thread
>> -     * for best performance.
>> -     */
>>       printf("\nCore %u Waiting for SYNC packets. [Ctrl+C to quit]\n",
>>               rte_lcore_id());
>>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

The comment seems left over from the example this example cloned from..

  reply	other threads:[~2021-04-12  8:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-27  7:36 Min Hu (Connor)
2021-04-10  9:11 ` Min Hu (Connor)
2021-04-12  8:04   ` Ferruh Yigit [this message]
2021-04-19  7:42     ` Min Hu (Connor)
2021-04-20  1:02     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89cedfc0-9a44-43ea-2390-7eeb65c1b4ab@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=humin29@huawei.com \
    --cc=kirill.rybalchenko@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git