From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD6AF43892; Thu, 11 Jan 2024 13:21:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6909A40266; Thu, 11 Jan 2024 13:21:40 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 2AC534025E for ; Thu, 11 Jan 2024 13:21:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704975698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0uWWEaRah2o7JPlVlwxcli2Ww/ae/ueaA6RcsZ16oZM=; b=eFkubMA4W/7TMVRNEqnRpwTFWKM8keqRKk9BRVr9LQrVKSu/C3A8KPZU34SMD+QMwiOhNe cnEBTb8hsmQcnQzSdmsrOFNBtus/ROZGcS5b9n83Jkki6B47KMwjV6+LI5lbALBJU1MGYk 9v9EWRcGP+PTrr5fTLaEZ4DYKkLSOUk= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-356-jXXhdc8qNvq_ByVTgzZ2eA-1; Thu, 11 Jan 2024 07:21:37 -0500 X-MC-Unique: jXXhdc8qNvq_ByVTgzZ2eA-1 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-429be5ecc87so10451291cf.2 for ; Thu, 11 Jan 2024 04:21:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704975696; x=1705580496; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=0uWWEaRah2o7JPlVlwxcli2Ww/ae/ueaA6RcsZ16oZM=; b=ULntt55Khos+bbjrIc/lHwBWDCZlukh7ty+DpRhgETyeOJIW86V+nRHguU7VImmuKD /I+yHvu5Q0qoUu846+cLM6I9WH4m4ERDhDCGgS3B4uViRThaWcvo9Cd6AZscjwSj6H/l TntdqE3Mvca/0u8yrfRQGChAijBVImqlM0jQT4bw4ntVXDmcwjheHH0u1VCN5nbuyVVH LOaISbI+dMC/N+lrKUGjmF9BQHMYCxRhFwL26JO8dI44JuawNBmPOFoAvrz+icg6zooY q2ZcokJ1DVTE+WWv4Mo/j+PEE+yoQ2pR8GJ0DOcVYzFHEeAh08VigD3z/YwOLPD5QNNj EbFQ== X-Gm-Message-State: AOJu0YwNw6RofGcylBR9fGE+YUuLqRKrTOemsfdTG3drXwGn93Qxt2tK HsopIpq9532aI6s6SIy8uhQwed6VfPjZA5Bf2eV19OElVhEWqK45RfZUjWUS8JUHZGRZyP9NSzI TrOMvu0X9vHc= X-Received: by 2002:a05:622a:1a94:b0:429:c715:1b2 with SMTP id s20-20020a05622a1a9400b00429c71501b2mr404505qtc.135.1704975696491; Thu, 11 Jan 2024 04:21:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IEG0tWmhLMi7jvYNnq9NRCXpA4nOYUsZuZjGC982B3XUIfWhN9u9W4Oz46Mg9LFUraUyBULAA== X-Received: by 2002:a05:622a:1a94:b0:429:c715:1b2 with SMTP id s20-20020a05622a1a9400b00429c71501b2mr404494qtc.135.1704975696232; Thu, 11 Jan 2024 04:21:36 -0800 (PST) Received: from [192.168.0.12] ([78.17.185.107]) by smtp.gmail.com with ESMTPSA id ck15-20020a05622a230f00b00429893f6f92sm392634qtb.12.2024.01.11.04.21.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jan 2024 04:21:35 -0800 (PST) Message-ID: <89fd40d1-cc91-4390-9bc6-c60f24129ebb@redhat.com> Date: Thu, 11 Jan 2024 12:21:32 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v7 1/1] net/af_xdp: fix multi interface support for K8s To: Ferruh Yigit , stephen@networkplumber.org, lihuisong@huawei.com, fengchengwen@huawei.com, liuyonglong@huawei.com, david.marchand@redhat.com Cc: dev@dpdk.org, Ciara Loftus , Shibin Koikkara Reeny , Kevin Traynor , Luca Boccassi References: <20231222110441.2507650-1-mtahhan@redhat.com> <6cd6ab2d-56ab-4afe-b0cd-05ab6b017469@amd.com> From: Maryam Tahhan In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="------------ehsJOLtIydsUpZP7U7yJDG3S" Content-Language: en-US X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This is a multi-part message in MIME format. --------------ehsJOLtIydsUpZP7U7yJDG3S Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/01/2024 11:35, Ferruh Yigit wrote: > Devarg is user interface, changing it impacts the user. > > Assume that user of '22.11.3' using 'use_cni' dev_arg, it will be broken > when user upgrades DPDK to '22.11.4', which is not expected. > > dev_arg is not API/ABI but as it impacts the user, it is in the gray > area to backport to the LTS release. Fair enough > > > Current patch doesn't have Fixes tag or stable tag, so it doesn't > request to be backported to LTS release. I took this as an improvement, > more than a fix. This was overlooked by me apologies. It's been a while since I've contributed to DPDK and I must've missed this detail in the contribution guide. > As far as I understand existing code (that use 'use_cni' dev_arg) > supports only single netdev, this patch adds support for multiple netdevs. The use_cni implementation will no longer work with the AF_XDP DP as the use_cni was originally implemented as it has hard coded what's now an incorrect path for the UDS. > > So what do you think keep LTS with 'use_cni' dev_arg, is there a > requirement to update LTS release? > If so, can it be an option to keep 'use_cni' for backward compatibility > but add only add 'uds_path' and remove 'use_cni' in next LTS? Yeah we can go back to the version of the patch that had the 'use_cni' flag that was used in combination with the path argument. We can add better documentation re the "use_cni" misnomer... What we can then do is if no path argument is set by the user assume their intent and and generate the path internally in the AF_XDP PMD (which was suggested by Shibin at some stage). That way there should be no surprises to the End User. Long term I would like to keep a (renamed) path argument (in case the path does ever change from the AF_XDP DP POV) and use it also in combination with another (maybe boolean) param for passing pinned bpf maps rather than another separate path. WDYT? Would this work for the LTS release? --------------ehsJOLtIydsUpZP7U7yJDG3S Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit
On 11/01/2024 11:35, Ferruh Yigit wrote:
Devarg is user interface, changing it impacts the user.

Assume that user of '22.11.3' using 'use_cni' dev_arg, it will be broken
when user upgrades DPDK to '22.11.4', which is not expected.

dev_arg is not API/ABI but as it impacts the user, it is in the gray
area to backport to the LTS release.
Fair enough


Current patch doesn't have Fixes tag or stable tag, so it doesn't
request to be backported to LTS release. I took this as an improvement,
more than a fix.

This was overlooked by me apologies. It's been a while since I've contributed to DPDK and I must've missed this detail in the contribution guide.
As far as I understand existing code (that use 'use_cni' dev_arg)
supports only single netdev, this patch adds support for multiple netdevs.

The use_cni implementation will no longer work with the AF_XDP DP as the use_cni was originally implemented as it has hard coded what's now an incorrect path for the UDS.


So what do you think keep LTS with 'use_cni' dev_arg, is there a
requirement to update LTS release?
If so, can it be an option to keep 'use_cni' for backward compatibility
but add only add 'uds_path' and remove 'use_cni' in next LTS?


Yeah we can go back to the version of the patch that had the 'use_cni' flag that was used in combination with the path argument. We can add better documentation re the "use_cni" misnomer... What we can then do is if no path argument is set by the user assume their intent and and generate the path internally in the AF_XDP PMD (which was suggested by Shibin at some stage). That way there should be no surprises to the End User.

Long term I would like to keep a (renamed) path argument (in case the path does ever change from the AF_XDP DP POV) and use it also in combination with another (maybe boolean) param for passing pinned bpf maps rather than another separate path.

WDYT? Would this work for the LTS release?


--------------ehsJOLtIydsUpZP7U7yJDG3S--