From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 0B67CE72 for ; Thu, 28 May 2015 13:07:07 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 28 May 2015 04:06:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,512,1427785200"; d="scan'208";a="736687046" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga002.jf.intel.com with ESMTP; 28 May 2015 04:06:49 -0700 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.189]) by irsmsx105.ger.corp.intel.com ([169.254.7.73]) with mapi id 14.03.0224.002; Thu, 28 May 2015 12:06:47 +0100 From: "Buriez, Patrice" To: "Wodkowski, PawelX" , =?iso-8859-1?Q?Simon_K=E5gstr=F6m?= , "Zhang, Helin" , Alexander Guy , "Julien Cretin" Thread-Topic: [PATCH] kni: Use utsrelease.h to determine Ubuntu kernel version Thread-Index: AQHQmPaY/1ItCZM1VUyV9JxqmUR20J2RKGfg///5cYCAABMxMIAAAdiw Date: Thu, 28 May 2015 11:06:46 +0000 Message-ID: <8BBE948C60307D47AD16B5B5B92A387E32EDAC07@IRSMSX106.ger.corp.intel.com> References: <20150527134524.5f107cac@miho> <5566EFDD.5040209@netinsight.net> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Thu, 28 May 2015 13:41:53 +0200 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] kni: Use utsrelease.h to determine Ubuntu kernel version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2015 11:07:08 -0000 Hi all, Please forgive top reply and bottom disclaimer. Not sure anyway that this email will reach the mailing list, since I did no= t subscribe to it. I am worried about the removal of: cut -d'~' -f1 It was introduced by Pawel in commit 35170c52d0ae33dc30e69bcf681e5a17168bf1= 1e http://dpdk.org/browse/dpdk/commit/lib/librte_eal/linuxapp/kni/Makefile?id= =3D35170c52d0ae33dc30e69bcf681e5a17168bf11e in order to fix the parsing of: 3.11.0-15.25~precise1-generic Not sure what utsrelease.h would contain in this specific case, but removal= of ~precise1-generic is broken with this recent patch. Regards, Patrice -----Original Message----- From: Wodkowski, PawelX = Sent: Thursday, May 28, 2015 12:48 PM To: Simon K=E5gstr=F6m; Zhang, Helin; Alexander Guy; Julien Cretin; Buriez,= Patrice Cc: dev@dpdk.org Subject: RE: [PATCH] kni: Use utsrelease.h to determine Ubuntu kernel versi= on > -----Original Message----- > From: Simon K=E5gstr=F6m [mailto:simon.kagstrom@netinsight.net] > Sent: Thursday, May 28, 2015 12:37 PM > To: Wodkowski, PawelX; Zhang, Helin; Alexander Guy; Julien Cretin; = > Buriez, Patrice > Cc: dev@dpdk.org > Subject: Re: [PATCH] kni: Use utsrelease.h to determine Ubuntu kernel = > version > = > On 2015-05-28 12:05, Wodkowski, PawelX wrote: > >>> > >>> -UBUNTU_KERNEL_CODE :=3D $(shell cut -d' ' -f2 /proc/version_signatur= e | \ > >>> - cut -d'~' -f1 | cut -d- -f1,2 | tr .- $(comm= a)) > >>> +UBUNTU_KERNEL_CODE :=3D $(shell echo `grep UTS_RELEASE > >>> $(RTE_KERNELDIR)/include/generated/utsrelease.h \ > >>> + | cut -d '"' -f2 | cut -d- -f1,2 | tr .- $(comma)`,1) > > > > It is fine for me if it do the job and does not break build on other = > > OS (also other Ubuntu versions especially 12.04 if we still support it). > > Please only check if UTS_RELEASE is available on all Ubuntu versions = > > DPDK > support. > = > From some digging, it appears it entered the kernel tree in 2006 and = > moved to include/generated/ in 2009 so I guess that should be fine for = > DPDK builds? > = > // Simon I also think that it is OK but I also think should check by building you (o= ask someone to do it for you) on those systems not by theory :) -- Pawel Intel Corporation NV/SA Kings Square, Veldkant 31 2550 Kontich RPM (Bruxelles) 0415.497.718. = Citibank, Brussels, account 570/1031255/09 This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). Any review or distribution by others = is strictly prohibited. If you are not the intended recipient, please conta= ct the sender and delete all copies.