From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C686CA00B8; Mon, 28 Oct 2019 02:35:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B742C1BF07; Mon, 28 Oct 2019 02:35:17 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 6AE421BEF9 for <dev@dpdk.org>; Mon, 28 Oct 2019 02:35:16 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Oct 2019 18:35:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,238,1569308400"; d="scan'208";a="203142201" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga006.jf.intel.com with ESMTP; 27 Oct 2019 18:35:15 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 27 Oct 2019 18:35:14 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 27 Oct 2019 18:35:14 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 27 Oct 2019 18:35:14 -0700 Received: from shsmsx106.ccr.corp.intel.com ([169.254.10.248]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.200]) with mapi id 14.03.0439.000; Mon, 28 Oct 2019 09:35:12 +0800 From: "Xu, Ting" <ting.xu@intel.com> To: Thomas Monjalon <thomas@monjalon.net> CC: "dev@dpdk.org" <dev@dpdk.org>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>, "Iremonger, Bernard" <bernard.iremonger@intel.com>, "olivier.matz@6wind.com" <olivier.matz@6wind.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com> Thread-Topic: [dpdk-dev] [PATCH v6] app/testpmd: enable GTP header parse and Tx checksum offload Thread-Index: AQHVi4Z/U55DY+g8v0qzO6+6MBellKdvRxPw Date: Mon, 28 Oct 2019 01:35:11 +0000 Message-ID: <8C448DD570D7CD459EACDF44AB3869D7019324BD@SHSMSX106.ccr.corp.intel.com> References: <20191022122910.53743-1-ting.xu@intel.com> <20191022162636.84909-1-ting.xu@intel.com> <1890292.h76DOOWmZ3@xps> In-Reply-To: <1890292.h76DOOWmZ3@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzE3NjE5M2UtODRkOC00MGMyLTg0ZmEtNWNkMGNkNDA2YWMwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTDlTU2NYaEtwNEREeTZRVFdmRWxRckR1MWhlZ01aYzJxd3c1d0xiblJ0bkJ0TEJzRGpuNFlvemJUMk1CajcxcCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6] app/testpmd: enable GTP header parse and Tx checksum offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Hi, Thomas,=20 Sorry for my mistake about missing meson.build. I have fixed it as well as = others based on your comments. However, I am not quite understand your last reply. Do I still need to send= a new patch now or not? Thanks for your patient help! Best Regards, Ting Xu -----Original Message----- From: Thomas Monjalon <thomas@monjalon.net>=20 Sent: Saturday, October 26, 2019 6:49 AM To: Xu, Ting <ting.xu@intel.com> Cc: dev@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing <jingjin= g.wu@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>; olivier.= matz@6wind.com; Yigit, Ferruh <ferruh.yigit@intel.com> Subject: Re: [dpdk-dev] [PATCH v6] app/testpmd: enable GTP header parse and= Tx checksum offload 22/10/2019 18:26, Ting Xu: > This patch enables testpmd to forward GTP packet in csum fwd mode. > A GTP header structure (without optional fields and extension header)=20 > is defined in new rte_gtp.h. A parser function in testpmd is added. > GTPU and GTPC packets are both supported, with respective UDP=20 > destination port and GTP message type. >=20 > Signed-off-by: Ting Xu <ting.xu@intel.com> >=20 > --- > v6: complete doxygen documentation. > v5: create rte_gtp.h and move GTP header definition to it. > v4: move GTP header definition to rte_ether.h > v3: correct coding style issue. > v2: modify commit log >=20 > depend on patch: lib/mbuf: add GTP tunnel type flag. > --- > app/test-pmd/csumonly.c | 97 +++++++++++++++++++++++++++++++++++---- > doc/api/doxy-api-index.md | 1 + > lib/librte_net/Makefile | 2 +- You missed meson.build in addition of Makefile. > lib/librte_net/rte_gtp.h | 52 +++++++++++++++++++++ > 4 files changed, 141 insertions(+), 11 deletions(-) create mode=20 > 100644 lib/librte_net/rte_gtp.h Does it deserve 2 separate patches? GTP header + testpmd use [...] > --- /dev/null > +++ b/lib/librte_net/rte_gtp.h [...] > + > +#endif /* RTE_GTP_H_ */ > + Please remove this blank line at EOF. Such things are cleaned up sometimes: http://git.dpdk.org/dpdk/commit/?id=3D6f3f0acd95