From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CA8C42526; Wed, 6 Sep 2023 10:15:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45E034029E; Wed, 6 Sep 2023 10:15:20 +0200 (CEST) Received: from smtpbgeu2.qq.com (smtpbgeu2.qq.com [18.194.254.142]) by mails.dpdk.org (Postfix) with ESMTP id BE5804029D for <dev@dpdk.org>; Wed, 6 Sep 2023 10:15:18 +0200 (CEST) X-QQ-mid: bizesmtp77t1693988104tvkof4x3 Received: from LAPTOP96V0OHHN ( [183.81.182.182]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 06 Sep 2023 16:15:03 +0800 (CST) X-QQ-SSF: 00400000000000D0F000000A0000000 X-QQ-FEAT: YHTLUubWl253lZarTA4Q0d9jq6bktiC1N1R2+gNbzUw0mYIu2xLSeFHhHONtj wmbk25jp7kJv0AU9iGlRRbOvD2cxPWkN/BikkTBOmOOg4n4ov2AlmL+m9lFLaAlb1zGo4D0 7YVFf+nrTD/3AXQnLjjHFP6fBWZjYZWdQnio9df91OczovOj0948HN61PnIhdXvGToWUNJn nsXZfpW0EKGlKip+2BvcrDd3cf2qOYloEwh7Usdcwkw/JukMuE4ngQEDBLwd0y6Mdh0bTMV 0Yt+DIGkbOYFHtpv8Oo3vvc+gkv/WKAYocgZ5P2Q85SBtysgIqu4Nfr+0RNaST7AmCgyLtp yMc9BnR993V1HifZ8bdrO3SB8uK3BBpoIZsEMYdWBHctcfaP2ATA1zrvm09/s4wSrj4ifyu X-QQ-GoodBg: 2 X-BIZMAIL-ID: 16742890093281766996 From: "11" <caowenbo@mucse.com> To: "'Ferruh Yigit'" <ferruh.yigit@amd.com>, "'Thomas Monjalon'" <thomas@monjalon.net> Cc: <dev@dpdk.org>, <andrew.rybchenko@oktetlabs.ru>, <yaojun@mucse.com> References: <20230901023050.40893-1-caowenbo@mucse.com> <20230901023050.40893-2-caowenbo@mucse.com> <4241386a-37f9-925b-7e91-dd61e58731ca@amd.com> In-Reply-To: <4241386a-37f9-925b-7e91-dd61e58731ca@amd.com> Subject: RE: [PATCH v6 1/8] net/rnp: add skeleton Date: Wed, 6 Sep 2023 16:15:04 +0800 Message-ID: <8CB549D3AC27C6C4+005b01d9e09a$3e56ed90$bb04c8b0$@mucse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Content-Language: zh-cn Thread-Index: AQI30P9XUj3aWZJ7n+uYhLh06w3v0AG22SC0AvsjYHSvLAGjsA== X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:mucse.com:qybglogicsvrgz:qybglogicsvrgz5a-0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Hi Ferruh, Thanks for your kindly review, please see the below comment. Regards Wenbo=09 > -----Original Message----- > From: Ferruh Yigit <ferruh.yigit@amd.com> > Sent: 2023=E5=B9=B49=E6=9C=885=E6=97=A5 23:35 > To: Wenbo Cao <caowenbo@mucse.com>; Thomas Monjalon > <thomas@monjalon.net> > Cc: dev@dpdk.org; andrew.rybchenko@oktetlabs.ru; yaojun@mucse.com > Subject: Re: [PATCH v6 1/8] net/rnp: add skeleton >=20 > On 9/1/2023 3:30 AM, Wenbo Cao wrote: > > Add Basic PMD library and doc build infrastructure Update = maintainers > > file to claim responsibility. > > > > Signed-off-by: Wenbo Cao <caowenbo@mucse.com> >=20 > <...> >=20 > > diff --git a/doc/guides/nics/rnp.rst b/doc/guides/nics/rnp.rst new > > file mode 100644 index 0000000000..0eb8f2d415 > > --- /dev/null > > +++ b/doc/guides/nics/rnp.rst > > @@ -0,0 +1,38 @@ > > +.. SPADIX-License-Identifier: BSD-3-Clause >=20 > s/SPADIX/SPDX/ I get it. >=20 > > + Copyright(c) 2023 Mucse IC Design Ltd. > > + > > +RNP Poll Mode driver > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > + > > +The RNP ETHDEV PMD (**librte_net_rnp**) provides poll mode ethdev > > +driver support for the inbuilt network device found in the **Mucse > > +RNP** > > + > > +Prerequisites > > +------------- > > +More information can be found at `Mucse, Official Website > > +<https://mucse.com/productDetail>`_. > > + > > +Supported Chipsets and NICs > > +--------------------------- > > + > > +- MUCSE Ethernet Controller N10 Series for 10GbE or 40GbE = (Dual-port) > > + >=20 > Can you provide a link for the product, and if there is an English = version it can > reach to more people? >=20 For English version, it will be coming soon in a month about. we will provide a html link of pdf for the time. > > +Limitations or Known issues > > +--------------------------- > > + > > +Build with ICC is not supported yet. > > >=20 > I know this is documented in other PMDs too, but at this stage ICC is = supported > with best effort, and I am not sure if anybody testing with it, so I = think it is OK to > drop this as limitation. >=20 >=20 We have never test the code use icc-compile-tool, just use = gcc-compile-tool, I'm going to try to test it with icc :) > > +BSD are not supported yet. > > >=20 > FreeBSD is not supported. > Also Windows seems not supported, you may document that too. >=20 > > + > > +CRC stripping > > +~~~~~~~~~~~~~ > > + > > +The RNP Soc family Nic strip the CRC for every packets coming into > > +the >=20 > s/Soc/SoC/ > s/Nic/NIC/ >=20 For this spell issue, is there exist tool I can use to check it ? Thanks a lot. > > +host interface irrespective of the offload configuration. > > +When you want to disable CRC_OFFLOAD the operate will influence the > rxCksum offload. > > >=20 > I didn't understand the second sentences, from first one I understand > 'RTE_ETH_RX_OFFLOAD_KEEP_CRC' is not supported by the PMD, but can you > please clarify more? >=20 >=20 disable CRC_OFFLOAD will trigger SOC bug, which causing bad-cksum bit in rx description always be 1 ,even package = has no cksum error. > > + > > +VLAN Strip/Filter > > +~~~~~~~~~~~~~~~~~ > > + > > +For VLAN strip/filter, RNP just support vlan is CVLAN(0x8100).If = the > > +outvlan type is SVLAN(0X88a8) >=20 > s/vlan/VLAN/ > Please put space, " ", after '.' in documentation. Same comment for = all document. >=20 I forgot the format before. > > +VLAN filter or strip will not effort for this packet.It will bypass > > +filter to the host default queue, whatever the other filter rule = is. > > >=20 > VLAN strip/filter doesn't work for double-tag (QinQ), it only works = for single VLAN > tag, is this correct? If so can you please update above sentences to = clarify this? >=20 For VLAN strip/filter, if the VLAN type have (0x88a8), the feature of = hardware isn't effect.