From: "Wiles, Keith" <keith.wiles@intel.com>
To: Arnon Warshavsky <arnon@qwilt.com>,
Panu Matilainen <pmatilai@redhat.com>
Cc: Neil Horman <nhorman@tuxdriver.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>,
Yuanhan Liu <yuanhan.liu@linux.intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Tan, Jianfeng" <jianfeng.tan@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Christian Ehrhardt <christian.ehrhardt@canonical.com>,
Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [RFC] Yet another option for DPDK options
Date: Fri, 3 Jun 2016 16:04:14 +0000 [thread overview]
Message-ID: <8CE01283-1E89-4302-BE7D-486975B43EF6@intel.com> (raw)
In-Reply-To: <CAKy9EB3ca+nufggexRogY3TOU=LMdf1dRFJSPxhmdrdyW2fc6A@mail.gmail.com>
Sorry, I deleted all of the text as it was getting a bit long.
Here are my thoughts as of now, which is a combination of many suggestions I read from everyone’s emails. I hope this is not too hard to understand.
- Break out the current command line options out of the DPDK common code and move into a new lib.
- At this point I was thinking of keeping the rte_eal_init(args, argv) API and just have it pass the args/argv to the new lib to create the data storage.
- Maybe move the rte_eal_init() API to the new lib or keep it in the common eal code. Do not want to go hog wild.
- The rte_eal_init(args, argv) would then call to the new API rte_eal_initialize(void), which in turn queries the data storage. (still thinking here)
- The example apps args needs to be passed to the examples as is for now, then we can convert them one at a time if needed.
- I would like to keep the storage of the data separate from the file parser as they can use the ‘set’ routines to build the data storage up.
- Keeping them split allows for new parsers to be created, while keeping the data storage from changing.
- The rte_cfg code could be modified to use the new configuration if someone wants to take on that task ☺
- Next is the data storage and how we can access the data in a clean simple way.
- I want to have some simple level of hierarchy in the data.
- Having a string containing at least two levels “primary:secondary”.
- Primary string is something like “EAL” or “Pktgen” or “testpmd” to divide the data storage into logical major groups.
- The primary allows us to have groups and then we can have common secondary strings in different groups if needed.
- Secondary string can be whatever the developer of that group would like e.g. simple “EAL:foobar”, two levels “testpmd:foo.bar”
- The secondary string is treated as a single string if it has a hierarchy or not, but referencing a single value in the data storage.
- Key value pairs (KVP) or a hashmap data store.
- The key here is the whole string “EAL:foobar” not just “foobar” secondary string.
- If we want to have the two split I am ok with that as well meaning the API would be:
rte_map_get(mapObj, “EAL”, “foo.bar”);
rte_map_set(mapObj, “EAL”, “foo.bar”, value);
- Have the primary as a different section in the data store, would allow for dumping that section maybe easier, not sure.
- I am leaning toward
- Not going to try splitting up the string or parse it as it is up to the developer to make it unique in the data store.
- Use a code design to make the strings simple to use without having typos be a problem.
- Not sure what the design is yet, but I do not want to have to concat two string or split strings in the code.
This is as far as I have gotten and got tired of typing ☺
I hope this will satisfy most everyone’s needs for now.
Regards,
Keith
next prev parent reply other threads:[~2016-06-03 16:05 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 15:00 Wiles, Keith
2016-06-01 15:46 ` Matthew Hall
2016-06-01 16:08 ` Wiles, Keith
2016-06-01 15:58 ` Jay Rolette
2016-06-01 16:18 ` Bruce Richardson
2016-06-01 16:21 ` Arnon Warshavsky
2016-06-01 18:13 ` Wiles, Keith
2016-06-01 18:31 ` Stephen Hemminger
2016-06-03 10:07 ` Yerden Zhumabekov
2016-06-01 18:51 ` Thomas Monjalon
2016-06-02 9:19 ` Marc
2016-06-02 7:56 ` Yuanhan Liu
2016-06-02 10:41 ` Neil Horman
2016-06-02 13:19 ` Thomas Monjalon
2016-06-02 13:53 ` Wiles, Keith
2016-06-02 17:11 ` Neil Horman
2016-06-02 19:33 ` Wiles, Keith
2016-06-02 19:41 ` Wiles, Keith
2016-06-02 20:08 ` Neil Horman
2016-06-02 20:53 ` Matthew Hall
2016-06-02 22:34 ` Neil Horman
2016-06-03 2:17 ` Matthew Hall
2016-06-03 9:57 ` Bruce Richardson
2016-06-03 10:06 ` Bruce Richardson
2016-06-03 12:03 ` Neil Horman
2016-06-03 10:29 ` Bruce Richardson
2016-06-03 11:01 ` Bruce Richardson
2016-06-03 11:50 ` Neil Horman
2016-06-03 12:01 ` Arnon Warshavsky
2016-06-03 12:53 ` Panu Matilainen
2016-06-03 14:31 ` Arnon Warshavsky
2016-06-03 16:04 ` Wiles, Keith [this message]
2016-06-03 16:10 ` Wiles, Keith
2016-06-03 17:44 ` Neil Horman
2016-06-03 18:29 ` Wiles, Keith
2016-06-03 18:38 ` Neil Horman
2016-06-03 18:52 ` Arnon Warshavsky
2016-06-03 19:00 ` Wiles, Keith
2016-06-03 19:07 ` Wiles, Keith
2016-06-03 19:18 ` Neil Horman
2016-06-03 19:23 ` Wiles, Keith
2016-06-03 19:28 ` Arnon Warshavsky
2016-06-03 21:42 ` Matthew Hall
2016-06-03 21:41 ` Matthew Hall
2016-06-05 0:19 ` Neil Horman
2016-06-03 21:40 ` Matthew Hall
2016-06-03 21:38 ` Matthew Hall
2016-06-03 12:14 ` Panu Matilainen
2016-06-02 20:51 ` Matthew Hall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CE01283-1E89-4302-BE7D-486975B43EF6@intel.com \
--to=keith.wiles@intel.com \
--cc=arnon@qwilt.com \
--cc=bruce.richardson@intel.com \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=nhorman@tuxdriver.com \
--cc=olivier.matz@6wind.com \
--cc=pmatilai@redhat.com \
--cc=stephen@networkplumber.org \
--cc=thomas.monjalon@6wind.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).