Re: [dpdk-dev] [PATCH v5 2/4] doc: Corrected info for tx_checksum set mask function, in testpmd UG

Re: [dpdk-dev] [PATCH v5 2/4] doc: Corrected info for tx_checksum set mask function, in testpmd UG

[Iremonger, Bernard]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Monday, December 1, 2014 11:41 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v5 2/4] doc: Corrected info for tx_checksum set mask function, in
> testpmd UG
> 
> tx_checksum set function does not use bitmask anymore, but strings
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>

 I have applied the patch to my tree next/dpdk-doc.

[dpdk-dev] [PATCH v4 0/4] Updated testpmd UG due to latest changes in the app

[Pablo de Lara]

TestPMD app has been added new commands, which should be reflected
in the user guide. Also, this patchset fixes several typos and
changes the location of the description of some commands.

Changes in v4:

Fixed wrong patchset title

Changes in v3:

Added new missing existing command "show port rss reta"
Added new commands from TSO support patchset
Modified info for command "tx_cksum set" command

Changes in v2:

Title underline in added commands was too short.

Pablo de Lara (4):
  doc: Added new commands in testpmd UG
  doc: Corrected info for tx_checksum set mask function, in testpmd UG
  doc: Moved commands in testpmd UG to match testpmd command help order
  doc: Various document fixes in testpmd UG

 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 1128 ++++++++++++++-------------
 1 files changed, 605 insertions(+), 523 deletions(-)

-- 
1.7.4.1

[dpdk-dev] [PATCH v5 0/4] Updated testpmd UG due to latest changes in the app

[Pablo de Lara]

TestPMD app has been added new commands, which should be reflected
in the user guide. Also, this patchset fixes several typos and
changes the location of the description of some commands.

Changes in v5:

Removed trailing whitespaces

Changes in v4:

Fixed wrong patchset title

Changes in v3:

Added new missing existing command "show port rss reta"
Added new commands from TSO support patchset
Modified info for command "tx_cksum set" command

Changes in v2:

Title underline in added commands was too short.

Pablo de Lara (4):
  doc: Added new commands in testpmd UG
  doc: Corrected info for tx_checksum set mask function, in testpmd UG
  doc: Moved commands in testpmd UG to match testpmd command help order
  doc: Various document fixes in testpmd UG

 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 1127 ++++++++++++++-------------
 1 files changed, 604 insertions(+), 523 deletions(-)

-- 
1.7.4.1

[dpdk-dev] [PATCH v5 2/4] doc: Corrected info for tx_checksum set mask function, in testpmd UG

[Pablo de Lara]

tx_checksum set function does not use bitmask anymore, but strings

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |   21 ++++++++-------------
 1 files changed, 8 insertions(+), 13 deletions(-)

diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index c010577..975929e 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -516,22 +516,17 @@ Disable hardware insertion of a VLAN header in packets sent on a port:
 
 tx_vlan reset (port_id)
 
-tx_checksum set mask
-~~~~~~~~~~~~~~~~~~~~
-
-Enable hardware insertion of checksum offload with a 4-bit mask, 0x0 - 0xF, in packets sent on a port:
-
-tx_checksum set (mask) (port_id)
-
-The bits in the mask are:
-
-bit 0 - if set insert ip checksum offload
+tx_checksum set
+~~~~~~~~~~~~~~~
 
-bit 1 - if set insert udp checksum offload
+Select hardware or software calculation of the checksum when
+transmitting a packet using the csum forward engine:
 
-bit 2 - if set insert tcp checksum offload
+tx_cksum set (ip|udp|tcp|sctp|vxlan)
 
-bit 3 - if set insert sctp checksum offload
+ip|udp|tcp|sctp always concern the inner layer.
+vxlan concerns the outer IP and UDP layer (in case the packet
+is recognized as a vxlan packet by the forward engine)
 
 .. note::
 
-- 
1.7.4.1