From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 3A2F95934 for ; Thu, 22 Jan 2015 12:15:27 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 22 Jan 2015 03:15:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,448,1418112000"; d="scan'208";a="515949558" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga003.jf.intel.com with ESMTP; 22 Jan 2015 03:08:39 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.64]) by IRSMSX101.ger.corp.intel.com ([169.254.1.245]) with mapi id 14.03.0195.001; Thu, 22 Jan 2015 11:15:22 +0000 From: "Iremonger, Bernard" To: "Wu, Jingjing" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] doc: commands changed in testpmd_funcs for ethertype filter Thread-Index: AQHQNeAoZdiagfViX0iImUajX7aY8JzL/LOg Date: Thu, 22 Jan 2015 11:15:22 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C2049D990E@IRSMSX108.ger.corp.intel.com> References: <1421888956-3020-1-git-send-email-jingjing.wu@intel.com> In-Reply-To: <1421888956-3020-1-git-send-email-jingjing.wu@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: commands changed in testpmd_funcs for ethertype filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jan 2015 11:15:27 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jingjing Wu > Sent: Thursday, January 22, 2015 1:09 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] doc: commands changed in testpmd_funcs for et= hertype filter >=20 > new commands for ethertype filter > - ethertype_filter (port_id) (add|del) (mac_addr|mac_ignr) > (mac_address) ethertype (ether_type) (drop|fwd) queue (queue_id) >=20 > Signed-off-by: Jingjing Wu > --- > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 51 +++++++----------------= ------ > 1 file changed, 12 insertions(+), 39 deletions(-) >=20 > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > index be935c2..218835a 100644 > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -1392,61 +1392,34 @@ Filter Functions >=20 > This section details the available filter functions that are available. >=20 > -add_ethertype_filter > +ethertype_filter > ~~~~~~~~~~~~~~~~~~~~ >=20 > -Add a L2 Ethertype filter, which identify packets by their L2 Ethertype = mainly assign them to a receive > queue. > +Add or delete a L2 Ethertype filter, which identify packets by their L2 = Ethertype mainly assign them to > a receive queue. >=20 > -add_ethertype_filter (port_id) ethertype (eth_value) priority (enable|di= sable) (pri_value) queue > (queue_id) index (idx) > +ethertype_filter (port_id) (add|del) (mac_addr|mac_ignr) (mac_address) e= thertype (ether_type) > (drop|fwd) queue (queue_id) >=20 > The available information parameters are: >=20 > * port_id: the port which the Ethertype filter assigned on. >=20 > -* eth_value: the EtherType value want to match, > - for example 0x0806 for ARP packet. 0x0800 (IPv4) and 0x86DD (IPv6) a= re invalid. > - > -* enable: user priority participates in the match. > - > -* disable: user priority doesn't participate in the match. > - > -* pri_value: user priority value that want to match. > - > -* queue_id : The receive queue associated with this EtherType filter > +* mac_addr: compare destination mac address. >=20 > -* index: the index of this EtherType filter > +* mac_ignr: ignore destination mac address match. >=20 > -Example: > - > -.. code-block:: console > +* mac_address: destination mac address to match. >=20 > - testpmd> add_ethertype_filter 0 ethertype 0x0806 priority disable 0 = queue 3 index 0 > - Assign ARP packet to receive queue 3 > - > -remove_ethertype_filter > -~~~~~~~~~~~~~~~~~~~~~~~ > - > -Remove a L2 Ethertype filter > - > -remove_ethertype_filter (port_id) index (idx) > - > -get_ethertype_filter > -~~~~~~~~~~~~~~~~~~~~ > - > -Get and display a L2 Ethertype filter > +* ether_type: the EtherType value want to match, > + for example 0x0806 for ARP packet. 0x0800 (IPv4) and 0x86DD (IPv6) a= re invalid. >=20 > -get_ethertype_filter (port_id) index (idx) > +* queue_id : The receive queue associated with this EtherType filter. = It is meaningless when > deleting or dropping. >=20 > -Example: > +Example, to add/remove an ethertype filter rule: >=20 > .. code-block:: console >=20 > - testpmd> get_ethertype_filter 0 index 0 > - > - filter[0]: > - ethertype: 0x0806 > - priority: disable, 0 > - queue: 3 > + testpmd> ethertype_filter 0 add mac_ignr ethertype 0x0806 fwd queue = 3 > + testpmd> ethertype_filter 0 del mac_ignr ethertype 0x0806 fwd queue = 3 Hi Jingjing, There is a duplicate line here. I have applied the patch and checked the HTML output (applies and builds cl= eanly). Regards, Bernard >=20 > add_2tuple_filter > ~~~~~~~~~~~~~~~~~ > -- > 1.9.3