From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <bernard.iremonger@intel.com> Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 73453B469 for <dev@dpdk.org>; Wed, 18 Feb 2015 13:35:27 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 18 Feb 2015 04:33:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,512,1418112000"; d="scan'208";a="653778550" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga001.jf.intel.com with ESMTP; 18 Feb 2015 04:33:37 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.218]) by IRSMSX109.ger.corp.intel.com ([169.254.13.103]) with mapi id 14.03.0195.001; Wed, 18 Feb 2015 12:33:36 +0000 From: "Iremonger, Bernard" <bernard.iremonger@intel.com> To: Tetsuya Mukawa <mukawa@igel.co.jp>, "Richardson, Bruce" <bruce.richardson@intel.com>, Thomas Monjalon <thomas.monjalon@6wind.com> Thread-Topic: [dpdk-dev] [PATCH v8 03/14] eal/pci, ethdev: Remove assumption that port will not be detached Thread-Index: AQHQS2FLhGsLkHpns0GuaxZs+jytHZz2LYeAgAAPQgCAABjiAA== Date: Wed, 18 Feb 2015 12:33:35 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C2049EACCC@IRSMSX108.ger.corp.intel.com> References: <1423470639-15744-2-git-send-email-mukawa@igel.co.jp> <54E3F0F0.1030102@igel.co.jp> <54E42CCD.6020900@igel.co.jp> <3870939.2syNine7YF@xps13> <20150218100328.GB14728@bricha3-MOBL3> <54E4703E.1010904@igel.co.jp> In-Reply-To: <54E4703E.1010904@igel.co.jp> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" <dev@dpdk.org>, Neil Horman <nhroman@tuxdriver.com> Subject: Re: [dpdk-dev] [PATCH v8 03/14] eal/pci, ethdev: Remove assumption that port will not be detached X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 18 Feb 2015 12:35:27 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tetsuya Mukawa > Sent: Wednesday, February 18, 2015 10:58 AM > To: Richardson, Bruce; Thomas Monjalon > Cc: dev@dpdk.org; Neil Horman > Subject: Re: [dpdk-dev] [PATCH v8 03/14] eal/pci, ethdev: Remove assumpti= on that port will not be > detached >=20 > On 2015/02/18 19:03, Bruce Richardson wrote: > > On Wed, Feb 18, 2015 at 10:57:25AM +0100, Thomas Monjalon wrote: > >> 2015-02-18 15:10, Tetsuya Mukawa: > >>> On 2015/02/18 10:54, Tetsuya Mukawa wrote: > >>>> On 2015/02/18 9:31, Thomas Monjalon wrote: > >>>>> 2015-02-17 15:14, Tetsuya Mukawa: > >>>>>> On 2015/02/17 9:36, Thomas Monjalon wrote: > >>>>>>> 2015-02-16 13:14, Tetsuya Mukawa: > >>>>>>> Is uint8_t sill a good size for hotpluggable virtual device ids? > >>>>>> I am not sure it's enough, but uint8_t is widely used in "rte_ethd= ev.c" > >>>>>> as port id. > >>>>>> If someone reports it doesn't enough, I guess it will be the time > >>>>>> to write a patch to change all uint_8 in one patch. > >>>>> It's a big ABI breakage. So if we feel it's going to be required, > >>>>> it's better to do it now in 2.0 release I think. > >>>>> > >>>>> Any opinion? > >>>>> > >>>> Hi Thomas, > >>>> > >>>> I agree with it. > >>>> I will add an one more patch to change uint8_t to uint16_t. > >>>> > >>>> Thanks, > >>>> Tetsuya > >>>> > >>> Hi Thomas, > >>> > >>> Could I make sure. > >>> After changing uint8_t to uint16_t in "rte_ethdev.[ch]", must I also > >>> need to change other applications and libraries that call ethdev APIs= ? > >>> If so, I would not finish it by 23rd. > >>> > >>> I've counted how many lines call ethdev APIs that are related to port= _id. > >>> Could you please check an attached file? > >>> It's over 1200 lines. Probably to fix one of caller, I will need to > >>> check how port_id is used, and fix more related lines. So probably > >>> thousands lines may need to be fixed. > >>> > >>> When is deadline for fixing this changing? > >>> Also, if you have a good idea to fix it easier, could you please let > >>> me know? > >> It was an open question. > >> If everybody is fine with 255 ports maximum, let's keep it as is. > >> > > I think we are probably ok for now (and forseeable future) with 255 max= . > > > > However, if we did change it, I agree that in 2.0 is a very good time t= o do so. > > Since we are expanding the field, rather than shrinking it, I don't > > see why we can't just make the change at the ethdev level (and in libs > > API) in 2.0 and then in later releases (e.g. 2.1) update the apps and > > examples to match. That way the ABI stays the same from 2.0 onwards, > > and we don't have a huge amount of churn changing it everywhere late in= the 2.0 release cycle. >=20 > Hi Bruce, >=20 > Could you please check my RFC patch I will send soon? > I wrote the patch like below. >=20 > 1. Copy header file like below. > $ cp lib/librte_ether/rte_ethdev.h lib/librte_ether/rte_ethdev_internal.h > 2. Change "rte_ethdev.c" to include "rte_ethdev_internal.h" > 3. Change type of port id in "rte_ethdev.c" and "rte_ethdev_internal.h". >=20 > If the patch is OK, I wll send it with hotplug patches. >=20 > Thanks, > Tetsuya >=20 >=20 > > /Bruce >=20 Hi Tetsuya, After this change there will be two header files with a lot of the same inf= ormation. lib/librte_ether/rte_ethdev.h lib/librte_ether/rte_ethdev_internal.h I don't think this is a good idea for maintenance in the future. If 255 is ok for the foreseeable future, why change it now. Regards, Bernard. =20