Re: [dpdk-dev] [PATCH v2 00/15] eal: Port Hotplug support for BSD

["Iremonger, Bernard" <bernard.iremonger@intel.com>]

> -----Original Message-----
> From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp]
> Sent: Thursday, March 12, 2015 10:18 AM
> To: dev@dpdk.org
> Cc: Iremonger, Bernard; Richardson, Bruce; Tetsuya Mukawa
> Subject: [PATCH v2 00/15] eal: Port Hotplug support for BSD
> 
> This patch series adds port hotplug support to BSD.
> Also, the patches consolidates pci uio functions of linuxapp and bsdapp.
> 
> Following patches cleanup pci uio code to consolidate later.
>   eal: Fix cording style of eal_pci.c and eal_pci_uio.c
>   eal: Close file descriptor of uio configuration
>   eal: Fix memory leak of pci_uio_map_resource()
>   eal: Fix needless incrementation of pci_map_addr
>   eal/bsdapp: Change names of pci related data structure
>   eal: Use map_idx in pci_uio_map_resource() of bsdapp to work same as
>     linuxapp
>   eal: Fix interface of pci_map_resource() of bsdapp
>   eal: Add pci_uio_alloc_uio_resource()
>   eal: Add pci_uio_map_uio_resource_by_index()
> 
Hi Tetsuya,

It might be better to split this patchset into two patch sets, 
A cleanup patchset and a consolidation patchset. 
It would make reviewing easier.

Regards,

Bernard.


> Following patches are actually for functions consolidation.
>   eal: Consolidate pci_map and mapped_pci_resource of linuxapp and
>     bsdapp
>   eal: Consolidate rte_eal_pci_probe/close_one_driver() of linuxapp and
>     bsdapp
>   eal: Consolidate pci_map/unmap_device() of linuxapp and bsdapp
>   eal: Consolidate pci_map/unmap_resource() of linuxapp and bsdapp
>   eal: Consolidate pci uio functions of linuxapp and bsdapp
> 
> The last patch removes CONFIG_RTE_LIBRTE_EAL_HOTPLUG configuration from Linux and BSD.
> And port hotplug is enabled as default with both Linux and BSD.
>   eal: Enable Port Hotplug as default in Linux and BSD
> 
> 
> PATCH v2 changes
>  - Consolidate pci uio functions of linuxapp and bsdapp.
> 
> 
> Tetsuya Mukawa (15):
>   eal: Fix cording style of eal_pci.c and eal_pci_uio.c
>   eal: Close file descriptor of uio configuration
>   eal: Fix memory leak of pci_uio_map_resource()
>   eal: Fix needless incrementation of pci_map_addr
>   eal/bsdapp: Change names of pci related data structure
>   eal: Use map_idx in pci_uio_map_resource() of bsdapp to work same as
>     linuxapp
>   eal: Fix interface of pci_map_resource() of bsdapp
>   eal: Add pci_uio_alloc_uio_resource()
>   eal: Add pci_uio_map_uio_resource_by_index()
>   eal: Consolidate pci_map and mapped_pci_resource of linuxapp and
>     bsdapp
>   eal: Consolidate rte_eal_pci_probe/close_one_driver() of linuxapp and
>     bsdapp
>   eal: Consolidate pci_map/unmap_device() of linuxapp and bsdapp
>   eal: Consolidate pci_map/unmap_resource() of linuxapp and bsdapp
>   eal: Consolidate pci uio functions of linuxapp and bsdapp
>   eal: Enable Port Hotplug as default in Linux and BSD
> 
>  config/common_bsdapp                               |   6 -
>  config/common_linuxapp                             |   5 -
>  lib/librte_eal/bsdapp/eal/Makefile                 |   1 +
>  lib/librte_eal/bsdapp/eal/eal_pci.c                | 292 ++++++---------------
>  .../bsdapp/eal/include/exec-env/rte_interrupts.h   |   1 +
>  lib/librte_eal/bsdapp/eal/rte_eal_version.map      |   6 +
>  lib/librte_eal/common/eal_common_dev.c             |   2 -
>  lib/librte_eal/common/eal_common_pci.c             | 234 ++++++++++++++++-
>  lib/librte_eal/common/eal_common_pci_uio.c         | 224 ++++++++++++++++
>  lib/librte_eal/common/eal_private.h                |  57 +++-
>  lib/librte_eal/common/include/rte_pci.h            |  42 ++-
>  lib/librte_eal/linuxapp/eal/Makefile               |   1 +
>  lib/librte_eal/linuxapp/eal/eal_pci.c              | 236 +----------------
>  lib/librte_eal/linuxapp/eal/eal_pci_init.h         |  39 +--
>  lib/librte_eal/linuxapp/eal/eal_pci_uio.c          | 263 +++++--------------
>  lib/librte_ether/rte_ethdev.c                      |  22 +-
>  16 files changed, 702 insertions(+), 729 deletions(-)  create mode 100644
> lib/librte_eal/common/eal_common_pci_uio.c
> 
> --
> 1.9.1