From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 16256181 for ; Fri, 13 Mar 2015 12:46:32 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 13 Mar 2015 04:44:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,394,1422950400"; d="scan'208";a="664771156" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga001.jf.intel.com with ESMTP; 13 Mar 2015 04:46:31 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.218]) by IRSMSX107.ger.corp.intel.com ([169.254.10.35]) with mapi id 14.03.0195.001; Fri, 13 Mar 2015 11:46:30 +0000 From: "Iremonger, Bernard" To: Tetsuya Mukawa , "dev@dpdk.org" Thread-Topic: [PATCH v2 00/15] eal: Port Hotplug support for BSD Thread-Index: AQHQXK3l87XJ7z30aE6U+FzXGE8cK50aTKCQ Date: Fri, 13 Mar 2015 11:46:29 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C2049F2891@IRSMSX108.ger.corp.intel.com> References: <1425438703-18895-1-git-send-email-mukawa@igel.co.jp> <1426155474-1596-1-git-send-email-mukawa@igel.co.jp> In-Reply-To: <1426155474-1596-1-git-send-email-mukawa@igel.co.jp> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 00/15] eal: Port Hotplug support for BSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Mar 2015 11:46:33 -0000 > -----Original Message----- > From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp] > Sent: Thursday, March 12, 2015 10:18 AM > To: dev@dpdk.org > Cc: Iremonger, Bernard; Richardson, Bruce; Tetsuya Mukawa > Subject: [PATCH v2 00/15] eal: Port Hotplug support for BSD >=20 > This patch series adds port hotplug support to BSD. > Also, the patches consolidates pci uio functions of linuxapp and bsdapp. >=20 > Following patches cleanup pci uio code to consolidate later. > eal: Fix cording style of eal_pci.c and eal_pci_uio.c > eal: Close file descriptor of uio configuration > eal: Fix memory leak of pci_uio_map_resource() > eal: Fix needless incrementation of pci_map_addr > eal/bsdapp: Change names of pci related data structure > eal: Use map_idx in pci_uio_map_resource() of bsdapp to work same as > linuxapp > eal: Fix interface of pci_map_resource() of bsdapp > eal: Add pci_uio_alloc_uio_resource() > eal: Add pci_uio_map_uio_resource_by_index() >=20 Hi Tetsuya, It might be better to split this patchset into two patch sets,=20 A cleanup patchset and a consolidation patchset.=20 It would make reviewing easier. Regards, Bernard. > Following patches are actually for functions consolidation. > eal: Consolidate pci_map and mapped_pci_resource of linuxapp and > bsdapp > eal: Consolidate rte_eal_pci_probe/close_one_driver() of linuxapp and > bsdapp > eal: Consolidate pci_map/unmap_device() of linuxapp and bsdapp > eal: Consolidate pci_map/unmap_resource() of linuxapp and bsdapp > eal: Consolidate pci uio functions of linuxapp and bsdapp >=20 > The last patch removes CONFIG_RTE_LIBRTE_EAL_HOTPLUG configuration from L= inux and BSD. > And port hotplug is enabled as default with both Linux and BSD. > eal: Enable Port Hotplug as default in Linux and BSD >=20 >=20 > PATCH v2 changes > - Consolidate pci uio functions of linuxapp and bsdapp. >=20 >=20 > Tetsuya Mukawa (15): > eal: Fix cording style of eal_pci.c and eal_pci_uio.c > eal: Close file descriptor of uio configuration > eal: Fix memory leak of pci_uio_map_resource() > eal: Fix needless incrementation of pci_map_addr > eal/bsdapp: Change names of pci related data structure > eal: Use map_idx in pci_uio_map_resource() of bsdapp to work same as > linuxapp > eal: Fix interface of pci_map_resource() of bsdapp > eal: Add pci_uio_alloc_uio_resource() > eal: Add pci_uio_map_uio_resource_by_index() > eal: Consolidate pci_map and mapped_pci_resource of linuxapp and > bsdapp > eal: Consolidate rte_eal_pci_probe/close_one_driver() of linuxapp and > bsdapp > eal: Consolidate pci_map/unmap_device() of linuxapp and bsdapp > eal: Consolidate pci_map/unmap_resource() of linuxapp and bsdapp > eal: Consolidate pci uio functions of linuxapp and bsdapp > eal: Enable Port Hotplug as default in Linux and BSD >=20 > config/common_bsdapp | 6 - > config/common_linuxapp | 5 - > lib/librte_eal/bsdapp/eal/Makefile | 1 + > lib/librte_eal/bsdapp/eal/eal_pci.c | 292 ++++++---------= ------ > .../bsdapp/eal/include/exec-env/rte_interrupts.h | 1 + > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 6 + > lib/librte_eal/common/eal_common_dev.c | 2 - > lib/librte_eal/common/eal_common_pci.c | 234 +++++++++++++++= +- > lib/librte_eal/common/eal_common_pci_uio.c | 224 +++++++++++++++= + > lib/librte_eal/common/eal_private.h | 57 +++- > lib/librte_eal/common/include/rte_pci.h | 42 ++- > lib/librte_eal/linuxapp/eal/Makefile | 1 + > lib/librte_eal/linuxapp/eal/eal_pci.c | 236 +--------------= -- > lib/librte_eal/linuxapp/eal/eal_pci_init.h | 39 +-- > lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 263 +++++----------= ---- > lib/librte_ether/rte_ethdev.c | 22 +- > 16 files changed, 702 insertions(+), 729 deletions(-) create mode 10064= 4 > lib/librte_eal/common/eal_common_pci_uio.c >=20 > -- > 1.9.1