From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 2128037A4 for ; Thu, 19 Mar 2015 12:41:11 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 19 Mar 2015 04:41:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,429,1422950400"; d="scan'208";a="667484994" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga001.jf.intel.com with ESMTP; 19 Mar 2015 04:41:09 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.218]) by IRSMSX103.ger.corp.intel.com ([169.254.3.247]) with mapi id 14.03.0195.001; Thu, 19 Mar 2015 11:41:09 +0000 From: "Iremonger, Bernard" To: Tetsuya Mukawa , "dev@dpdk.org" Thread-Topic: [PATCH v2 15/15] eal: Enable Port Hotplug as default in Linux and BSD Thread-Index: AQHQXK3xS2Ck94QQiECp+lvYDTekkJ0ai5GAgAXOHICAA19IAA== Date: Thu, 19 Mar 2015 11:41:07 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C2049F3AB5@IRSMSX108.ger.corp.intel.com> References: <1425438703-18895-1-git-send-email-mukawa@igel.co.jp> <1426155474-1596-1-git-send-email-mukawa@igel.co.jp> <1426155474-1596-16-git-send-email-mukawa@igel.co.jp> <8CEF83825BEC744B83065625E567D7C2049F2A45@IRSMSX108.ger.corp.intel.com> <5507E0EF.6040307@igel.co.jp> In-Reply-To: <5507E0EF.6040307@igel.co.jp> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 15/15] eal: Enable Port Hotplug as default in Linux and BSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Mar 2015 11:41:12 -0000 > -----Original Message----- > From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp] > Sent: Tuesday, March 17, 2015 8:08 AM > To: Iremonger, Bernard; dev@dpdk.org > Cc: Richardson, Bruce > Subject: Re: [PATCH v2 15/15] eal: Enable Port Hotplug as default in Linu= x and BSD >=20 > On 2015/03/14 0:47, Iremonger, Bernard wrote: > > > >> -----Original Message----- > >> From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp] > >> Sent: Thursday, March 12, 2015 10:18 AM > >> To: dev@dpdk.org > >> Cc: Iremonger, Bernard; Richardson, Bruce; Tetsuya Mukawa > >> Subject: [PATCH v2 15/15] eal: Enable Port Hotplug as default in > >> Linux and BSD > >> > >> This patch removes CONFIG_RTE_LIBRTE_EAL_HOTPLUG option, and enables > >> it as default in both Linux and BSD. > > Hi Tetsuya, > > > > This patch should probably be split with the config changes as the firs= t patch of this patch set. > > The #ifdef RTE_LIBRTE_EAL_HOTPLUG changes should be no longer necessary= as they will have > been taken care of in the earlier patches (v2-11, v2-12, v2-13). > > Maybe the /lib/librte_eal/bsdapp/eal/rte_eal_version.map changes could= be moved to one of the > earlier bsd patches? >=20 > Hi Bernard, >=20 > Could I make it sure your suggestion? > Did you mean that hotplug support for linuxapp and bsdapp should be enabl= ed at first of consolidation > patches? >=20 > It seems I can remove "#ifdef RTE_LIBRTE_EAL_HOTPLUG" together with below= patches. > - v2-11 > - v2-12 > - v2-13 > (Probably this will clean up the last patch a bit.) >=20 > But I cannot enable hotplug support at the first of consolidation patches= , because bsdapp doesn't > have some hotplug implementation at the first. > (Actually, functions related with detach() are only exist in linuxapp at = the first.) All related functions > are moved to common while patch set, then bsdapp can support hotplug. >=20 > I will clean up the last patch as much as possible, then submit again. > Is it okay for this patch? >=20 > Regards, > Tetsuya >=20 Hi Tetsuya, Ok, clean up as much as possible and then submit again as v3. Regards, Bernard.