From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 52E493784 for ; Tue, 21 Apr 2015 15:15:54 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP; 21 Apr 2015 06:15:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,616,1422950400"; d="scan'208";a="698554721" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga001.fm.intel.com with ESMTP; 21 Apr 2015 06:15:52 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.216]) by irsmsx105.ger.corp.intel.com ([169.254.7.178]) with mapi id 14.03.0224.002; Tue, 21 Apr 2015 14:15:51 +0100 From: "Iremonger, Bernard" To: Tetsuya Mukawa , "dev@dpdk.org" Thread-Topic: [PATCH v3 0/5] Clean up pci uio implementations Thread-Index: AQHQaGmfBcNYV6iaoE6uf0ngsXhmMJ1XmZLQ Date: Tue, 21 Apr 2015 13:15:50 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C204A0FF82@IRSMSX108.ger.corp.intel.com> References: <1426584645-28828-7-git-send-email-mukawa@igel.co.jp> <1427445553-3151-1-git-send-email-mukawa@igel.co.jp> In-Reply-To: <1427445553-3151-1-git-send-email-mukawa@igel.co.jp> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 0/5] Clean up pci uio implementations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2015 13:15:54 -0000 > -----Original Message----- > From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp] > Sent: Friday, March 27, 2015 8:39 AM > To: dev@dpdk.org > Cc: Iremonger, Bernard; Richardson, Bruce; david.marchand@6wind.com; Tets= uya Mukawa > Subject: [PATCH v3 0/5] Clean up pci uio implementations >=20 > This patch set cleans up pci uio implementation. These clean up are for c= onsolidating pci uio > implementation of linuxapp and bsdapp, and moving consolidated functions = in eal common. > Because of above, this patch set tries to implement linuxapp and bsdapp a= lmost same. > Actual consolidations will be done later patch set. >=20 > PATCH v3 changes: > - Squash patches related with pci_map_resource(). > - Free maps[].path to easy to understand. > (Thanks to Iremonger, Bernard) > - Close fds opened in this function. > - Remove unused path variable from mapped_pci_resource structure. >=20 > PATCH v2 changes: > - Move 'if-condition' to later patch series. > - Fix memory leaks of path. > - Fix typos. > (Thanks to David Marchand) > - Fix commit title and body. > - Fix pci_map_resource() to handle MAP_FAILED. > (Thanks to Iremonger, Bernard) >=20 > Changes: > - This patch set is derived from below. > "[PATCH v2] eal: Port Hotplug support for BSD" > - Set cfg_fd as -1, when cfg_fd is closed. > (Thanks to Iremonger, Bernard) > - Remove needless coding style fixings. > - Fix coding style of if-else condition. > (Thanks to Richardson, Bruce) >=20 >=20 >=20 > Tetsuya Mukawa (5): > eal: Fix coding style of eal_pci.c and eal_pci_uio.c > eal: Close file descriptor of uio configuration > eal: Fix memory leaks and needless increment of pci_map_addr > eal/bsdapp: Change names of pci related data structure > eal: Fix uio mapping differences between linuxapp and bsdapp >=20 > lib/librte_eal/bsdapp/eal/eal_pci.c | 166 +++++++++++++++++------= ------ > lib/librte_eal/linuxapp/eal/eal_pci_init.h | 1 - > lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 91 +++++++++------- > 3 files changed, 154 insertions(+), 104 deletions(-) >=20 > -- > 1.9.1 Series Acked-by: Bernard Iremonger