From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 5553058F3 for ; Thu, 23 Apr 2015 10:12:48 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 23 Apr 2015 01:12:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,629,1422950400"; d="scan'208";a="717947449" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga002.jf.intel.com with ESMTP; 23 Apr 2015 01:12:47 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.246]) by IRSMSX103.ger.corp.intel.com ([169.254.3.76]) with mapi id 14.03.0224.002; Thu, 23 Apr 2015 09:12:45 +0100 From: "Iremonger, Bernard" To: Tetsuya Mukawa , "dev@dpdk.org" Thread-Topic: [PATCH v3 0/5] Clean up pci uio implementations Thread-Index: AQHQaGmfBcNYV6iaoE6uf0ngsXhmMJ1XmZLQgAJ/W4CAAFAJAA== Date: Thu, 23 Apr 2015 08:12:44 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C204A19A4B@IRSMSX108.ger.corp.intel.com> References: <1426584645-28828-7-git-send-email-mukawa@igel.co.jp> <1427445553-3151-1-git-send-email-mukawa@igel.co.jp> <8CEF83825BEC744B83065625E567D7C204A0FF82@IRSMSX108.ger.corp.intel.com> <553873C5.1000909@igel.co.jp> In-Reply-To: <553873C5.1000909@igel.co.jp> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 0/5] Clean up pci uio implementations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Apr 2015 08:12:48 -0000 > -----Original Message----- > From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp] > Sent: Thursday, April 23, 2015 5:24 AM > To: Iremonger, Bernard; dev@dpdk.org > Cc: Richardson, Bruce; david.marchand@6wind.com > Subject: Re: [PATCH v3 0/5] Clean up pci uio implementations >=20 > On 2015/04/21 22:15, Iremonger, Bernard wrote: > >> -----Original Message----- > >> From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp] > >> Sent: Friday, March 27, 2015 8:39 AM > >> To: dev@dpdk.org > >> Cc: Iremonger, Bernard; Richardson, Bruce; david.marchand@6wind.com; > >> Tetsuya Mukawa > >> Subject: [PATCH v3 0/5] Clean up pci uio implementations > >> > >> This patch set cleans up pci uio implementation. These clean up are > >> for consolidating pci uio implementation of linuxapp and bsdapp, and m= oving consolidated > functions in eal common. > >> Because of above, this patch set tries to implement linuxapp and bsdap= p almost same. > >> Actual consolidations will be done later patch set. > >> > >> PATCH v3 changes: > >> - Squash patches related with pci_map_resource(). > >> - Free maps[].path to easy to understand. > >> (Thanks to Iremonger, Bernard) > >> - Close fds opened in this function. > >> - Remove unused path variable from mapped_pci_resource structure. > >> > >> PATCH v2 changes: > >> - Move 'if-condition' to later patch series. > >> - Fix memory leaks of path. > >> - Fix typos. > >> (Thanks to David Marchand) > >> - Fix commit title and body. > >> - Fix pci_map_resource() to handle MAP_FAILED. > >> (Thanks to Iremonger, Bernard) > >> > >> Changes: > >> - This patch set is derived from below. > >> "[PATCH v2] eal: Port Hotplug support for BSD" > >> - Set cfg_fd as -1, when cfg_fd is closed. > >> (Thanks to Iremonger, Bernard) > >> - Remove needless coding style fixings. > >> - Fix coding style of if-else condition. > >> (Thanks to Richardson, Bruce) > >> > >> > >> > >> Tetsuya Mukawa (5): > >> eal: Fix coding style of eal_pci.c and eal_pci_uio.c > >> eal: Close file descriptor of uio configuration > >> eal: Fix memory leaks and needless increment of pci_map_addr > >> eal/bsdapp: Change names of pci related data structure > >> eal: Fix uio mapping differences between linuxapp and bsdapp > >> > >> lib/librte_eal/bsdapp/eal/eal_pci.c | 166 +++++++++++++++++---= --------- > >> lib/librte_eal/linuxapp/eal/eal_pci_init.h | 1 - > >> lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 91 +++++++++------- > >> 3 files changed, 154 insertions(+), 104 deletions(-) > >> > >> -- > >> 1.9.1 > > Series > > Acked-by: Bernard Iremonger > Hi Bernard, >=20 > Thanks for your checking. > It seems I need to rebase this patches for latest matser branch. > So I will update and submit it soon. >=20 > Regards, > Tetsuya Hi Tetsuya, I applied the v3 patches to the latest master branch on Monday last and the= re were no issues. The patches built cleanly on Linux and Free BSD. Regards, Bernard. =20