* Re: [dpdk-dev] [PATCH] ixgbe: reset hardware stat when initialize [not found] <1431072861-28565-1-git-send-email-qiudayu@cn.ibm.com> @ 2015-05-20 9:35 ` Qiu, Michael 2015-06-11 7:29 ` [dpdk-dev] [PATCH v2] " Michael Qiu 1 sibling, 0 replies; 5+ messages in thread From: Qiu, Michael @ 2015-05-20 9:35 UTC (permalink / raw) To: Michael Qiu, dev Any comments about this patch? Thanks, Michael On 5/8/2015 4:14 PM, Michael Qiu wrote: > From: Michael Qiu <michael.qiu@intel.com> > > When initialize the hardware, the stat should be reset. > Otherwise when detach then attach port, the stat will not > be re-init to zero. > > Signed-off-by: Michael Qiu <michael.qiu@intel.com> > --- > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c > index 1b3b4b5..dbcc12a 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c > @@ -840,6 +840,9 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev) > return -EIO; > } > > + /* Reset the hw statistics */ > + ixgbe_dev_stats_reset(eth_dev); > + > /* disable interrupt */ > ixgbe_disable_intr(hw); > > @@ -1015,6 +1018,9 @@ eth_ixgbevf_dev_init(struct rte_eth_dev *eth_dev) > /* Disable the interrupts for VF */ > ixgbevf_intr_disable(hw); > > + /* Reset the hw statistics */ > + ixgbevf_dev_stats_reset(eth_dev); > + > hw->mac.num_rar_entries = 128; /* The MAX of the underlying PF */ > diag = hw->mac.ops.reset_hw(hw); > ^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH v2] ixgbe: reset hardware stat when initialize [not found] <1431072861-28565-1-git-send-email-qiudayu@cn.ibm.com> 2015-05-20 9:35 ` [dpdk-dev] [PATCH] ixgbe: reset hardware stat when initialize Qiu, Michael @ 2015-06-11 7:29 ` Michael Qiu 2015-06-22 12:47 ` Iremonger, Bernard 1 sibling, 1 reply; 5+ messages in thread From: Michael Qiu @ 2015-06-11 7:29 UTC (permalink / raw) To: dev When initialize the hardware, the stat should be reset. Otherwise when detach then attach port, the stat will not be re-init to zero. Signed-off-by: Michael Qiu <michael.qiu@intel.com> --- Change log: v2 --> v1: change the folder of driver drivers/net/ixgbe/ixgbe_ethdev.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 0d9f9b2..e0415a7 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -840,6 +840,9 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev) return -EIO; } + /* Reset the hw statistics */ + ixgbe_dev_stats_reset(eth_dev); + /* disable interrupt */ ixgbe_disable_intr(hw); @@ -1012,6 +1015,9 @@ eth_ixgbevf_dev_init(struct rte_eth_dev *eth_dev) /* init_mailbox_params */ hw->mbx.ops.init_params(hw); + /* Reset the hw statistics */ + ixgbevf_dev_stats_reset(eth_dev); + /* Disable the interrupts for VF */ ixgbevf_intr_disable(hw); -- 1.9.3 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v2] ixgbe: reset hardware stat when initialize 2015-06-11 7:29 ` [dpdk-dev] [PATCH v2] " Michael Qiu @ 2015-06-22 12:47 ` Iremonger, Bernard 2015-07-02 11:54 ` Qiu, Michael 2015-07-10 15:52 ` Thomas Monjalon 0 siblings, 2 replies; 5+ messages in thread From: Iremonger, Bernard @ 2015-06-22 12:47 UTC (permalink / raw) To: Qiu, Michael, dev > -----Original Message----- > From: Qiu, Michael > Sent: Thursday, June 11, 2015 8:30 AM > To: dev@dpdk.org > Cc: Iremonger, Bernard; thomas.monjalon@6wind.com; Qiu, Michael > Subject: [PATCH v2] ixgbe: reset hardware stat when initialize > > When initialize the hardware, the stat should be reset. > Otherwise when detach then attach port, the stat will not be re-init to zero. > > Signed-off-by: Michael Qiu <michael.qiu@intel.com> > --- Acked-by: Bernard Iremonger <Bernard.iremonger@intel.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v2] ixgbe: reset hardware stat when initialize 2015-06-22 12:47 ` Iremonger, Bernard @ 2015-07-02 11:54 ` Qiu, Michael 2015-07-10 15:52 ` Thomas Monjalon 1 sibling, 0 replies; 5+ messages in thread From: Qiu, Michael @ 2015-07-02 11:54 UTC (permalink / raw) To: dev Hi, all Any comments on this patch? Thanks, Michael On 6/22/2015 8:47 PM, Iremonger, Bernard wrote: >> -----Original Message----- >> From: Qiu, Michael >> Sent: Thursday, June 11, 2015 8:30 AM >> To: dev@dpdk.org >> Cc: Iremonger, Bernard; thomas.monjalon@6wind.com; Qiu, Michael >> Subject: [PATCH v2] ixgbe: reset hardware stat when initialize >> >> When initialize the hardware, the stat should be reset. >> Otherwise when detach then attach port, the stat will not be re-init to zero. >> >> Signed-off-by: Michael Qiu <michael.qiu@intel.com> >> --- > Acked-by: Bernard Iremonger <Bernard.iremonger@intel.com> > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v2] ixgbe: reset hardware stat when initialize 2015-06-22 12:47 ` Iremonger, Bernard 2015-07-02 11:54 ` Qiu, Michael @ 2015-07-10 15:52 ` Thomas Monjalon 1 sibling, 0 replies; 5+ messages in thread From: Thomas Monjalon @ 2015-07-10 15:52 UTC (permalink / raw) To: Qiu, Michael; +Cc: dev > > When initialize the hardware, the stat should be reset. > > Otherwise when detach then attach port, the stat will not be re-init to zero. > > > > Signed-off-by: Michael Qiu <michael.qiu@intel.com> > > Acked-by: Bernard Iremonger <Bernard.iremonger@intel.com> Applied, thanks ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-07-10 15:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1431072861-28565-1-git-send-email-qiudayu@cn.ibm.com>
2015-05-20 9:35 ` [dpdk-dev] [PATCH] ixgbe: reset hardware stat when initialize Qiu, Michael
2015-06-11 7:29 ` [dpdk-dev] [PATCH v2] " Michael Qiu
2015-06-22 12:47 ` Iremonger, Bernard
2015-07-02 11:54 ` Qiu, Michael
2015-07-10 15:52 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).