From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 937DC5A3E for ; Wed, 15 Jul 2015 10:50:48 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP; 15 Jul 2015 01:50:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,479,1432623600"; d="scan'208";a="762856343" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga002.fm.intel.com with ESMTP; 15 Jul 2015 01:50:46 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.201]) by IRSMSX152.ger.corp.intel.com ([169.254.6.90]) with mapi id 14.03.0224.002; Wed, 15 Jul 2015 09:50:45 +0100 From: "Iremonger, Bernard" To: "Ouyang, Changchun" , Stephen Hemminger Thread-Topic: [PATCH 4/5] virtio: free queue memory in virtio_dev_close() Thread-Index: AQHQvmLY136Y3FNdc0SUiCYaM22MYp3cMnuw///zQQCAABL2YA== Date: Wed, 15 Jul 2015 08:50:45 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C204A4908A@IRSMSX108.ger.corp.intel.com> References: <1436879459-18400-1-git-send-email-bernard.iremonger@intel.com> <1436879459-18400-5-git-send-email-bernard.iremonger@intel.com> <20150714112810.1319eddd@urahara> <8CEF83825BEC744B83065625E567D7C204A49031@IRSMSX108.ger.corp.intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 4/5] virtio: free queue memory in virtio_dev_close() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2015 08:50:49 -0000 > -----Original Message----- > From: Ouyang, Changchun > Sent: Wednesday, July 15, 2015 9:39 AM > To: Iremonger, Bernard; Stephen Hemminger > Cc: dev@dpdk.org; Ouyang, Changchun > Subject: RE: [PATCH 4/5] virtio: free queue memory in virtio_dev_close() >=20 >=20 >=20 > > -----Original Message----- > > From: Iremonger, Bernard > > Sent: Wednesday, July 15, 2015 4:27 PM > > To: Stephen Hemminger > > Cc: dev@dpdk.org; Ouyang, Changchun > > Subject: RE: [PATCH 4/5] virtio: free queue memory in > > virtio_dev_close() > > > > > -----Original Message----- > > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > > Sent: Tuesday, July 14, 2015 7:28 PM > > > To: Iremonger, Bernard > > > Cc: dev@dpdk.org; Ouyang, Changchun > > > Subject: Re: [PATCH 4/5] virtio: free queue memory in > > > virtio_dev_close() > > > > > > On Tue, 14 Jul 2015 14:10:58 +0100 > > > Bernard Iremonger wrote: > > > > > > > static void > > > > +virtio_free_queues(struct rte_eth_dev *dev) { > > > > + unsigned int i; > > > > + > > > > + for (i =3D 0; i < dev->data->nb_rx_queues; i++) { > > > > + virtio_dev_rx_queue_release(dev->data->rx_queues[i]); > > > > + dev->data->rx_queues[i] =3D NULL; > > > > + } > > > > + dev->data->nb_rx_queues =3D 0; > > > > + > > > > + for (i =3D 0; i < dev->data->nb_tx_queues; i++) { > > > > + virtio_dev_tx_queue_release(dev->data->tx_queues[i]); > > > > + dev->data->tx_queues[i] =3D NULL; > > > > + } > > > > + dev->data->nb_tx_queues =3D 0; > > > > +} > > > > + > > > > > > Where does command queue get freed? > > > > The command queue is set up in the eth_virtio_dev_init() function and > > freed in the eth_virtio_dev_uninit() function. > > >=20 > Do you mean control vq? I am referring to hw->cvq. Regards, Bernard.