From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 9D8C08E8B
 for <dev@dpdk.org>; Mon,  2 Nov 2015 11:36:46 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga102.jf.intel.com with ESMTP; 02 Nov 2015 02:36:45 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,234,1444719600"; d="scan'208";a="592437540"
Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25])
 by FMSMGA003.fm.intel.com with ESMTP; 02 Nov 2015 02:36:45 -0800
Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by
 irsmsx110.ger.corp.intel.com (163.33.3.25) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Mon, 2 Nov 2015 10:36:43 +0000
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.138]) by
 irsmsx155.ger.corp.intel.com ([169.254.14.242]) with mapi id 14.03.0248.002;
 Mon, 2 Nov 2015 10:36:44 +0000
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v7 02/28] librte_ether: add fields from
 rte_pci_driver to rte_eth_dev_data
Thread-Index: AQHRFOouZX+PM6tUz0GbZHUpEC9x/J6IhI2g
Date: Mon, 2 Nov 2015 10:36:43 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C219F76F86@IRSMSX108.ger.corp.intel.com>
References: <1446217733-9887-3-git-send-email-bernard.iremonger@intel.com>
 <1583512.Ss2AELHNGg@xps13>
In-Reply-To: <1583512.Ss2AELHNGg@xps13>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v7 02/28] librte_ether: add fields from
 rte_pci_driver to rte_eth_dev_data
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Nov 2015 10:36:47 -0000

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Sunday, November 1, 2015 9:12 PM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v7 02/28] librte_ether: add fields from
> rte_pci_driver to rte_eth_dev_data
>=20
> 2015-10-30 15:08, Bernard Iremonger:
> > add dev_flags to rte_eth_dev_data, add macros for dev_flags.
> > add kdrv to rte_eth_dev_data.
> > add numa_node to rte_eth_dev_data.
> > add drv_name to rte_eth_dev_data.
>=20
> A commit message should explain why things are done.
>=20
> > +	uint32_t dev_flags; /**< Flags controlling handling of device. */
>=20
> Where are defined this flags? What is the scope?

These flags are defined in the following file:

lib/librte_ether/rte_ethdev.h

These flags are visible to all the vdevs and pdevs.

Regards,

Bernard.