From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 4CE5EA2F
 for <dev@dpdk.org>; Mon,  2 Nov 2015 17:44:46 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga103.fm.intel.com with ESMTP; 02 Nov 2015 08:44:14 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,234,1444719600"; d="scan'208";a="592617943"
Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75])
 by FMSMGA003.fm.intel.com with ESMTP; 02 Nov 2015 08:44:04 -0800
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.138]) by
 IRSMSX153.ger.corp.intel.com ([169.254.9.191]) with mapi id 14.03.0248.002;
 Mon, 2 Nov 2015 16:44:03 +0000
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v7 02/28] librte_ether: add fields from
 rte_pci_driver to rte_eth_dev_data
Thread-Index: AQHRFOouZX+PM6tUz0GbZHUpEC9x/J6IhI2ggABppACAAAF5MA==
Date: Mon, 2 Nov 2015 16:44:02 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C219F7716B@IRSMSX108.ger.corp.intel.com>
References: <1446217733-9887-3-git-send-email-bernard.iremonger@intel.com>
 <1583512.Ss2AELHNGg@xps13>
 <8CEF83825BEC744B83065625E567D7C219F76F86@IRSMSX108.ger.corp.intel.com>
 <22264893.CRHp7yC71q@xps13>
In-Reply-To: <22264893.CRHp7yC71q@xps13>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v7 02/28] librte_ether: add fields from
 rte_pci_driver to rte_eth_dev_data
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Nov 2015 16:44:46 -0000

Hi Thomas,

<snip>

> Subject: Re: [dpdk-dev] [PATCH v7 02/28] librte_ether: add fields from
> rte_pci_driver to rte_eth_dev_data
>=20
> 2015-11-02 10:36, Iremonger, Bernard:
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > 2015-10-30 15:08, Bernard Iremonger:
> > > > add dev_flags to rte_eth_dev_data, add macros for dev_flags.
> > > > add kdrv to rte_eth_dev_data.
> > > > add numa_node to rte_eth_dev_data.
> > > > add drv_name to rte_eth_dev_data.
> > >
> > > A commit message should explain why things are done.
> > >
> > > > +	uint32_t dev_flags; /**< Flags controlling handling of device.
> > > > +*/
> > >
> > > Where are defined this flags? What is the scope?
> >
> > These flags are defined in the following file:
> >
> > lib/librte_ether/rte_ethdev.h
> >
> > These flags are visible to all the vdevs and pdevs.
>=20
> I mean it should be more explicit. Having an enum name will help.
> Note: I understand your patch. I'm just asking the questions an user will=
 ask
> when trying to use your new API.
> Thanks

I will try to be clearer in the commit message.
I tried an enum for the dev_flags but it does not work well.
There can be multiple flags set in dev_flags, it is intended to be a bit fi=
eld similar to the pci flags.

I have squashed down to 19 patches now, I don't want to over squash.

Regards,

Bernard.

=20