From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id B721C8E84
 for <dev@dpdk.org>; Fri,  4 Dec 2015 16:25:37 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga102.fm.intel.com with ESMTP; 04 Dec 2015 07:25:37 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,380,1444719600"; d="scan'208";a="700257071"
Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66])
 by orsmga003.jf.intel.com with ESMTP; 04 Dec 2015 07:25:36 -0800
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.23]) by
 IRSMSX152.ger.corp.intel.com ([169.254.6.143]) with mapi id 14.03.0248.002;
 Fri, 4 Dec 2015 15:25:31 +0000
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>, Stephen Hemminger
 <stephen@networkplumber.org>
Thread-Topic: [PATCH] virtio: fix link state regression
Thread-Index: AQHRLjiocxgYrHFVWkGD8Pf09o8dYJ66K6KAgADG4QA=
Date: Fri, 4 Dec 2015 15:25:29 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C219F8D635@IRSMSX108.ger.corp.intel.com>
References: <1449194904-9626-1-git-send-email-stephen@networkplumber.org>
 <20151204032953.GC29571@yliu-dev.sh.intel.com>
In-Reply-To: <20151204032953.GC29571@yliu-dev.sh.intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] virtio: fix link state regression
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Dec 2015 15:25:38 -0000

Hi Stephen, Yuanhan,

> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> Sent: Friday, December 4, 2015 3:30 AM
> To: Stephen Hemminger <stephen@networkplumber.org>
> Cc: Xie, Huawei <huawei.xie@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>; dev@dpdk.org
> Subject: Re: [PATCH] virtio: fix link state regression
>=20
> On Thu, Dec 03, 2015 at 06:08:24PM -0800, Stephen Hemminger wrote:
> > Support for link state interrupt was broken on virtio by
> >
> > commit bda66c418c85 ("ethdev: add device fields from PCI layer")
> >
> > This is caused because the actual value of drv_flags is not set until
> > after the resource_init has figured out whether it is using UIO or
> > direct I/O instructions.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> > There maybe other drivers with the same problem. It would have been
> > better to move the structure elements (and break ABI) rather than
> > assume it safe to copy them. Better to fail compiling.
>=20
> I see no patch content.
>=20
> 	--yliu

I have submitted a patch for this issue.

http://dpdk.org/dev/patchwork/patch/9345/

I have checked the other drivers, I found an issue with the bonding PMD.
I have submitted a patch for this.

http://dpdk.org/dev/patchwork/patch/9342/

The remaining drivers look fine to me.

Regards,

Bernard.

=20