From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 15B223784
 for <dev@dpdk.org>; Wed,  9 Dec 2015 17:11:11 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga101.fm.intel.com with ESMTP; 09 Dec 2015 08:10:31 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,404,1444719600"; d="scan'208";a="837732422"
Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28])
 by orsmga001.jf.intel.com with ESMTP; 09 Dec 2015 08:10:31 -0800
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.23]) by
 irsmsx105.ger.corp.intel.com ([169.254.7.203]) with mapi id 14.03.0248.002;
 Wed, 9 Dec 2015 16:10:29 +0000
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application
 guide
Thread-Index: AQHRMn48dNFqeN8IxESb81FB1fPCtJ7Ct7JAgAAawyA=
Date: Wed, 9 Dec 2015 16:10:29 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C219F8E95C@IRSMSX108.ger.corp.intel.com>
References: <1449664541-9546-1-git-send-email-bernard.iremonger@intel.com>
 <B27915DBBA3421428155699D51E4CFE2023FFE7B@IRSMSX103.ger.corp.intel.com>
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2023FFE7B@IRSMSX103.ger.corp.intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application
 guide
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Dec 2015 16:11:12 -0000

Hi John,

<snip>

> Hi Bernard,
>=20
> Thanks for that. One comment (in several places):
>=20
>=20
> >      .. code-block:: console
> >
> > -        user@target:~$ ./build/app/vhost-switch -c f -n 4 --huge-dir
> /mnt/huge -- -p 0x1 --dev-basename usvhost
> > +        user@target:~$ ./build/app/vhost-switch -c f -n 4
> > + --socket-mem 1024 --huge-dir /mnt/huge -- -p 0x1 --dev-basename
> > + usvhost
>=20
> These long lines in code blocks don't render correctly in the PDF docs. T=
he
> Documentation Guidelines suggest using a commandline line continuation to
> maintain functionality within an 80 char doc limit:
>=20
>    http://dpdk.org/doc/guides/contributing/documentation.html#code-and-
> literal-block-sections
>=20
> So something like this:
>=20
>     user@target:~$ ./build/app/vhost-switch -c f -n 4 --socket-mem 1024 -=
-
> huge-dir /mnt/huge -- -p 0x1 --dev-basename usvhost
>=20
> Could be written as:
>=20
>     user@target:~$ ./build/app/vhost-switch -c f -n 4 --socket-mem 1024 \
>                          --huge-dir /mnt/huge -- -p 0x1 --dev-basename us=
vhost
>=20
> Or:
>=20
>     user@target:~$ ./build/app/vhost-switch -c f -n 4 \
>                                             --socket-mem 1024 \
>                                             --huge-dir /mnt/huge \
>                                             -- -p 0x1 --dev-basename usvh=
ost
>=20
> Regards,
>=20
> John.
> --

I will use a command line continuation character to stay within 80 characte=
r limit.

Regards,

Bernard.