From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 3A67E2BAD for ; Wed, 2 Mar 2016 10:49:27 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 02 Mar 2016 01:49:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,528,1449561600"; d="scan'208";a="927796667" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga002.fm.intel.com with ESMTP; 02 Mar 2016 01:49:26 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.102]) by IRSMSX107.ger.corp.intel.com ([163.33.3.99]) with mapi id 14.03.0248.002; Wed, 2 Mar 2016 09:49:23 +0000 From: "Iremonger, Bernard" To: Eric Kinzie Thread-Topic: [dpdk-dev] [PATCH v2 4/6] bond mode 4: allow external state machine Thread-Index: AQHRbXQFYcr7ZXIKXk+O+HoUoiOQ35884jvQgAgF1QCAAQ1PwA== Date: Wed, 2 Mar 2016 09:49:23 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C219FB5BFC@IRSMSX108.ger.corp.intel.com> References: <8CEF83825BEC744B83065625E567D7C219FB2C51@IRSMSX108.ger.corp.intel.com> <1455909473-13539-1-git-send-email-ehkinzie@gmail.com> <1455909473-13539-5-git-send-email-ehkinzie@gmail.com> <56CB0709.6010407@redhat.com> <8CEF83825BEC744B83065625E567D7C219FB4852@IRSMSX108.ger.corp.intel.com> <20160301174042.GA14082@roosta.home> In-Reply-To: <20160301174042.GA14082@roosta.home> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTYxMmIxOWMtMTI1ZC00YzYzLThiNzktOGI1ZTYxMTY0MTBlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImtxM0pRSktxK2tPeWFMWUtpbmpjSU5EUU5BNlI0STZvTmpyNVU4cWtuQ1U9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 4/6] bond mode 4: allow external state machine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2016 09:49:27 -0000 Hi Eric, > > > > @@ -157,6 +159,7 @@ struct rte_eth_bond_8023ad_conf { > > > > uint32_t tx_period_ms; > > > > uint32_t rx_marker_period_ms; > > > > uint32_t update_timeout_ms; > > > > + rte_eth_bond_8023ad_ext_slowrx_fn slowrx_cb; > > > > }; > > > > > > This still is a likely an ABI break, previously discussed around here= : > > > http://dpdk.org/ml/archives/dev/2015-November/027321.html > > > > > > It might not be embedded anywhere in DPDK codebase, but there's no > > > telling what others might have done with it (have an array of them, > > > embed in other structs etc). > > > > > > Also ultimately ABI compatibility goes both ways: when the library > > > soname does not change then an application is free to assume both > > > downgrading and upgrading are safe. In this case, upgrading *might* > > > be okay, downgrading certainly is not. So by that measure it definite= ly is > an ABI break. > > > > > > [...] > > > > diff --git a/drivers/net/bonding/rte_eth_bond_version.map > > > > b/drivers/net/bonding/rte_eth_bond_version.map > > > > index 22bd920..33d73ff 100644 > > > > --- a/drivers/net/bonding/rte_eth_bond_version.map > > > > +++ b/drivers/net/bonding/rte_eth_bond_version.map > > > > @@ -27,3 +27,9 @@ DPDK_2.1 { > > > > rte_eth_bond_free; > > > > > > > > } DPDK_2.0; > > > > + > > > > +DPDK_2.2 { > > > > + rte_eth_bond_8023ad_ext_collect; > > > > + rte_eth_bond_8023ad_ext_distrib; > > > > + rte_eth_bond_8023ad_ext_slowtx; > > > > +} DPDK_2.1; > > > > > > > > > > These symbols are not part of DPDK 2.2, the version here is wrong. > > > Technically it would not actually matter much but better not to > > > confuse things unnecessarily. > > > > > > - Panu - > > > > It looks like Panu's points are valid, a V3 of this patch set which tak= es care of > these issues will be needed. > > > > Patches 1/6, 5/6 and 6/6 of the patch set are bug fixes, so each patch > should contain a fixes line. > > Patches 2/6, 3/6 and 4/6 are a new feature, the release notes should be > updated for this feature. > > > > Could I suggest splitting the patch set into two patch sets, a bug fix = patch > set and a new feature patch set. > > > > Regards, > > > > Bernard. >=20 > Bernard, a v3 is on the way. I included only things that are fixes, but = the > patch set doesn't quite match the set of patch numbers you listed above. > 1/6 (bond: use existing enslaved device queues) is an improvement, but > doesn't really fix anything that was broken, so I left that out. > 2/6 (bond mode 4: copy entire config structure) and 3/6 (bond mode 4: > do not ignore multicast) fix bugs and are included. >=20 >=20 > Eric Thanks for the V3 patchset and clarifying which patches in the V2 patchset = were fixes. Regards, Bernard. =20