From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: fix occasional timeouts when starting VF
Date: Wed, 6 Apr 2016 10:37:11 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C219FD1774@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1644934.6ArMgPXceK@xps13>
Hi Thomas,
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, April 5, 2016 4:48 PM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: fix occasional timeouts when
> starting VF
>
> 2016-04-05 15:55, Bernard Iremonger:
> > - poll_ms = 10;
> > + poll_ms = RTE_IXGBE_REGISTER_POLL_WAIT_15_MS;
> [...]
> > #define RTE_IXGBE_REGISTER_POLL_WAIT_10_MS 10
> > +#define RTE_IXGBE_REGISTER_POLL_WAIT_15_MS 15
> > #define RTE_IXGBE_WAIT_100_US 100
>
> I don't understand why these constants are needed.
> There is no semantic, just an arbitrary number.
I am seeing intermittent failures in the following test at line 4969 in ixgbe_rxtx.c:
while (--poll_ms && !(txdctl & IXGBE_TXDCTL_ENABLE))
Increasing the value of poll_ms does not address the root cause of this failure.
This needs more investigation.
Self NAK.
prev parent reply other threads:[~2016-04-06 10:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 10:56 [dpdk-dev] [PATCH] " Bernard Iremonger
2016-04-05 14:55 ` [dpdk-dev] [PATCH v2] " Bernard Iremonger
2016-04-05 15:47 ` Thomas Monjalon
2016-04-06 10:37 ` Iremonger, Bernard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C219FD1774@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).