From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 1B3E128F2 for ; Wed, 6 Apr 2016 12:37:13 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP; 06 Apr 2016 03:37:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,447,1455004800"; d="scan'208";a="681683606" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by FMSMGA003.fm.intel.com with ESMTP; 06 Apr 2016 03:37:12 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.13]) by IRSMSX101.ger.corp.intel.com ([169.254.1.157]) with mapi id 14.03.0248.002; Wed, 6 Apr 2016 11:37:11 +0100 From: "Iremonger, Bernard" To: Thomas Monjalon CC: "dev@dpdk.org" , "Lu, Wenzhuo" Thread-Topic: [dpdk-dev] [PATCH v2] ixgbe: fix occasional timeouts when starting VF Thread-Index: AQHRj1LKMm5RHd1SAkWMVtyK9LfBEZ98v5mQ Date: Wed, 6 Apr 2016 10:37:11 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C219FD1774@IRSMSX108.ger.corp.intel.com> References: <1459853800-31760-1-git-send-email-bernard.iremonger@intel.com> <1459868146-26547-1-git-send-email-bernard.iremonger@intel.com> <1644934.6ArMgPXceK@xps13> In-Reply-To: <1644934.6ArMgPXceK@xps13> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDAxNDI0YmMtMjk4OS00ODg0LThmZWItYzc1Y2ZlNTczMzQ5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IndLemw0Y1BnWGhDa2JcLzVoOVN1Z0hGT1dEV3Rwd1c0V2sxQ0xmbHpVaWZvPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: fix occasional timeouts when starting VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2016 10:37:14 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, April 5, 2016 4:48 PM > To: Iremonger, Bernard > Cc: dev@dpdk.org; Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: fix occasional timeouts when > starting VF >=20 > 2016-04-05 15:55, Bernard Iremonger: > > - poll_ms =3D 10; > > + poll_ms =3D RTE_IXGBE_REGISTER_POLL_WAIT_15_MS; > [...] > > #define RTE_IXGBE_REGISTER_POLL_WAIT_10_MS 10 > > +#define RTE_IXGBE_REGISTER_POLL_WAIT_15_MS 15 > > #define RTE_IXGBE_WAIT_100_US 100 >=20 > I don't understand why these constants are needed. > There is no semantic, just an arbitrary number. I am seeing intermittent failures in the following test at line 4969 in ixg= be_rxtx.c: while (--poll_ms && !(txdctl & IXGBE_TXDCTL_ENABLE)) Increasing the value of poll_ms does not address the root cause of this fai= lure. This needs more investigation. Self NAK. =20