From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 830745A0A for ; Thu, 6 Oct 2016 16:33:31 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 06 Oct 2016 07:33:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,454,1473145200"; d="scan'208";a="769574248" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by FMSMGA003.fm.intel.com with ESMTP; 06 Oct 2016 07:33:29 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.164]) by irsmsx110.ger.corp.intel.com ([163.33.3.25]) with mapi id 14.03.0248.002; Thu, 6 Oct 2016 15:33:27 +0100 From: "Iremonger, Bernard" To: Thomas Monjalon CC: "dev@dpdk.org" , "Shah, Rahul R" , "Lu, Wenzhuo" , "az5157@att.com" , "jerin.jacob@caviumnetworks.com" Thread-Topic: [dpdk-dev] [PATCH v5 01/13] librte_ether: modify internal callback function Thread-Index: AQHSH8SD2FeiVD24+EqwRkAkHVUdGaCbUbEAgAAo32A= Date: Thu, 6 Oct 2016 14:33:27 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C21A08F83F@IRSMSX108.ger.corp.intel.com> References: <1475592734-22355-1-git-send-email-bernard.iremonger@intel.com> <1475753191-17391-2-git-send-email-bernard.iremonger@intel.com> <8021250.9Wl94qBdaq@xps13> In-Reply-To: <8021250.9Wl94qBdaq@xps13> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDY0ODIxZGItYmY1Ny00MDEyLTljMTItMTUxMDUyY2NmNTZiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik5KUGJWeHdtS1UxQk1xNll2OFpWaXhoblJlbUIyMWVnWjArMDBVb1JiZFE9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 01/13] librte_ether: modify internal callback function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Oct 2016 14:33:31 -0000 Hi Thomas, > Subject: Re: [dpdk-dev] [PATCH v5 01/13] librte_ether: modify internal > callback function >=20 > 2016-10-06 12:26, Bernard Iremonger: > > void > > _rte_eth_dev_callback_process(struct rte_eth_dev *dev, > > - enum rte_eth_event_type event) > > + enum rte_eth_event_type event, void *param) >=20 > You need to squash the patches updating the calls to this function. > Otherwise, this patch does not compile. I will have to squash everything into one patch, separate patches will not = compile. =20 > [...] > > + if (param !=3D NULL) > > + dev_cb.cb_arg =3D (void *) param; >=20 > You are overriding the user parameter. Yes, we want to update the user parameter for the RTE_ETH_EVENT_VF_MBOX > As it is only for a new event, it can be described in the register API th= at the > user param won't be returned for this event. I will add a description in the rte_eth_dev_callback_register function. > But a better design would be to add a new parameter to the callback. > However it will be an API breakage. I do not want to break the ABI at this point. >=20 > > + RTE_ETH_EVENT_VF_MBOX, /**< PF mailbox processing callback */ >=20 > Sorry I do not parse well this line. > The event name is VF_MBOX and the comment is about the callback > processing this event on PF side? > I would suggest this kind of comment: "message from VF received by PF" Ok. >=20 > [...] > > * Pointer to struct rte_eth_dev. > > * @param event > > * Eth device interrupt event type. > > + * @param param > > + * Parameter to pass back to user application. > > + * Allows the user application to decide if a particular function > > + * is permitted. >=20 > In a more generic case, the parameter gives some details about the event.