From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id AB7C82BB5 for ; Wed, 12 Oct 2016 17:00:08 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP; 12 Oct 2016 08:00:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,482,1473145200"; d="scan'208";a="19305325" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga004.jf.intel.com with ESMTP; 12 Oct 2016 08:00:06 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.164]) by irsmsx105.ger.corp.intel.com ([169.254.7.196]) with mapi id 14.03.0248.002; Wed, 12 Oct 2016 16:00:06 +0100 From: "Iremonger, Bernard" To: "De Lara Guarch, Pablo" , Thomas Monjalon CC: "Yigit, Ferruh" , "dev@dpdk.org" , "Shah, Rahul R" , "Lu, Wenzhuo" , "az5157@att.com" Thread-Topic: [dpdk-dev] [PATCH v7 2/2] app/test_pmd: add tests for new API's Thread-Index: AQHSIIgVXZ2bAeGP7keFsEHPCan9haCjURAAgAAI/QCAABI/kP//++cAgAARJwCAAI8dgIAA5+9Q Date: Wed, 12 Oct 2016 15:00:05 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C21A091FBB@IRSMSX108.ger.corp.intel.com> References: <1475231418-30717-2-git-send-email-bernard.iremonger@intel.com> <2850526.ogb5UjoHqb@xps13> <8CEF83825BEC744B83065625E567D7C21A090A8A@IRSMSX108.ger.corp.intel.com> <1615821.fhDo4YvI1t@xps13> <8CEF83825BEC744B83065625E567D7C21A090B2D@IRSMSX108.ger.corp.intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTY5ZDNkMzItMzNlYi00ZThjLThmODktMGVmMDE3YjIyOTI1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InZVaDRuaVUzVENUUUJCVDZac3JEd2NVZERldlNcLzN4dU1WU0wxaGRcLytlQT0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 2/2] app/test_pmd: add tests for new API's X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2016 15:00:09 -0000 Hi Pablo, > > Subject: Re: [dpdk-dev] [PATCH v7 2/2] app/test_pmd: add tests for new > > API's > > > > Hi Thomas, > > > > > > > > > > > Subject: Re: [dpdk-dev] [PATCH v7 2/2] app/test_pmd: add tests > > > > > for new API's > > > > > > > > > > 2016-10-11 16:09, Ferruh Yigit: > > > > > > This will cause a compilation error for shared libraries. > > > > > > Because PMDs not linked against application when compiled as > > > > > > shared library but used as plugins. > > > > > > > > > > > > Since it has been decided to have NIC specific APIs, we need > > > > > > to re-work that approach to fix shared library compilation. > > > > > > > > > > If testpmd uses the ixgbe API, it must be linked with the PMD. > > > > > Is there any issue adapting the testpmd makefile? > > > > > Hope that dlopen an already linked PMD is nicely managed. > > > > > > > > The ixgbe API will be used by other apps, for example Virtual > > > > Function Daemon (VFD) Moving the following line in rte.app.mak > > > > solves the problem > > > > > > > > Line 117: _LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) +=3D - > > > lrte_pmd_ixgbe > > > > > > > > To Line 103. > > > > > > > > Will this be acceptable? > > > > > > I think we must not link PMD in the general case but let this > > > responsibility to the application in case it uses some specific funct= ions. > > > Does it make sense? > > > > Yes, ok, will just modify the testpmd makefile for this case. >=20 > A couple of things: > You would need to use #ifdef RTE_LIBRTE_IXGBE_PMD in testpmd, right? > In case IXGBE is not available (maybe just modifying the makefile solves = the > problem). >=20 > Could you also add these new functions in the testpmd help? > Just add them in cmd_help_long_parsed. >=20 > Thanks, > Pablo I have added #ifdef RTE_LIBRTE_IXGBE_PMD in testpmd. The make file is modified to handle ixgbe PMD present and not present in sh= ared library mode and default mode. I have added the new functions to the testpmd help. Thanks for reviewing. Regards, Bernard.