From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 2CA6EBD33 for ; Wed, 26 Oct 2016 18:10:13 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP; 26 Oct 2016 09:10:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,551,1473145200"; d="scan'208";a="1050548654" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga001.jf.intel.com with ESMTP; 26 Oct 2016 09:10:10 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.210]) by IRSMSX109.ger.corp.intel.com ([169.254.13.122]) with mapi id 14.03.0248.002; Wed, 26 Oct 2016 17:09:33 +0100 From: "Iremonger, Bernard" To: "Wu, Jingjing" , "dev@dpdk.org" , "Shah, Rahul R" , "Lu, Wenzhuo" , "Dumitrescu, Cristian" Thread-Topic: [PATCH v6 1/2] net/ixgbe: support multiqueue mode VMDq DCB with SRIOV Thread-Index: AQHSLuAD7Bk9Ndn1QECdizWMLuZYTKC6vq6AgAAdmHCAAAwQMA== Date: Wed, 26 Oct 2016 16:09:32 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C21A09E1FF@IRSMSX108.ger.corp.intel.com> References: <1476872471-23362-1-git-send-email-bernard.iremonger@intel.com> <1477414269-27156-2-git-send-email-bernard.iremonger@intel.com> <9BB6961774997848B5B42BEC655768F80E2953E7@SHSMSX103.ccr.corp.intel.com> <8CEF83825BEC744B83065625E567D7C21A09E16F@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C21A09E16F@IRSMSX108.ger.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmFmOTM0NzAtYzMxNC00YzY3LWE4MGUtNzdjYWJiZmI4YjdmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IitmNlZwZWVsMjMrbXpGcGQ2TVcrblpZUmhKTkVseVNvVkdpTDlGR0E2bUk9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 1/2] net/ixgbe: support multiqueue mode VMDq DCB with SRIOV X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Oct 2016 16:10:13 -0000 Hi Jingling, > > > Subject: [PATCH v6 1/2] net/ixgbe: support multiqueue mode VMDq DCB > > > with SRIOV > > > > > > The folowing changes have been made to allow Data Centre Bridge > > > (DCB) configuration when SRIOV is enabled. > > > > > > Modify ixgbe_check_mq_mode function, when SRIOV is enabled, enable > > > mq_mode ETH_MQ_RX_VMDQ_DCB and ETH_MQ_TX_VMDQ_DCB. > > > > > > Modify ixgbe_dcb_tx_hw_config function, replace the struct ixgbe_hw > > > parameter with a struct rte_eth_dev parameter and handle SRIOV > > > enabled. > > > > > > Modify ixgbe_dev_mq_rx_configure function, when SRIOV is enabled, > > > enable mq_mode ETH_MQ_RX_VMDQ_DCB. > > > > > > Modify ixgbe_configure_dcb function, revise check on > > > dev->data->nb_rx_queues. > > > > > > Signed-off-by: Rahul R Shah > > > Signed-off-by: Bernard Iremonger > > > Acked-by: Wenzhuo Lu > > > --- > > > drivers/net/ixgbe/ixgbe_ethdev.c | 11 ++++++----- > > > drivers/net/ixgbe/ixgbe_rxtx.c | 35 ++++++++++++++++++++++-------- > --- > > -- > > > 2 files changed, 28 insertions(+), 18 deletions(-) > > > > > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > > > b/drivers/net/ixgbe/ixgbe_ethdev.c > > > index 4ca5747..4d5ce83 100644 > > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > > > @@ -1977,6 +1977,9 @@ ixgbe_check_mq_mode(struct rte_eth_dev > > *dev) > > > /* check multi-queue mode */ > > > switch (dev_conf->rxmode.mq_mode) { > > > case ETH_MQ_RX_VMDQ_DCB: > > > + PMD_INIT_LOG(INFO, "ETH_MQ_RX_VMDQ_DCB > > mode supported in SRIOV"); > > > + dev->data->dev_conf.rxmode.mq_mode =3D > > ETH_MQ_RX_VMDQ_DCB; > > This line is duplicated, mq_mode is ETH_MQ_RX_VMDQ_DCB already. >=20 > The mq_mode is assigned at this point in the other cases. This case is co= ded > in line with the other cases. >=20 > > and it's better to check if the nb_queue is valid. >=20 The nb_rx_q and nb_tx_q are checked after the switch statements at line 202= 7 with the v6 patch applied. Regards, Bernard.