From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id EEF214A59 for ; Fri, 9 Dec 2016 13:00:44 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP; 09 Dec 2016 04:00:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,324,1477983600"; d="scan'208";a="1096891490" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga002.fm.intel.com with ESMTP; 09 Dec 2016 04:00:43 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.159]) by IRSMSX106.ger.corp.intel.com ([169.254.8.112]) with mapi id 14.03.0248.002; Fri, 9 Dec 2016 12:00:42 +0000 From: "Iremonger, Bernard" To: "Yigit, Ferruh" , "thomas.monjalon@6wind.com" , "dev@dpdk.org" CC: "Iremonger, Bernard" Thread-Topic: [dpdk-dev] [PATCH v1 0/5] net/ixgbe: move set VF functions. Thread-Index: AQHSUg9VSuiSrpKTBUe1W+FFXPgUeqD/gdAAgAAAnGA= Date: Fri, 9 Dec 2016 12:00:42 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C224D0601D@IRSMSX108.ger.corp.intel.com> References: <1481282878-26176-1-git-send-email-bernard.iremonger@intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTE0MGJkZTktZjY3YS00ZWE0LTg4MDQtMGNhYjdmZGE1YjQ4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjIuMTEuMCIsIlRydXN0ZWRMYWJlbEhhc2giOiJFbWRmNE1MNXA1NGh2MkVDcHpFNno5Q0h3QWZHXC9oN3VaQ2dXZ2xzZ3NMST0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 0/5] net/ixgbe: move set VF functions. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Dec 2016 12:00:45 -0000 Hi Ferruh, > -----Original Message----- > From: Yigit, Ferruh > Sent: Friday, December 9, 2016 11:54 AM > To: Iremonger, Bernard ; > thomas.monjalon@6wind.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1 0/5] net/ixgbe: move set VF functions. >=20 > On 12/9/2016 11:27 AM, Bernard Iremonger wrote: > > This patchset implements the following deprecation notice: > > [PATCH v1] doc: announce API and ABI change for librte_ether > > > > The following functions from eth_dev_ops have been moved to the ixgbe > > PMD and renamed: > > > > ixgbe_set_pool_rx_mode > > ixgbe_set_pool_rx > > ixgbe_set_pool_tx > > ixgbe_set_pool_vlan_filter > > ixgbe_set_vf_rate_limit > > > > Renamed the functions to the following: > > > > rte_pmd_ixgbe_set_vf_rxmode > > rte_pmd_ixgbe_set_vf_rx > > rte_pmd_ixgbe_set_vf_tx > > rte_pmd_ixgbe_set_vf_vlan_filter > > rte_pmd_ixgbe_set_vf_rate_limit > > > > Testpmd has been modified to use the following functions: > > rte_pmd_ixgbe_set_vf_rxmode > > rte_pmd_ixgbe_set_vf_rate_limit > > > > New testpmd commands have been added to test the following functions: > > rte_pmd_ixgbe_set_vf_rx > > rte_pmd_ixgbe_set_vf_tx > > rte_pmd_ixgbe_set_vf_vlan_filter > > > > The testpmd user guide has been updated for the new commands. > > > > Bernard Iremonger (5): > > net/ixgbe: move set VF functions from the ethdev > > app/testpmd: use ixgbe public functions > > app/testpmd: add command for set VF VLAN filter > > app/testpmd: add command for set VF receive > > app/testpmd: add command for set VF transmit > > > > app/test-pmd/cmdline.c | 270 > +++++++++++++++++++++++++++- > > app/test-pmd/config.c | 31 ++-- > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 21 +++ > > drivers/net/ixgbe/ixgbe_ethdev.c | 263 > +++++++++++++++++++++++++++ > > drivers/net/ixgbe/rte_pmd_ixgbe.h | 104 +++++++++++ > > drivers/net/ixgbe/rte_pmd_ixgbe_version.map | 10 ++ > > 6 files changed, 678 insertions(+), 21 deletions(-) > > >=20 > Why this patchset doesn't remove ethdev updates for these functions? >=20 > ixgbe is the only user for these eth-dev_ops, since code moved to ixgbe > driver, they and relevant rte_eth_xx functions (and deprecation notice) c= an > be removed in this patchset. Most probably after testpmd updated to > prevent compilation errors. My understanding is that the functions should be copied and reworked before= being removed from the ethdev, and that the removal should be done in a se= parate patch set. Hi Thomas, Could you clarify please. Regards, Bernard.