From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 23FBF20F for ; Tue, 13 Dec 2016 10:04:56 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP; 13 Dec 2016 01:04:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,340,1477983600"; d="scan'208";a="201994137" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga004.fm.intel.com with ESMTP; 13 Dec 2016 01:04:54 -0800 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 13 Dec 2016 09:04:53 +0000 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.159]) by irsmsx112.ger.corp.intel.com ([169.254.1.113]) with mapi id 14.03.0248.002; Tue, 13 Dec 2016 09:04:53 +0000 From: "Iremonger, Bernard" To: "Yigit, Ferruh" , "thomas.monjalon@6wind.com" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 6/9] examples/ethtool: use ixgbe public function Thread-Index: AQHSVH7B4YprjE40kEuadzbD4pRGX6EEf5qAgAEXFmA= Date: Tue, 13 Dec 2016 09:04:52 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C224D06CAE@IRSMSX108.ger.corp.intel.com> References: <1481304361-16032-1-git-send-email-bernard.iremonger@intel.com> <1481550626-14539-7-git-send-email-bernard.iremonger@intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDI0ZTE2ZjUtZWVlNS00NTdiLTkxYzctNjlkMDdkMzY4YTVkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjIuMTEuMCIsIlRydXN0ZWRMYWJlbEhhc2giOiIyM21aSGpuZ0tiUlVlM0VzdnZcLzZSVEJVQzJkck9INnRPZkFTN3o3N1BRRT0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 6/9] examples/ethtool: use ixgbe public function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Dec 2016 09:04:57 -0000 Hi Ferruh, > -----Original Message----- > From: Yigit, Ferruh > Sent: Monday, December 12, 2016 4:25 PM > To: Iremonger, Bernard ; > thomas.monjalon@6wind.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 6/9] examples/ethtool: use ixgbe public > function >=20 > On 12/12/2016 1:50 PM, Bernard Iremonger wrote: > > Replace rte_eth_dev_set_vf_rxmode with > rte_pmd_ixgbe_set_vf_rx_mode. > > > > Signed-off-by: Bernard Iremonger > > --- > > examples/ethtool/lib/rte_ethtool.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/examples/ethtool/lib/rte_ethtool.c > b/examples/ethtool/lib/rte_ethtool.c > > index a1f91d4..0e539f7 100644 > > --- a/examples/ethtool/lib/rte_ethtool.c > > +++ b/examples/ethtool/lib/rte_ethtool.c > > @@ -1,7 +1,7 @@ > > /*- > > * BSD LICENSE > > * > > - * Copyright(c) 2010-2015 Intel Corporation. All rights reserved. > > + * Copyright(c) 2010-2016 Intel Corporation. All rights reserved. > > * All rights reserved. > > * > > * Redistribution and use in source and binary forms, with or withou= t > > @@ -36,6 +36,7 @@ > > #include > > #include > > #include > > +#include > > #include "rte_ethtool.h" > > > > #define PKTPOOL_SIZE 512 > > @@ -354,7 +355,7 @@ rte_ethtool_net_set_rx_mode(uint8_t port_id) > > > > /* Set VF vf_rx_mode, VF unsupport status is discard */ > > for (vf =3D 0; vf < num_vfs; vf++) > > - rte_eth_dev_set_vf_rxmode(port_id, vf, > > + rte_pmd_ixgbe_set_vf_rxmode(port_id, vf, >=20 > Will these cause a build error if IXGBE_PMD is not enabled? Yes, I will send a v4. >=20 > > ETH_VMDQ_ACCEPT_UNTAG, 0); > > > > /* Enable Rx vlan filter, VF unspport status is discard */ > > Regards, Bernard.