From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id BABD4D4E0; Wed, 11 Jan 2017 16:47:36 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP; 11 Jan 2017 07:47:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,346,1477983600"; d="scan'208";a="51825456" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga005.jf.intel.com with ESMTP; 11 Jan 2017 07:47:35 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.173]) by IRSMSX151.ger.corp.intel.com ([169.254.4.20]) with mapi id 14.03.0248.002; Wed, 11 Jan 2017 15:47:17 +0000 From: "Iremonger, Bernard" To: "Yigit, Ferruh" , "Lu, Wenzhuo" , "dev@dpdk.org" CC: "Wu, Jingjing" , "stable@dpdk.org" Thread-Topic: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix ixgbe private API calling Thread-Index: AQHSa7UsMXEj69zzjU+lJx9SAm44+qEzEejQgABR6jCAAAMGgIAAAyag Date: Wed, 11 Jan 2017 15:47:16 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C224D1CD35@IRSMSX108.ger.corp.intel.com> References: <1484102853-53205-1-git-send-email-wenzhuo.lu@intel.com> <8CEF83825BEC744B83065625E567D7C224D1CB14@IRSMSX108.ger.corp.intel.com> <8CEF83825BEC744B83065625E567D7C224D1CCE7@IRSMSX108.ger.corp.intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmU5OThhYWQtNGYzOS00ODJhLTlkZWItNzNlMzQ3ZWU3ZTFkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjIuMTEuMCIsIlRydXN0ZWRMYWJlbEhhc2giOiIwcEFwcFwvamU4dWxJVUlxRnBPak5Tb2c5OWRqWmNIajZsM3lJWldEVlpsZz0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix ixgbe private API calling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2017 15:47:37 -0000 Hi Ferruh, > -----Original Message----- > From: Yigit, Ferruh > Sent: Wednesday, January 11, 2017 3:27 PM > To: Iremonger, Bernard ; Lu, Wenzhuo > ; dev@dpdk.org > Cc: Wu, Jingjing ; stable@dpdk.org > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix ixgbe > private API calling >=20 > On 1/11/2017 3:20 PM, Iremonger, Bernard wrote: > > Hi Wenzhuo, > > > > > >>> Subject: [dpdk-dev] [PATCH] app/testpmd: fix ixgbe private API > >>> calling > >>> > >>> Some ixgbe private APIs are added to expose ixgbe specific functions. > >>> When they're used by testpmd, there's no check for if the NICs are > ixgbe. > >>> Other NICs also have chance to call these APIs. > >>> This patch add the check and the feedback print. > >> > >> I am not sure that testpmd is the right place to do this. > >> The rte_pmd_ixgbe_* functions are public API's which can be called by > >> other applications. > >> The checks should be in the rte_pmd_ixgbe_* API's > > > > It is useful to handle the return code -ENOTSUP in testpmd. > > >=20 > Makes sense, and I think it is good idea to add them in your patch, since= it > introduces returning -ENOTSUP, would you mind sending a new version of > your patch with this update? > So we can drop this patch completely. >=20 > Thanks, > ferruh > I don't think this patch should be dropped. Testpmd is already handling -EINVAL and -ENODEV. It makes sense for it to handle -ENOTSUP for the cases in the patch. Regards, Bernard.