From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id D1BF52B92 for ; Fri, 31 Mar 2017 19:05:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490979945; x=1522515945; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=aemvW8LBdyy89+iTHCUzAk9P7aAt33iNUQLETLKazUg=; b=f5mNQH6Q5JGrWeuxH2A6SLqO6dr7sYAqkamYI0J5L81aX259WF3R55M5 zbmr8HJBJqPMedCtZKBuksBuiscOMw==; Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Mar 2017 10:05:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,252,1486454400"; d="scan'208";a="72299393" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga004.jf.intel.com with ESMTP; 31 Mar 2017 10:05:30 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.239]) by IRSMSX152.ger.corp.intel.com ([169.254.6.231]) with mapi id 14.03.0319.002; Fri, 31 Mar 2017 18:05:29 +0100 From: "Iremonger, Bernard" To: "Yigit, Ferruh" , "dev@dpdk.org" , "Xing, Beilei" , "Wu, Jingjing" CC: "Zhang, Helin" , "Lu, Wenzhuo" Thread-Topic: [dpdk-dev] [PATCH v6 0/5] net/i40e: QinQ filter Thread-Index: AQHSqjISS/m0fYvyj0qoS7/kaaBvI6GvGWqAgAASmhA= Date: Fri, 31 Mar 2017 17:05:28 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C224D4E128@IRSMSX108.ger.corp.intel.com> References: <1490890196-23795-1-git-send-email-bernard.iremonger@intel.com> <1490973509-20916-1-git-send-email-bernard.iremonger@intel.com> <1ebd9937-1027-b25c-b5af-4c97312bf835@intel.com> In-Reply-To: <1ebd9937-1027-b25c-b5af-4c97312bf835@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTJlNjYwNjEtMGMwMC00YzE1LWIwZGYtZWM2OGU5YjgyZTVjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkNoZGRrTW1kT1wvb0pDSm5PeUE5SXVnYnJaaGhsTDZrXC81Q29WbTErc21TZz0ifQ== x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v6 0/5] net/i40e: QinQ filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Mar 2017 17:05:46 -0000 Hi Ferruh, > -----Original Message----- > From: Yigit, Ferruh > Sent: Friday, March 31, 2017 5:53 PM > To: Iremonger, Bernard ; dev@dpdk.org; > Xing, Beilei ; Wu, Jingjing > Cc: Zhang, Helin ; Lu, Wenzhuo > > Subject: Re: [dpdk-dev] [PATCH v6 0/5] net/i40e: QinQ filter >=20 > On 3/31/2017 4:18 PM, Bernard Iremonger wrote: > > It adds support for QinQ filters. > > It uses the replace filter Admin Queue command. > > > > Changes in v6: > > Rebase to latest dpdk-next-net. > > Fix checkpatch warnings. > > > > Changes in v5: > > Rebase to latest dpdk-next-net. > > Rebase patches 2 and 3 following comments. > > Uses map_5.88 firmware. > > > > Changes in v4: > > Reordered patches following comments. > > Revises patches 2 and 3 following comments. > > > > Changes in v3: > > Rebase to latest dpdk-next-net. > > Revised patches 1-3 following comments. > > Added patches 4 and 5. > > > > Changes in v2: > > Rebase to latest dpdk-next-net. > > Reordered patches, and reduced from 4 to 3 patches. > > > > Bernard Iremonger (5): > > net/i40e: initialise L3 MAP register > > net/i40e: add QinQ filter create function > > net/i40e: parse QinQ pattern > > net/i40e: update destroy tunnel filter function > > net/i40e: update tunnel filter restore function >=20 > Still getting some long-line checkpatch warnings [1], can you please chec= k > them? >=20 > Thanks, > ferruh >=20 > [1] > WARNING:LONG_LINE: line over 80 characters > #46: FILE: drivers/net/i40e/i40e_ethdev.c:1136: > + ret =3D i40e_aq_debug_write_register(hw, I40E_GLQF_L3_MAP(40), > 0x00000028, NULL); >=20 > WARNING:LONG_LINE: line over 80 characters > #144: FILE: drivers/net/i40e/i40e_ethdev.c:12363: > + filter_replace.old_filter_type =3D > I40E_AQC_REPLACE_CLOUD_CMD_INPUT_FV_STAG_IVLAN; >=20 > WARNING:LONG_LINE: line over 80 characters > #150: FILE: drivers/net/i40e/i40e_ethdev.c:12369: > + filter_replace_buf.data[0] |=3D > I40E_AQC_REPLACE_CLOUD_CMD_INPUT_VALIDATED; >=20 > WARNING:LONG_LINE: line over 80 characters > #154: FILE: drivers/net/i40e/i40e_ethdev.c:12373: > + filter_replace_buf.data[4] =3D > I40E_AQC_REPLACE_CLOUD_CMD_INPUT_FV_INNER_VLAN; >=20 > WARNING:LONG_LINE: line over 80 characters > #155: FILE: drivers/net/i40e/i40e_ethdev.c:12374: > + filter_replace_buf.data[4] |=3D > I40E_AQC_REPLACE_CLOUD_CMD_INPUT_VALIDATED; >=20 > WARNING:LONG_LINE: line over 80 characters > #159: FILE: drivers/net/i40e/i40e_ethdev.c:12378: > + ret =3D i40e_aq_replace_cloud_filters(hw, &filter_replace, > &filter_replace_buf); >=20 > WARNING:LONG_LINE: line over 80 characters > #176: FILE: drivers/net/i40e/i40e_ethdev.c:12395: > + filter_replace_buf.data[0] |=3D > I40E_AQC_REPLACE_CLOUD_CMD_INPUT_VALIDATED; >=20 > WARNING:LONG_LINE: line over 80 characters > #178: FILE: drivers/net/i40e/i40e_ethdev.c:12397: > + filter_replace_buf.data[4] |=3D > I40E_AQC_REPLACE_CLOUD_CMD_INPUT_VALIDATED; >=20 > WARNING:LONG_LINE: line over 80 characters > #179: FILE: drivers/net/i40e/i40e_ethdev.c:12398: > + ret =3D i40e_aq_replace_cloud_filters(hw, &filter_replace, > &filter_replace_buf); The checkpatch script is allowing lines up to 90 characters now. Previously long lines were acceptable . Regards, Bernard.