From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Rybalchenko, Kirill" <kirill.rybalchenko@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Rybalchenko, Kirill" <kirill.rybalchenko@intel.com>,
"Chilikin, Andrey" <andrey.chilikin@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/i40e: get information about protocols defined in ddp profile
Date: Mon, 4 Sep 2017 11:34:15 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C24E04420D@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1504075836-102681-2-git-send-email-kirill.rybalchenko@intel.com>
Hi Kirill,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Kirill Rybalchenko
> Sent: Wednesday, August 30, 2017 7:51 AM
> To: dev@dpdk.org
> Cc: Rybalchenko, Kirill <kirill.rybalchenko@intel.com>; Chilikin, Andrey
> <andrey.chilikin@intel.com>
> Subject: [dpdk-dev] [PATCH 1/2] net/i40e: get information about protocols
> defined in ddp profile
>
> This patch adds new package info types to get list of protocols, pctypes and
> ptypes defined in a profile
>
> Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
> ---
> drivers/net/i40e/rte_pmd_i40e.c | 155
> ++++++++++++++++++++++++++++++++++++++++
> drivers/net/i40e/rte_pmd_i40e.h | 25 +++++++
> 2 files changed, 180 insertions(+)
>
> diff --git a/drivers/net/i40e/rte_pmd_i40e.c
> b/drivers/net/i40e/rte_pmd_i40e.c index d69a472..f232d09 100644
> --- a/drivers/net/i40e/rte_pmd_i40e.c
> +++ b/drivers/net/i40e/rte_pmd_i40e.c
> @@ -1706,6 +1706,27 @@ rte_pmd_i40e_process_ddp_package(uint8_t
> port, uint8_t *buff,
> return status;
> }
>
> +
> +/* Get number of tvl records in the section */ static unsigned
Better to use static unsigned int instead of static unsigned
> +i40e_get_tlv_section_size(struct i40e_profile_section_header *sec) {
> + unsigned i, nb_rec, nb_tlv = 0;
> + struct i40e_profile_tlv_section_record *tlv;
> +
> + if (sec == NULL)
> + return nb_tlv;
> +
> + /* get number of records in the section */
> + nb_rec = sec->section.size / sizeof(struct
> i40e_profile_tlv_section_record);
> + for (i = 0; i < nb_rec; ) {
> + tlv = (struct i40e_profile_tlv_section_record *)&sec[1 + i];
> + i += tlv->len;
> + nb_tlv++;
> + }
> + return nb_tlv;
> +}
> +
> int rte_pmd_i40e_get_ddp_info(uint8_t *pkg_buff, uint32_t pkg_size,
> uint8_t *info_buff, uint32_t info_size,
> enum rte_pmd_i40e_package_info type)
> @@ -1860,6 +1881,140 @@ int rte_pmd_i40e_get_ddp_info(uint8_t
> *pkg_buff, uint32_t pkg_size,
> return I40E_SUCCESS;
> }
>
> + /* get number of protocols */
> + if (type == RTE_PMD_I40E_PKG_INFO_PROTOCOL_NUM) {
> + struct i40e_profile_section_header *proto;
> + if (info_size < sizeof(uint32_t)) {
> + PMD_DRV_LOG(ERR, "Invalid information buffer
> size");
> + return -EINVAL;
> + }
> + proto = i40e_find_section_in_profile(SECTION_TYPE_PROTO,
> + (struct i40e_profile_segment *)i40e_seg_hdr);
> + *(uint32_t *)info_buff = i40e_get_tlv_section_size(proto);
> + return I40E_SUCCESS;
> + }
> +
> + /* get list of protocols */
> + if (type == RTE_PMD_I40E_PKG_INFO_PROTOCOL_LIST) {
> + uint32_t i, j, nb_rec;
> + struct rte_pmd_i40e_proto_info *pinfo;
> + struct i40e_profile_section_header *proto;
> + struct i40e_profile_tlv_section_record *tlv;
> + proto = i40e_find_section_in_profile(SECTION_TYPE_PROTO,
> + (struct i40e_profile_segment *)i40e_seg_hdr);
> + nb_rec = i40e_get_tlv_section_size(proto);
> + if (info_size < nb_rec) {
> + PMD_DRV_LOG(ERR, "Invalid information buffer
> size");
> + return -EINVAL;
> + }
> + pinfo = (struct rte_pmd_i40e_proto_info *)info_buff;
> + for (i = 0; i < info_size; i++) {
> + pinfo[i].proto_id = RTE_PMD_I40E_PROTO_UNUSED;
> + memset(pinfo[i].name, 0,
> RTE_PMD_I40E_DDP_NAME_SIZE);
> + }
> + if (nb_rec == 0)
> + return I40E_SUCCESS;
> + /* get number of records in the section */
> + nb_rec = proto->section.size / sizeof(struct
> i40e_profile_tlv_section_record);
> + tlv = (struct i40e_profile_tlv_section_record *)&proto[1];
> + for (i = j = 0; i < nb_rec; j++) {
> + pinfo[j].proto_id = tlv->data[0];
> + strncpy(pinfo[j].name, (const char *)&tlv->data[1],
> I40E_DDP_NAME_SIZE);
> + i += tlv->len;
> + tlv = &tlv[tlv->len];
> + }
> + return I40E_SUCCESS;
> + }
> +
> + /* get number of packet classification types */
> + if (type == RTE_PMD_I40E_PKG_INFO_PCTYPE_NUM) {
> + struct i40e_profile_section_header *pctype;
> + if (info_size < sizeof(uint32_t)) {
> + PMD_DRV_LOG(ERR, "Invalid information buffer
> size");
> + return -EINVAL;
> + }
> + pctype =
> i40e_find_section_in_profile(SECTION_TYPE_PCTYPE,
> + (struct i40e_profile_segment *)i40e_seg_hdr);
> + *(uint32_t *)info_buff = i40e_get_tlv_section_size(pctype);
> + return I40E_SUCCESS;
> + }
> +
> + /* get list of packet classification types */
> + if (type == RTE_PMD_I40E_PKG_INFO_PCTYPE_LIST) {
> + uint32_t i, j, nb_rec;
> + struct rte_pmd_i40e_ptype_info *pinfo;
> + struct i40e_profile_section_header *pctype;
> + struct i40e_profile_tlv_section_record *tlv;
> + pctype =
> i40e_find_section_in_profile(SECTION_TYPE_PCTYPE,
> + (struct i40e_profile_segment *)i40e_seg_hdr);
> + nb_rec = i40e_get_tlv_section_size(pctype);
> + if (info_size < nb_rec) {
> + PMD_DRV_LOG(ERR, "Invalid information buffer
> size");
> + return -EINVAL;
> + }
> + pinfo = (struct rte_pmd_i40e_ptype_info *)info_buff;
> + for (i = 0; i < info_size; i++)
> + memset(&pinfo[i],
> RTE_PMD_I40E_PROTO_UNUSED,
> + sizeof(struct rte_pmd_i40e_ptype_info));
> +
> + if (nb_rec == 0)
> + return I40E_SUCCESS;
> + /* get number of records in the section */
> + nb_rec = pctype->section.size / sizeof(struct
> i40e_profile_tlv_section_record);
> + tlv = (struct i40e_profile_tlv_section_record *)&pctype[1];
> + for (i = j = 0; i < nb_rec; j++) {
> + pinfo[j].ptype_id = tlv->data[0];
> + memcpy(&pinfo[j], tlv->data, sizeof(struct
> rte_pmd_i40e_ptype_info));
> + i += tlv->len;
> + tlv = &tlv[tlv->len];
> + }
> + return I40E_SUCCESS;
> + }
> +
> + /* get number of packet types */
> + if (type == RTE_PMD_I40E_PKG_INFO_PTYPE_NUM) {
> + struct i40e_profile_section_header *ptype;
> + if (info_size < sizeof(uint32_t)) {
> + PMD_DRV_LOG(ERR, "Invalid information buffer
> size");
> + return -EINVAL;
> + }
> + ptype = i40e_find_section_in_profile(SECTION_TYPE_PTYPE,
> + (struct i40e_profile_segment *)i40e_seg_hdr);
> + *(uint32_t *)info_buff = i40e_get_tlv_section_size(ptype);
> + return I40E_SUCCESS;
> + }
> +
> + /* get list of packet types */
> + if (type == RTE_PMD_I40E_PKG_INFO_PTYPE_LIST) {
> + uint32_t i, nb_rec;
> + struct rte_pmd_i40e_ptype_info *pinfo;
> + struct i40e_profile_section_header *ptype;
> + struct i40e_profile_tlv_section_record *tlv;
> + ptype = i40e_find_section_in_profile(SECTION_TYPE_PTYPE,
> + (struct i40e_profile_segment *)i40e_seg_hdr);
> + nb_rec = i40e_get_tlv_section_size(ptype);
> + if (info_size < nb_rec) {
> + PMD_DRV_LOG(ERR, "Invalid information buffer
> size");
> + return -EINVAL;
> + }
> + pinfo = (struct rte_pmd_i40e_ptype_info *)info_buff;
> + for (i = 0; i < info_size; i++)
> + memset(&pinfo[i],
> RTE_PMD_I40E_PROTO_UNUSED,
> + sizeof(struct rte_pmd_i40e_ptype_info));
> +
> + if (nb_rec == 0)
> + return I40E_SUCCESS;
> + /* get number of records in the section */
> + nb_rec = ptype->section.size / sizeof(struct
> i40e_profile_tlv_section_record);
> + for (i = 0; i < nb_rec; ) {
> + tlv = (struct i40e_profile_tlv_section_record
> *)&ptype[1 + i];
> + pinfo[i].ptype_id = tlv->data[0];
> + memcpy(&pinfo[i], tlv->data, sizeof(struct
> rte_pmd_i40e_ptype_info));
> + i += tlv->len;
> + }
> + return I40E_SUCCESS;
> + }
> +
> PMD_DRV_LOG(ERR, "Info type %u is invalid.", type);
> return -EINVAL;
> }
Checkpatch is showing a lot of warnings in this file.
> diff --git a/drivers/net/i40e/rte_pmd_i40e.h
> b/drivers/net/i40e/rte_pmd_i40e.h index 155b7e8..b631093 100644
> --- a/drivers/net/i40e/rte_pmd_i40e.h
> +++ b/drivers/net/i40e/rte_pmd_i40e.h
> @@ -88,6 +88,12 @@ enum rte_pmd_i40e_package_info {
> RTE_PMD_I40E_PKG_INFO_HEADER,
> RTE_PMD_I40E_PKG_INFO_DEVID_NUM,
> RTE_PMD_I40E_PKG_INFO_DEVID_LIST,
> + RTE_PMD_I40E_PKG_INFO_PROTOCOL_NUM,
> + RTE_PMD_I40E_PKG_INFO_PROTOCOL_LIST,
> + RTE_PMD_I40E_PKG_INFO_PCTYPE_NUM,
> + RTE_PMD_I40E_PKG_INFO_PCTYPE_LIST,
> + RTE_PMD_I40E_PKG_INFO_PTYPE_NUM,
> + RTE_PMD_I40E_PKG_INFO_PTYPE_LIST,
> RTE_PMD_I40E_PKG_INFO_MAX = 0xFFFFFFFF };
>
> @@ -133,6 +139,25 @@ struct rte_pmd_i40e_profile_list {
> struct rte_pmd_i40e_profile_info p_info[1]; };
>
> +#define RTE_PMD_I40E_PROTO_NUM 6
> +#define RTE_PMD_I40E_PROTO_UNUSED 0xFF
> +
> +/**
> +* Protocols information stored in profile */ struct
> +rte_pmd_i40e_proto_info {
> + uint8_t proto_id;
> + char name[RTE_PMD_I40E_DDP_NAME_SIZE]; };
> +
> +/**
> +* Packet classification/ packet type information stored in profile */
Checkpatch is giving a warning with the above line.
> +struct rte_pmd_i40e_ptype_info {
> + uint8_t ptype_id;
> + uint8_t protocols[RTE_PMD_I40E_PROTO_NUM];
> +};
> +
> /**
> * ptype mapping table only accept RTE_PTYPE_XXX or "user defined" ptype.
> * A ptype with MSB set will be regarded as a user defined ptype.
> --
> 2.5.5
Regards,
Bernard.
next prev parent reply other threads:[~2017-09-04 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 6:50 [dpdk-dev] [PATCH 0/2] " Kirill Rybalchenko
2017-08-30 6:50 ` [dpdk-dev] [PATCH 1/2] " Kirill Rybalchenko
2017-09-04 11:34 ` Iremonger, Bernard [this message]
2017-08-30 6:50 ` [dpdk-dev] [PATCH 2/2] app/testpmd: " Kirill Rybalchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C24E04420D@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=andrey.chilikin@intel.com \
--cc=dev@dpdk.org \
--cc=kirill.rybalchenko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).