From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 9489C200 for ; Tue, 19 Dec 2017 13:13:25 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2017 04:13:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,426,1508828400"; d="scan'208";a="188291605" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga006.fm.intel.com with ESMTP; 19 Dec 2017 04:13:23 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.167]) by IRSMSX153.ger.corp.intel.com ([169.254.9.34]) with mapi id 14.03.0319.002; Tue, 19 Dec 2017 12:13:22 +0000 From: "Iremonger, Bernard" To: "Singh, Jasvinder" , "Kovacevic, Marko" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 4/4] doc: update documentation for flow classify lib Thread-Index: AQHTd/AJ/eNhkq87CUeEG+pc2qp0VqNJG8kAgAF5V4A= Date: Tue, 19 Dec 2017 12:13:22 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C24E06A9B8@IRSMSX108.ger.corp.intel.com> References: <20171211162646.146936-1-jasvinder.singh@intel.com> <20171215103924.5185-1-jasvinder.singh@intel.com> <20171215103924.5185-4-jasvinder.singh@intel.com> <6DC05C7C5F25994B81B3F2F214251F6632AAEB@IRSMSX104.ger.corp.intel.com> <54CBAA185211B4429112C315DA58FF6D3329F33B@IRSMSX103.ger.corp.intel.com> In-Reply-To: <54CBAA185211B4429112C315DA58FF6D3329F33B@IRSMSX103.ger.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2JlOTY1MDItMjFiMi00ZDA5LWEwOWItY2NkZTA0MzhmYWU1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJHdUFKM2VySFBPMllrSUZzb2E1Z3pmbW0wRFY1OVFtQVQwdnVLUmtIRVZHRkQxWFVvcDlzcVp1em9kSjV5NGxKIn0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 4/4] doc: update documentation for flow classify lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Dec 2017 12:13:26 -0000 Hi Jasvinder, > -----Original Message----- > From: Singh, Jasvinder > Sent: Monday, December 18, 2017 1:41 PM > To: Kovacevic, Marko ; dev@dpdk.org > Cc: Iremonger, Bernard > Subject: RE: [dpdk-dev] [PATCH v3 4/4] doc: update documentation for flow > classify lib >=20 >=20 >=20 > > -----Original Message----- > > From: Kovacevic, Marko > > Sent: Monday, December 18, 2017 11:05 AM > > To: Singh, Jasvinder ; dev@dpdk.org > > Cc: Iremonger, Bernard > > Subject: RE: [dpdk-dev] [PATCH v3 4/4] doc: update documentation for > > flow classify lib > > > > > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jasvinder Singh > > > Sent: Friday, December 15, 2017 10:39 AM > > > To: dev@dpdk.org > > > Cc: Iremonger, Bernard > > > Subject: [dpdk-dev] [PATCH v3 4/4] doc: update documentation for > > > flow classify lib > > > > > > Updates the documentation for flow classification library and sample > > > application. > > > > > > Signed-off-by: Jasvinder Singh > > > > > > > v3: > > > - add validate API desciption to programmers guide > > > > Small typo desciption/ description > > > > > > > @@ -225,11 +236,16 @@ The ``Classifier`` has the following internal > > structures: > > > /* Input parameters */ > > > char name[RTE_FLOW_CLASSIFIER_MAX_NAME_SZ]; > > > int socket_id; > > > - enum rte_flow_classify_table_type type; > > > > > > - /* Internal tables */ > > > - struct rte_table tables[RTE_FLOW_CLASSIFY_TABLE_MAX]; > > > + /* Internal */ > > > + /* ntuple_fliter */ > > > > Small typo above. Ntuple_fliter/ ntuple_filter. > > > > > > > + struct rte_eth_ntuple_filter ntuple_filter; > > > + > > > + /* clasifier tables */ > > > > Same above clasifier / classifier > > > > > > > To create an ACL table the ``rte_table_acl_params`` structure must > > > be @@ - > > > 314,14 +329,14 @@ and SCTP. > > > RTE_FLOW_ITEM_TYPE_END, > > > }; > > > > > > -The internal function ``flow_classify_parse_flow`` parses the > > > +The API function ``rte_flow_classify_validate`` parses the > > > IPv4 5-tuple pattern, attributes and actions and returns the > > > 5-tuple data in the ``rte_eth_ntuple_filter`` structure. > > > > > > .. code-block:: c > > > > > > static int > > > - flow_classify_parse_flow( > > > + rte_flow_classify_validate(struct rte_flow_classifier *cls, > > > const struct rte_flow_attr *attr, > > > const struct rte_flow_item pattern[], > > > const struct rte_flow_action actions[], @@ > > > -333,7 > > > +348,7 @@ Adding Flow Rules The > > > +``rte_flow_classify_table_entry_add`` > > > API creates an ``rte_flow_classify`` object which contains the > > > flow_classify id and type, the action, a union of add and delete > > > keys and a > > union of rules. > > > -It uses the ``flow_classify_parse_flow`` internal function for > > > parsing the > > > +It uses the ``rte_flow_classify_validate`` api function for parsing > > > +the > > > > Above api/ API > > > > > > Otherwise everything else seem ok > > > > Acked-by: Marko Kovacevic > > >=20 > Thanks Marko for review. I will fix them in next version. >=20 > Jasvinder With above typo's fixed. Acked-by: Bernard Iremonger