From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Daniel Shelepov <dashel@microsoft.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix burst stat reporting
Date: Fri, 11 May 2018 11:18:18 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C24E0CA1D8@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <20180504201209.2964-1-dashel@microsoft.com>
Hi Daniel,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Daniel Shelepov
> Sent: Friday, May 4, 2018 9:12 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Daniel Shelepov <dashel@microsoft.com>
> Subject: [dpdk-dev] [PATCH] app/testpmd: fix burst stat reporting
>
> When RTE_TEST_PMD_RECORD_BURST_STATS is enabled, testpmd collects
> burst statistics and includes them in the port stats report. The summary
> should include top 2 most frequent burst sizes, but there is a bug in finding
> the top-2. During the scan of burst size counts, the
> top-2 can change only if top-1 also changes.
>
> Added logic to update the top-2 if current burst size is larger than existing
> top-2, but smaller than existing top-1.
Could you add a fixes line.
>
> Signed-off-by: Daniel Shelepov <dashel@microsoft.com>
> ---
> app/test-pmd/testpmd.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> db23f23e5..cc38e51fc 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -927,6 +927,9 @@ pkt_burst_stats_display(const char *rx_tx, struct
> pkt_burst_stats *pbs)
> pktnb_stats[1] = pktnb_stats[0];
> burst_stats[0] = nb_burst;
> pktnb_stats[0] = nb_pkt;
> + } else if (nb_burst > burst_stats[1]) {
> + burst_stats[1] = nb_burst;
> + pktnb_stats[1] = nb_pkt;
> }
> }
> if (total_burst == 0)
> --
> 2.15.1.gvfs.2.39.g03d366a
Regards,
Bernard
next prev parent reply other threads:[~2018-05-11 11:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 20:12 Daniel Shelepov
2018-05-11 11:18 ` Iremonger, Bernard [this message]
2018-05-14 21:12 ` [dpdk-dev] [PATCH v2] " Daniel Shelepov
2018-05-16 11:09 ` Iremonger, Bernard
2018-05-21 15:15 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C24E0CA1D8@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=dashel@microsoft.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).